[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Sannita added a comment. In T97018#3217658, @Lucas_Werkmeister_WMDE wrote: @Sannita: Thanks for your feedback! The violation in P569 is because of this constraint on P569’s talk page: Difference with “date of birth (P569)” within range [30, 150]: the difference with property “date of birth (P569)” should be in the range from “30” to “150”. Read: a date of birth should be at least 30 years away from itself. In my opinion, that makes no sense, and I don’t know who added it… but the constraint is there, we imported it, and now the API reports violations for it on practically every human with a date of birth :/ Got it. I already saw somebody contacted the user who added that restriction. The *very* strange thing is that I get the same violation twice - it's still the very same of the image I posted before. However, the constraint on P570 is more sensible (within 0-150 years of date of birth), so I don’t know why that would report a violation. Did you get violations for P570 as well, or only for P569? I have a "Range ⧼wbqc-violation-message-range-parameters-needed⧽" violation on p570, but only once. It seems to be either a malfunction or we didn't still described that violation. And can you please elaborate on the malfunction with P27? It disappeared since my last comment, so we can ignore it, I think.TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SannitaCc: Sannita, Lea_Lacroix_WMDE, Lucas_Werkmeister_WMDE, gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, SamanthaNguyen, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Lucas_Werkmeister_WMDE added a comment. @Sannita: Thanks for your feedback! The violation in P569 is because of this constraint on P569’s talk page: Difference with “date of birth (P569)” within range [30, 150]: the difference with property “date of birth (P569)” should be in the range from “30” to “150”. Read: a date of birth should be at least 30 years away from itself. In my opinion, that makes no sense, and I don’t know who added it… but the constraint is there, we imported it, and now the API reports violations for it on practically every human with a date of birth :/ However, the constraint on P570 is more sensible (within 0-150 years of date of birth), so I don’t know why that would report a violation. Did you get violations for P570 as well, or only for P569? And can you please elaborate on the malfunction with P27?TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Sannita, Lea_Lacroix_WMDE, Lucas_Werkmeister_WMDE, gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, SamanthaNguyen, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
gerritbot added a comment. Change 348080 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add user script to include reports on item pages https://gerrit.wikimedia.org/r/348080TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, SamanthaNguyen, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Lucas_Werkmeister_WMDE added a comment. Change 348080 adds a user script that shows a violation indicator, similar to Jan’s mockup. Here’s what it looks like: F7750910: image.png (The particular constraints here are not very meaningful, just added for testing. Also, the extension currently doesn’t have different severities of violations, so there are no different icons we could show.)TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, SamanthaNguyen, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
gerritbot added a comment. Change 348080 had a related patch set uploaded (by Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add user script to include reports on item pages https://gerrit.wikimedia.org/r/348080TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Pintoch, Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, QZanden, SamanthaNguyen, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Lydia_Pintscher added a comment. {icon thumbs-up}TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, QZanden, SamanthaNguyen, JGirault, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Jan_Dittrich added a comment. Some remarks from a usability perspective: We have few space (Which makes icons attractive) …but no one understands Icons we think up ourselves …in particular, simple traffic-light metaphors are to be avoided, since in their full-traffic-light they use up much space and in the just-colored-light they are not accessible to the colorblind population One solution would be: What is shown There is one standardized set for icons, e.g. a warning sign (violation) and a stop sign (severe violation). When there is no violation, nothing is shown, if there is one violation it’s grade of severity is shown in the icon if there are multiple violations, the icon for the most severe is shown We can show a number behind the icon indicating the number of violations upon click on the icon, we show a list of violations (as the click on the mediawikis up-right area message tray shows a list of mentions) Mock: 1) small version of indicator 2) larger version of indicator 3) expanded infos F7076727: image.png We could offer an API for that, so that you can hook in your checks as well as your UI for them. The latter could be done declaratively.TASK DETAILhttps://phabricator.wikimedia.org/T97018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Jan_Dittrich, abian, Bene, Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, QZanden, SamanthaNguyen, JGirault, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Tamslo added a comment. F1492568: screenshot_item.jpg https://phabricator.wikimedia.org/F1492568 TASK DETAIL https://phabricator.wikimedia.org/T97018 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dominic.sauer, Tamslo Cc: Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97018: [Story] Integrate violations into Wikidata UI
Jonas added a subscriber: Jonas. Jonas added a comment. Can you please insert existing mock-ups to the description? TASK DETAIL https://phabricator.wikimedia.org/T97018 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dominic.sauer, Jonas Cc: Jonas, Ricordisamoa, dominic.sauer, Liuxinyu970226, Aklapper, Tamslo, Wikidata-bugs, aude, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs