[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
Jc3s5h added a comment. I offer a list of test cases.TASK DETAILhttps://phabricator.wikimedia.org/T98194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jc3s5hCc: T.seppelt, Tobi_WMDE_SW, Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
thiemowmde added a comment. As hinted in https://phabricator.wikimedia.org/T98194#1684440 the original task description is still valid: When entering "February 29, 1700" our set of date parsers wrongly turn this into "1 March 1700". This ticket was in the sprint because of numeric inputs like "29.2.1700" and "02/29/1700", which are now allowed. TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Tobi_WMDE_SW, Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW. Tobi_WMDE_SW added a comment. @thiemowmde @jonas patch is merged, is this fixed now and can be closed? TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: Tobi_WMDE_SW, Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
gerritbot added a comment. Change 240714 merged by jenkins-bot: Use YearMonthDayTimeParser in TimeParserFactory https://gerrit.wikimedia.org/r/240714 TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
thiemowmde added a comment. "1700-02-29" is "ISO-like" and parsed by IsoTimestampParser. YearMonthDayTimeParser is currently not able to parse localized month names. This is by design. It can parse everything that contains three numbers, e.g. "29.2.1700", "02/29/1700" and so on. These two test cases should be added to https://gerrit.wikimedia.org/r/240714. In https://github.com/DataValues/Time/pull/93 I'm exploring the idea to make YearMonthDayTimeParser aware of localized month names, but I'm not sure if this is the right thing to do. I need time to collect test cases. TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
Jonas added a subscriber: Jonas. Jonas added a comment. In https://phabricator.wikimedia.org/T98194#1641408, @thiemowmde wrote: > The relevant YearMonthDayTimeParser (see > https://github.com/DataValues/Time/blob/master/src/ValueParsers/YearMonthDayTimeParser.php) > that could fix this and quite a lot similar issues is already merged and > released for a while now. It's just not used in Wikibase repo. Unfortunately the YearMonthDayTimeParser is not fixing the problem. Do you have an idea @thiemowmde ? TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: Jonas, gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 240714 had a related patch set uploaded (by Jonas Kress (WMDE)): [WIP] Use YearMonthDayTimeParser in TimeParserFactory https://gerrit.wikimedia.org/r/240714 TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98194: [Bug] Date parser does not allow February 29, 1700 (Julian)
Jc3s5h added a comment. In https://phabricator.wikimedia.org/T98194#1641408, @thiemowmde wrote: > The relevant YearMonthDayTimeParser (see > https://github.com/DataValues/Time/blob/master/src/ValueParsers/YearMonthDayTimeParser.php) > that could fix this and quite a lot similar issues is already merged and > released for a while now. It's just not used in Wikibase repo. I notice this course calls eraParser. EraParser (see https://github.com/DataValues/Time/blob/master/src/ValueParsers/EraParser.php) appears to recognize years that contain + as CE, - as BCE, and several variations of the suffix as the appropriate era (CE, AD, Anno Domini, BCE, Before Christ, etc.) But I was unable to figure out what EraParser will do if the year is 0. TASK DETAIL https://phabricator.wikimedia.org/T98194 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jc3s5h Cc: Jc3s5h, daniel, thiemowmde, Aklapper, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
