[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-28 Thread Pablo-WMDE 
Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... - Built in Mediawiki rights: https://www.mediawiki.org/wiki/Manual:User_rights#List_of_permissions
- Wikibase `repo/includes/Store/EntityPermissionChecker.php`TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-28 Thread Pablo-WMDE 
Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Links:**
 - Built in Mediawiki rights: https://www.mediawiki.org/wiki/Manual:User_rights#List_of_permissions...TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-13 Thread Lydia_Pintscher 
Lydia_Pintscher updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...> THEN Show the error message from the API (the general error handling in Wikibase). To be clarified: !!where does it show ( at the save button?)!!


**Links:**...TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-13 Thread WMDE-leszek 
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...> THEN !!TO BE DEFINED WHAT HAPPENS (generic error handling)!!Show the error message from the API (the general error handling in Wikibase). To be clarified: !!where does it show (save button?)!!


**Links:**...TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-13 Thread Addshore 
Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...> WHEN I have no right to do not have the "edit pages" right
> THEN I see no edit buttons...> AND I have no right to do not have the "edit pages" right
> AND I see edit buttons...TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-13 Thread Addshore 
Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONEditing a Lexeme must only be possible by accounts with the right to "edit pages" right*  A user without the right to "edit pages" right can not edit any part of a Lexeme...> THEN !!TO BE DEFINED WHAT HAPPENS (generic error handling)!!



**Links:**
 - Built in Mediawiki rights: https://www.mediawiki.org/wiki/Manual:User_rights#List_of_permissionsTASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T189480: Enforce permission checks when editing Lexeme

2018-03-12 Thread Pablo-WMDE 
Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONEditing a Lexeme must only be possible by accounts with the right to edit pages.

= Acceptance criteria: =
*  A user without the right to edit pages can not edit any part of a Lexeme

= Scenarios =

Given== Scenario: Not authorized ==
> GIVEN I am on the Lexeme page
When> WHEN I have no right to edit pages
Then> THEN I see no edit buttons

Given I am on the Lexeme== Scenario: Authorization revoked after page load ==
And I have no right to edit> GIVEN I am on the Lexeme pages
And I see edit buttons> AND I have no right to edit pages
When I> AND I see edit somethingbuttons
And I submit changes> WHEN I edit something
Then TO BE DEFINED WHAT HAPPENS (generic error handling)

Hint: This could happen when the rights are revoked once I have already opened the page.> AND I submit changes
> THEN !!TO BE DEFINED WHAT HAPPENS (generic error handling)!!



TASK DETAILhttps://phabricator.wikimedia.org/T189480EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs