[Wikidata-bugs] [Maniphest] [Edited] T204469: WikibaseQualityConstraints should respect query service 429 header response.
Addshore updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONWhen the quality constraints API is hit repeatedly mediawiki will flood the query service with requests, and the result will be mediawiki will get banned as in T163642T204267TASK DETAILhttps://phabricator.wikimedia.org/T204469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Matthias_Geisler_WMDE, AddshoreCc: gerritbot, Smalyshev, Jonas, Ladsgroup, Lucas_Werkmeister_WMDE, Addshore, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T204469: WikibaseQualityConstraints should respect query service 429 header response.
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - if no retry-after is present, a warning should be logged --- General implementation breakdown: - [ ] write timestamp to cache when a 429 response is received - [ ] read from cache to check if we can make SPARQL requests or not The best cache to use is probably `ObjectCache::newAnything()`, so that the 429 protection will still work even if no cache is set up (falling back to the database). This should probably be wrapped up in some new class similar to the existing `ResultsCache`.TASK DETAILhttps://phabricator.wikimedia.org/T204469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Smalyshev, Jonas, Ladsgroup, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T204469: WikibaseQualityConstraints should respect query service 429 header response.
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - If a 429 is received and, a notice should be logged - if no retry-after is not present, a warning should be loggedTASK DETAILhttps://phabricator.wikimedia.org/T204469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Smalyshev, Jonas, Ladsgroup, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T204469: WikibaseQualityConstraints should respect query service 429 header response.
Addshore updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...To avoid getting banned our requests should respect the header returned by the query service (suggested in T204267#4584397) TBA more detials **BDD**...THEN QualityConstraints should not run fresh constraint reports using the query service for that number of seconds TBA more BDD if retry-after is not always present? **Links**... - The Retry-after back off is used across all servers - TBA depending on if- If a 429 is received and no retry-after is not alway presentt present, a warning should be loggedTASK DETAILhttps://phabricator.wikimedia.org/T204469EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Smalyshev, Jonas, Ladsgroup, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
