[Wikidata-bugs] [Maniphest] [Updated] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-02-25 Thread thiemowmde 
thiemowmde added a blocked task: T127067: [Story] Reduce initialisation time of 
SiteLinks.

TASK DETAIL
  https://phabricator.wikimedia.org/T124786

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: gerritbot, Lydia_Pintscher, adrianheine, Jonas, thiemowmde, Aklapper, Izno, 
Wikidata-bugs, aude, GWicke, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-01-27 Thread thiemowmde 
thiemowmde added a comment.

Candidates in the terms section:

[X] label-, description- and aliasesview are all fine. All three handle edits 
itself and propagate them to a changer. Both `isInitialValue` and `value` (the 
later is tracked in https://phabricator.wikimedia.org/T124787) are required for 
that. The only issue is that the code of the three widgets looks different, but 
shouldn't.
[X] entitytermsforlanguageview wraps a label-, description- and aliasesview. 
It's `isInitialValue` forwards nicely.
[ ] entitytermsforlanguagelistview contains a list of 
entitytermsforlanguageview widgets. It does not forward `isInitialValue` but 
instead does a complicated comparison. This is the main issue why I created 
this ticket.
[X] entitytermsview wraps a single entitytermsforlanguagelistview and forwards 
nicely.

Statements section:

[ ] statementview forwards to RankSelector.isInitialValue as well as 
snakview.isInitialValue, but compares qualifiers and references manually.
[ ] snaklistview contains a list of snakview widgets, but does not forward.
[ ] snakview is complicated. Does this count as a "leaf object"? Why is the 
code so complicated?
[X] RankSelector is trivial and fine.
[ ] referenceview is also complicated and needs more investigation.

Sitelinks section:

[X] sitelinkgroupview wraps a single sitelinklistview and forwards nicely.
[ ] sitelinklistview contains a list of sitelinkview widgets and should forward.
[X] sitelinkview is a "leaf object" and fine.


TASK DETAIL
  https://phabricator.wikimedia.org/T124786

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Lydia_Pintscher, adrianheine, Jonas, thiemowmde, Aklapper, Wikidata-bugs, 
aude, GWicke, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-01-27 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T124786

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde, gerritbot
Cc: gerritbot, Lydia_Pintscher, adrianheine, Jonas, thiemowmde, Aklapper, 
Wikidata-bugs, aude, GWicke, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-01-26 Thread thiemowmde 
thiemowmde added a blocked task: T124787: [Task] Remove all unused value() 
methods from view widgets.

TASK DETAIL
  https://phabricator.wikimedia.org/T124786

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Lydia_Pintscher, adrianheine, Jonas, thiemowmde, Aklapper, Wikidata-bugs, 
aude, GWicke, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T124786: [Task] Widgets should delegate isInitialValue calls as far as possible

2016-01-26 Thread thiemowmde 
thiemowmde added a blocked task: T92759: [Story] allow editing of more 
languages in the in other languages box than the ones defined via babel boxes.

TASK DETAIL
  https://phabricator.wikimedia.org/T124786

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Lydia_Pintscher, adrianheine, Jonas, thiemowmde, Aklapper, Wikidata-bugs, 
aude, GWicke, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs