[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
Addshore added a project: User-Addshore. TASK DETAILhttps://phabricator.wikimedia.org/T134882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Tobi_WMDE_SW, Ricordisamoa, gerritbot, TerraCodes, Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
Addshore added a comment. In T134882#2399329, @thiemowmde wrote: I created https://grafana.wikimedia.org/dashboard/db/wikidata-api-wbsetclaim but got stuck. I tried to use sum and count on the wikibase.repo.api.wbsetclaim.total and wikibase.repo.api.wbsetclaim.index keys I added to SetClaim.php, and get totally different numbers I both don't understand. Which number is the actual number of calls? And what is the other number then? So each of these could be aggregated in different ways. See https://github.com/wikimedia/operations-puppet/blob/01d26c2c16e9cbab7c6de1625b705d4ab7ec7c33/modules/role/manifests/graphite/base.pp#L56 which shows how they are aggregated and https://github.com/wikimedia/operations-puppet/blob/01d26c2c16e9cbab7c6de1625b705d4ab7ec7c33/modules/role/manifests/graphite/base.pp#L49 for the retention lengths. count is the number count of the metrics sent to statsd in the flush period (which is 60 seconds). sum is the sum of the metrics that were sent to statsd It should be noted that the sum value recorded here basically matches the signiture of the graph shown on https://grafana-admin.wikimedia.org/dashboard/db/wikidata-edits in the 'Edit type' section. It looks like wikibase.repo.api.wbsetclaim.index is either not called at all or not tracked for a reason I do not understand. Indeed, it looks like that is not called at all! I also totally believe this, I myself have never used it. Whatever I do, Grafana refuses to show a flat line in the graph for the non-existing index key. How do I enforce this? Other graphs have a flat line, but I can not reproduce this. AFAIK you can make it produce a flat line in the case where a value is NULL (ie has not been submitted to graphite). However the case with index is that a value has never been submitted thus the metric file doesn't exist. Instead of seeing this as nulls or 0s grafana sees this as an error, as the metric doesn't exist. How is daily data generated? That's what I actually want, not the current graphs. If you mean the data under the daily.* prefix that is generally generated using external scripts. http://github.com/wikimedia/analytics-wmde-scripts It has also just been puppetized T125989 The daily.* metrics are retained and thus aggregated in a different way https://github.com/wikimedia/operations-puppet/blob/01d26c2c16e9cbab7c6de1625b705d4ab7ec7c33/modules/role/manifests/graphite/base.pp#L42 You should be able to change the graph to show you daily data by using something like summarize(1d, sum, false)TASK DETAILhttps://phabricator.wikimedia.org/T134882EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Tobi_WMDE_SW, Ricordisamoa, gerritbot, TerraCodes, Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
thiemowmde added a blocked task: T75496: [Epic] Support new types of Entities in Wikibase Repository. TASK DETAIL https://phabricator.wikimedia.org/T134882 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Tobi_WMDE_SW, Ricordisamoa, gerritbot, TerraCodes, Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
Addshore added a project: WMDE-Analytics-Engineering. TASK DETAIL https://phabricator.wikimedia.org/T134882 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Tobi_WMDE_SW, Ricordisamoa, gerritbot, TerraCodes, Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
thiemowmde removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T134882 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, TerraCodes, Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
thiemowmde added a blocking task: T134883: [Task] Find out if the Wikibase UI uses the index feature of the SetClaims API. TASK DETAIL https://phabricator.wikimedia.org/T134882 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T134882: [Task] Track usage of the index feature in SetClaim API
thiemowmde added a blocked task: T134884: [Task] Make ChangeOpStatement fail when the index feature is used on entities without setStatements. TASK DETAIL https://phabricator.wikimedia.org/T134882 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jonas, Addshore, adrianheine, JanZerebecki, aude, Lydia_Pintscher, daniel, Aklapper, hoo, thiemowmde, Zppix, D3r1ck01, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
