[Wikidata-bugs] [Maniphest] [Updated] T138748: [Solution] Value checking and saving: Error messages, no silent fails
matej_suchanek added a parent task: T147837: [Epic] Collection of actionable UX Bugs on Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T138748 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: WMDE-leszek, Aleksey_WMDE, Lydia_Pintscher, Tobi_WMDE_SW, daniel, Charlie_WMDE, Jonas, adrianheine, thiemowmde, Aklapper, Zppix, Jan_Dittrich, alaa_wmde, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, JGirault, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T138748: [Solution] Value checking and saving: Error messages, no silent fails
daniel added a comment. @Jan_Dittrich Errors that do not correspond to a single input field: Uniqueness constraints on the combination of language, label and description: the error applies to the three fields together (one line in the term-box). Currently, you can edit terms for multiple languages at once, so there may even be multiple conflicts for clicking save once. Finding out which error belongs to which line is tricky. Also note that the constraint check is pretty expensive (see T74430). We don't really want to do this before saving. Uniqueness constraints on sitelinks (on the combination of site ID and page title): the error applies to the two fields together (one line in the sitelink bar). Currently, you can edit links for multiple sites at once, so there may even be multiple conflicts for clicking save once. Finding out which error belongs to which line is tricky. Also note that the constraint check is pretty expensive (though not nearly as expensive as the check for terms). We don't really want to do this before saving. When editing a Statement, it's possible to add an URL as the main value, 3 qualifiers, and as part of 2 references. That's 6 URLs that may fail to validate once the user hits save. If we do real-time validation, this isn't a problem though. In that case, the correct control should always be known. TASK DETAILhttps://phabricator.wikimedia.org/T138748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, danielCc: Tobi_WMDE_SW, Addshore, daniel, Charlie_WMDE, Jonas, adrianheine, thiemowmde, Aklapper, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T138748: [Solution] Value checking and saving: Error messages, no silent fails
Jan_Dittrich added a comment. Short summary of the planning in regards to this on 12.7.16: Quick Fixes: T140085 (autosuggest shows "nothing found"), T54843 (expand error message on default) Interface-wise: Concerns about a checkmark indicating that the value is real-world truthy and not just technically correct. We need at least 3 states: Unresolved, OK, error. And maybe a 3.5th one that is like "unresolved because we can't reach the server" Some Errors will not relate to a specific input field. @daniel : Which are those? Architecture: We could generalize the preview API for the send-and-recieve part. TASK DETAILhttps://phabricator.wikimedia.org/T138748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Jan_DittrichCc: Tobi_WMDE_SW, Addshore, daniel, Charlie_WMDE, Jonas, adrianheine, thiemowmde, Aklapper, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T138748: [Solution] Value checking and saving: Error messages, no silent fails
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-19.Tobi_WMDE_SW added a comment. Added it to #wikidata-sprint-2016-07-19 so we don't forget it next storytime.TASK DETAILhttps://phabricator.wikimedia.org/T138748EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Tobi_WMDE_SWCc: Tobi_WMDE_SW, Addshore, daniel, Charlie_WMDE, Jonas, adrianheine, thiemowmde, Aklapper, Zppix, Jan_Dittrich, codynguyen1116, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
