[Wikidata-bugs] [Maniphest] [Updated] T156280: WikiBase assumes English doesn't have a variant

2017-04-13 Thread thiemowmde 
thiemowmde added a project: Wikidata-Sprint.thiemowmde moved this task from blocked on others to in current sprint on the Wikidata board.thiemowmde added a comment.
For reference, here is a copy of the failures:

21:28:37 1) Wikibase\Lib\Tests\LanguageFallbackChainFactoryTest::testNewFromLanguage with data set #1 ('en', 2, array())
21:28:37 Failed asserting that 1 is identical to 0.
21:28:37 
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:28
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:109
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:400
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:111
21:28:37 
21:28:37 2) Wikibase\Lib\Tests\LanguageFallbackChainFactoryTest::testNewFromLanguageCode with data set #1 ('en', 2, array())
21:28:37 Failed asserting that 1 is identical to 0.
21:28:37 
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:28
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php:124
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:400
21:28:37 /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/maintenance/doMaintenance.php:111
21:28:37 
21:28:37 FAILURES!
21:28:37 Tests: 14541, Assertions: 116581, Failures: 2, Skipped: 116, Risky: 39.

I created https://gerrit.wikimedia.org/r/348048 and made https://gerrit.wikimedia.org/r/72053 depend on it. Let's see if the tests succeed now. That's right, I did not run the tests locally. Lazy me. ;-)TASK DETAILhttps://phabricator.wikimedia.org/T156280WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T156280: WikiBase assumes English doesn't have a variant

2017-04-13 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T156280: WikiBase assumes English doesn't have a variant

2017-03-30 Thread cscott 
cscott added a parent task: T45547: MediaWiki needs a fictitious variant for English for easier variant development work.
TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscottCc: Smalyshev, Aklapper, cscott, QZanden, Salgo60, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T156280: WikiBase assumes English doesn't have a variant

2017-01-26 Thread cscott 
cscott added a comment.
The logic for "should a language have languageconverter enabled" is pretty baroque; see the discussion in T153341.  It's more-or-less $language->getConverter() instanceof FakeConverter.  If you use that logic, Wikibase will work for pig latin.  Unfortunately, "having only a single variant" doesn't necessarily mean that language converter is not enabled.  Some wikis might have existing text in a different variant, but then decide to shift to being a 'single variant wiki' --- but they'll leave language converter active to properly render their old content, and just disable all but one variant.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscottCc: Smalyshev, Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs