[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

[Michael]

Michael added a comment.


  In T231887#5529597 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > So, remaining action item – handle assert failures better?
  
  Yeah, I added it to T228066: Error States of Data-Bridge [Tracking] 
. Not sure if that needs an extra 
task beyond that? OTOH, we could make this an explicit decision and add it to 
the product doc?
  
  Pinging @Lydia_Pintscher: If the user logged-out of the wiki in another tab 
after opening the data-bridge app and thus the saving fails, is it enough for 
now to tell them to log-in again and redo their thing?

TASK DETAIL
  https://phabricator.wikimedia.org/T231887

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Matthias_Geisler_WMDE, Addshore, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > I think `assert='user'` vs `assertuser=mw.config.get('wgUserName')` is only 
relevant when considering federation (And if we are considering federation then 
that would open yet another can of worms.). My suggestion would be to go with 
`assert='user'` as this is the least strict assertion that still enforces our 
central requirement (no IP bleed).
  
  Hm, on the other hand the current description of T231725 
 specifically requires edits using 
the same account, not just that the IP doesn’t leak. But that’s also what we 
currently do, I think.
  
  So, remaining action item – handle assert failures better?

TASK DETAIL
  https://phabricator.wikimedia.org/T231887

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Matthias_Geisler_WMDE, Addshore, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

[Pablo-WMDE]

Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6.

TASK DETAIL
  https://phabricator.wikimedia.org/T231887

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Pablo-WMDE
Cc: Matthias_Geisler_WMDE, Addshore, Aklapper, Lydia_Pintscher, darthmon_wmde, 
Michael, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

[Michael]

Michael added a comment.


  While the situation may happen as described in T231209 
 and T202028 
, that the user is only logged into 
the Wikipedia site with the bridge app, but not into Wikidata, that doesn't 
seem to be a problem as the login-check is made against central auth and not 
wikidata itself. Hence the edit is still made on wikidata as the logged-in user 
without actually being logged-in in wikidata on the browser.
  
  However, the suspected problem mentioned in the description might still arise 
if someone logs out of Wikidata/Wikipedia after the bridge app was opened (e.g. 
in another tab). Recovering from that might not be impossible on the 
technological label, but might be messy on the UX side. E.g. what if someone 
logs in with a different account than the one which they initially used?
  
  My suggestion would be for now to just request the user to make sure they are 
logged-in and then to come back, start fresh, and make the edit again.
  
  What already works fine is when starting out as anonymous and then logging in:
  
  1. Go to wikipedia page and open bridge app from an infobox as anonymous user
  2. open a new tab and log into wikidata
  3. save the edit from the initial tab
  4. ⇒ edit is made as the logged-in user

TASK DETAIL
  https://phabricator.wikimedia.org/T231887

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Addshore, Aklapper, Lydia_Pintscher, darthmon_wmde, Michael, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs