[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie, Maintenance_bot
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
eprodromou, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, 
Pchelolo, Wikidata-bugs, aude, Amire80, Arrbee, santhosh, KartikMistry, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, 
Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, 
Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie, ReleaseTaggerBot
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
Oblanco79, Alter-paule, Beast1978, Un1tY, eprodromou, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, 
DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, 
Wikidata-bugs, aude, Amire80, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie, gerritbot
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
Alter-paule, Beast1978, Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Taiwania_Justo, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Amire80, Arrbee, 
santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[Addshore]

Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
Addshore moved this task from needs discussion or investigation to monitoring 
on the Wikidata board.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

WORKBOARD
  https://phabricator.wikimedia.org/project/board/71/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Amire80, 
Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, 
Iflorez, alaa_wmde, Jonas, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[Anomie]

Anomie added a comment.


  In T240083#5732516 , 
@daniel wrote:
  
  > Could that be deferred until the point where the User object would usually 
be initialized from the session?
  
  That seems like it would bring back the problems from T43201: 
UserLoadFromSession considered evil . 
We specifically wanted auto-creation to happen at a predictable place during 
setup rather that it happening unexpectedly at any time during the request.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
Iflorez, darthmon_wmde, WDoranWMF, alaa_wmde, holger.knust, EvanProdromou, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, 
Wikidata-bugs, aude, Amire80, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[Anomie]

Anomie added a comment.


  > `User::saveSettings` is calling `Title::purgeSquid`. It is undocumented why 
changing preferences requires purging the user page, unconditionally, 
synchronously.
  
  It was added in r42179 
 with reference to 
T3306: Suppress the "email this user" link in the toolbox if said user has 
opted not to/can't receive emails . It 
seems the purge is intended to update the state of the "Email user" link when 
the associated preference is changed.
  
  But the speculation about purging for gender changes might now be another use 
case requiring such a purge.
  
  In T240083#5731759 , 
@daniel wrote:
  
  > There are several places where this chain could potentially be cut, but I 
didn't find a trivial once at a first glance.
  
  `ContentHandler::getPageLanguage()` probably shouldn't depend on the request 
in the first place. If the content is really in multiple languages somehow such 
that it can be displayed in the user's UI language, that should probably be 
indicated directly for the caller to deal with (if it cares) instead of 
returning the current user's UI language. As it is, this particular use case 
(`getCdnUrls`) is broken because it won't be returning every possible URL, only 
those corresponding to the current user's UI language. But changing all that 
would probably be a large project.
  
  Possibly the simplest place is here
  
  name=Title.php
public function purgeSquid() {
DeferredUpdates::addUpdate(
new CdnCacheUpdate( $this->getCdnUrls() ),
DeferredUpdates::PRESEND
);
}
  
  It's already deferring the actual update, you'd just have to somehow move the 
call to $this->getCdnUrls() to when the update runs instead of when it's 
constructed.
  
  > Also, why is autoCreateUser() triggered before setup is complete?
  
  Part of setup is determining the User making the request. If that User 
doesn't exist locally yet, it has to be auto-created to have it available to 
finish the setup.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie
Cc: Anomie, daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, 
Iflorez, darthmon_wmde, WDoranWMF, alaa_wmde, holger.knust, EvanProdromou, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, 
Wikidata-bugs, aude, Amire80, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[daniel]

daniel added a project: Core Platform Team Workboards (Clinic Duty Team).
daniel added a comment.


  The stack trace reads like a fun chain of lazy initialization logic causing a 
User object to be loaded prematurely. There are several places where this chain 
could potentially be cut, but I didn't find a trivial once at a first glance. 
I'm wondering though why the User object has to be loaded when a new user has 
just been created. Also, why is autoCreateUser() triggered before setup is 
complete? Lots of potential problems & solutions.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, Iflorez, 
darthmon_wmde, WDoranWMF, alaa_wmde, holger.knust, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, 
Wikidata-bugs, aude, Amire80, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

[Ladsgroup]

Ladsgroup added a project: Core Platform Team.
Ladsgroup added a subscriber: daniel.
Ladsgroup moved this task from To Do to Stalled/Waiting on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  I highly doubt this is something Wikibase team would be able to fix. The 
usage of the `LocalUserCreated` hook in Wikibase code seems to be 
straightforward and simple, something in core or Translate extension needs to 
change. It might be caused by splitting Language object. I add Daniel and CPT 
to the ticket.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: daniel, Ladsgroup, Addshore, Nikerabbit, Krinkle, Aklapper, Iflorez, 
darthmon_wmde, WDoranWMF, alaa_wmde, holger.knust, EvanProdromou, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, 
Wikidata-bugs, aude, Amire80, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

[Addshore]

Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Nikerabbit, Krinkle, Aklapper, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Amire80, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS)

[Nikerabbit]

Nikerabbit added a comment.


  I do remember adding the `StubObject::unstub( $wgLang );` for T214358: Fatal 
error: Uncaught TypeError: Argument 2 passed to 
TranslateHooks::onPageContentLanguage() must be an instance of Language, string 
given . A few extensions are using 
it when setting the value in the hook while avoiding using request globals 
directly.
  
  What for does purging need to know the page language? For language variants.
  
  Since this is a newly created user, it doesn't seem necessary to purge the 
user pages, or maybe the user pages do not need to be purged for every option 
change. Just for a gender change?

TASK DETAIL
  https://phabricator.wikimedia.org/T240083

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikerabbit
Cc: Addshore, Nikerabbit, Krinkle, Aklapper, darthmon_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Wikidata-bugs, aude, Amire80, 
Lydia_Pintscher, Arrbee, santhosh, KartikMistry, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs