[Wikidata-bugs] [Maniphest] [Updated] T88437: figure out current state of time storage and display
Tobi_WMDE_SW added a comment. There are quite some (under-statement!) patches up for review that fix different issues with the current time implementation. They are (mostly) not tracked by separate tickets, that's why I put the list here as a todo-list for reviewers. kudos are going to @thiemowmde! in https://github.com/DataValues/Time: https://github.com/DataValues/Time/pull/39 https://github.com/DataValues/Time/pull/38 https://github.com/DataValues/Time/pull/37 https://github.com/DataValues/Time/pull/36 https://github.com/DataValues/Time/pull/35 https://github.com/DataValues/Time/pull/33 https://github.com/DataValues/Time/pull/32 https://github.com/DataValues/Time/pull/27 in https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Wikibase,n,z: https://gerrit.wikimedia.org/r/#/c/192295/ https://gerrit.wikimedia.org/r/#/c/192544/ https://gerrit.wikimedia.org/r/#/c/192317/ https://gerrit.wikimedia.org/r/#/c/192313/ https://gerrit.wikimedia.org/r/#/c/192306/ https://gerrit.wikimedia.org/r/#/c/192300/ https://gerrit.wikimedia.org/r/#/c/192308/ https://gerrit.wikimedia.org/r/#/c/192297/ https://gerrit.wikimedia.org/r/#/c/192314/ https://gerrit.wikimedia.org/r/#/c/192307/ https://gerrit.wikimedia.org/r/#/c/186791/ in https://github.com/wmde/DataValuesJavascript: https://github.com/wmde/DataValuesJavascript/pull/62 https://github.com/wmde/DataValuesJavascript/pull/60 https://github.com/wmde/DataValuesJavascript/pull/61 (https://phabricator.wikimedia.org/T89243) TASK DETAIL https://phabricator.wikimedia.org/T88437 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, Tobi_WMDE_SW Cc: Jc3s5h, Accurimbono, Candalua, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, JulesWinnfield-hu, Addshore, Aklapper, Liuxinyu970226, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88437: figure out current state of time storage and display
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-02-25. TASK DETAIL https://phabricator.wikimedia.org/T88437 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, Tobi_WMDE_SW Cc: Jc3s5h, Accurimbono, Candalua, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, JulesWinnfield-hu, Addshore, Aklapper, Liuxinyu970226, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88437: figure out current state of time storage and display
thiemowmde added a project: Patch-For-Review. thiemowmde added a subscriber: Jc3s5h. thiemowmde added a comment. As far as I can tell, we do not do any conversion (at least not since the JavaScript backend was dropped in favor of API calls). What the user enters is stored. When you change the calendar model, the date is not converted. This is intended, as far as I'm aware of. I see two problems, at the moment: 1. The documentation in the TimeValue class is wrong. This is confusing but doesn't cause direct harm because this class doesn't do anything with this information. In fact, the interpretation of the timestamp and the calendar model should probably not be documented in this class at all. 2. The diff view currently assumes the timestamp is always Gregorian (fixed in https://github.com/DataValues/Time/pull/32). I fail to understand what the users (e.g. @Jc3s5h) in https://phabricator.wikimedia.org/T87312 are talking about. It seems they are expecting conversion but don't give enough detail when and how that should happen. TASK DETAIL https://phabricator.wikimedia.org/T88437 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jc3s5h, Accurimbono, Candalua, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, JulesWinnfield-hu, Addshore, Aklapper, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T88437: figure out current state of time storage and display
Lydia_Pintscher added a project: § Wikidata-Sprint-2015-02-03. TASK DETAIL https://phabricator.wikimedia.org/T88437 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, JulesWinnfield-hu, Addshore, Aklapper, Liuxinyu970226, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs