[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Jdlrobson]

Jdlrobson edited projects, added patch-welcome; removed Readers-Web-Backlog 
(Tracking).
Jdlrobson added a comment.


  This should be possible but the code is going to need some serious 
refactoring to do this.
  
  For anyone interested in working on this ticket, this should get you started. 
Submit a patch and add it to my attention and I will happily review:
  
diff --git a/extension.json b/extension.json
index d499ef4..398dc59 100644
--- a/extension.json
+++ b/extension.json
@@ -93,6 +93,9 @@
]
},
"Hooks": {
+   "DifferenceEngineRenderRevisionAddParserOutput": [
+   
"WikidataPageBanner::onDifferenceEngineRenderRevisionAddParserOutput"
+   ],
"BeforePageDisplay": [
"WikidataPageBanner::onBeforePageDisplay"
],
diff --git a/includes/WikidataPageBanner.php 
b/includes/WikidataPageBanner.php
index ec9250a..d3b5c25 100644
--- a/includes/WikidataPageBanner.php
+++ b/includes/WikidataPageBanner.php
@@ -204,11 +204,20 @@ class WikidataPageBanner {
// Disable table of contents in article.
$bannerOptions = self::getBannerOptions( $pOut );
if ( $bannerOptions !== null ) {
-   $enableTocInBanner = $bannerOptions['enable-toc'];
+   $enableTocInBanner = $bannerOptions['enable-toc'] 
?? false;
$options['injectTOC'] = !$enableTocInBanner;
}
}
 
+   public static function 
onDifferenceEngineRenderRevisionAddParserOutput( $diff, $out, $pOut, $wikiPage 
) {
+   $bannerOptions = self::getBannerOptions( $pOut );
+   if ( $bannerOptions !== null ) {
+   $out->addHTML(
+   'insert banner here'
+   );
+   }
+   }
+
/**
 * WikidataPageBanner::onOutputPageParserOutput add banner 
parameters from ParserOutput to
 * Output page

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, G1964j, Zekwn, the0001, Zabe, Selby, AndreCstr, XeroS_SkalibuR, 
Dinadineke, DannyS712, Mirahamira, tabish.shaikh91, Markhalsey, 
Jayprakash12345, JakeTheDeveloper, merbst, Wikidata-bugs, Lydia_Pintscher, 
TheDJ, Nishu02, Demian, Winter
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Andyrom75]

Andyrom75 added a comment.


  @Aklapper thanks for your suggestion but I'm only "skilled" on client side 
JQuery/JS not server side, hence I'm not able to elaborate the @Tgr's input
  
  @Jdlrobson since this is a Wikivoyage's peculiarity, typically Wikipedia's 
people are not interested and Wikivoyage unfortunately do not have many tech 
users (maybe just 2/3). I'm one of them, but since I never put my hands on 
server side WMF software, it would take a lot of time to be able to do it, but 
if you have such time, feel free to contact me via email and we can try to 
organize some teleconference sessions.

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andyrom75
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, the0001, Zabe, Selby, AndreCstr, XeroS_SkalibuR, Demian, DannyS712, 
Mirahamira, Markhalsey, Jayprakash12345, Winter, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Jdlrobson]

Jdlrobson added a comment.


  @Andyrom75 right now I'm the only maintainer, and I can't review my own work 
so I can only review what volunteers post (currently there is no Google Summer 
of Code candidate giving the extension some much-needed love and no WMF product 
team working on the extension). So the best way you can help is find people 
that are willing to improve the extension on behalf of Wikivoyage.
  
  Perhaps you could ask on Village pump if any editors are comfortable writing 
code and Gerrit and fixing many of the WikidataPageBanner bugs during December 
(I'm out for the latter part of November),. I'd have lots of bandwidth for code 
review and I'd be more than happy to review any contributions, and mentor 
contributors, particularly from new contributors.

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, the0001, Zabe, Selby, AndreCstr, XeroS_SkalibuR, Demian, DannyS712, 
Mirahamira, Markhalsey, Jayprakash12345, Winter, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Aklapper]

Aklapper added a comment.


  @Andyrom75: Please feel very welcome to rework the patch based on input in 
T147946#6162788  - thanks.

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aklapper
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, the0001, Zabe, Selby, AndreCstr, XeroS_SkalibuR, Demian, DannyS712, 
Mirahamira, Markhalsey, Jayprakash12345, Winter, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Andyrom75]

Andyrom75 added a comment.


  @Jdlrobson since recently someone (successfully) worked on the 
WikidataPageBanner (T295003 ), could 
be the right time to ask to try to solve also this issue?

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andyrom75
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, the0001, Zabe, Selby, AndreCstr, XeroS_SkalibuR, Demian, DannyS712, 
Mirahamira, Markhalsey, Jayprakash12345, Winter, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T147946: Display banners on diff pages

[Jdlrobson]

Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed 
Readers-Web-Backlog (Design).

TASK DETAIL
  https://phabricator.wikimedia.org/T147946

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper, 
Andyrom75, the0001, Selby, AndreCstr, XeroS_SkalibuR, Demian, Adidsone1, 
DannyS712, Mirahamira, Phukettaxigroup, Markhalsey, Jayprakash12345, Winter, 
Wikidata-bugs, Lydia_Pintscher, Jdrewniak
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org