[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Mholloway]

Mholloway closed this task as "Resolved".
Mholloway claimed this task.
Mholloway added a comment.


  The request in this task was for the Wikipedia Android app to show the 
article description in the correct language variant if a description exists in 
Wikidata for that variant.  That's long-since resolved.  Please file requests 
for refining the current behavior (or for fixing ApiQueryDescription) as new 
tasks.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Ryansama, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Addshore]

Addshore added a comment.


  In T173842#6329971 , 
@Mholloway wrote:
  
  > If what you're asking is to fix ApiQueryDescription 

 (?action=query=description) to handle language variants generally, then 
that's a separate task, and one probably best performed by someone with 
in-depth knowledge of Wikibase concepts and architecture (hint: probably 
someone from WMDE and not WMF Product Infrastructure).
  
  This API module is pretty far away from Wikibase (despite the code being in 
Wikibase currently).
  The API module exists as part of a WMF Product feature (see T184000 
), so probably doesn't need to be 
coordinated with us (WMDE) much.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Charlotte]

Charlotte lowered the priority of this task from "High" to "Medium".

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlotte
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Mholloway]

Mholloway added a comment.


  @cooltey Just to be clear, am I correct that the remaining issue here is that 
the service should NOT fall back to using the description from another variant 
if the preferred variant is unavailable?  Using your example title, I see that 
the description on 
https://zh.wikipedia.org/api/rest_v1/page/mobile-html/%E4%B8%89%E7%81%A3%E9%84%89_(%E5%8F%B0%E7%81%A3)
 uses the correct variant when `Accept-Language: zh-hant` is sent.  But when 
`Accept-Language: zh-hans` is sent or no language variant is specified, the 
generic "Chinese" description is shown, which (IIUC) is incorrect.
  
  If what you're asking is to fix ApiQueryDescription 

 (?action=query=description) to handle language variants generally, then 
that's a separate task, and one probably best performed by someone with 
in-depth knowledge of Wikibase concepts and architecture (hint: probably 
someone from WMDE and not WMF Product Infrastructure).  But I wouldn't agree 
with the prioritization in that case, because descriptions in the correct 
variant are already available by other means.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[Charlotte]

Charlotte triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlotte
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[cooltey]

cooltey added a comment.


  @LGoto I would say to set it as Medium or High since it should not happen 
anyways.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[LGoto]

LGoto added subscribers: Charlotte, LGoto.
LGoto moved this task from Needs triage to Needs analysis on the 
Product-Infrastructure-Team-Backlog board.
LGoto added a comment.


  @cooltey @Charlotte Can you set a priority for this task?

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

WORKBOARD
  https://phabricator.wikimedia.org/project/board/2726/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LGoto
Cc: LGoto, Charlotte, JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, 
fantasticfears, cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, 
bearND, Tbayer, Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, 
darthmon_wmde, VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Lahi, 
Gq86, Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[cooltey]

cooltey added a project: Product-Infrastructure-Team-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey
Cc: JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, 
cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, 
Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, darthmon_wmde, 
VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Charlotte, Lahi, Gq86, 
Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T173842: [BUG] Wikidata description for the specific Chinese language variant should be shown

[cooltey]

cooltey added a subscriber: JoeWalsh.
cooltey added a comment.


  #product-infrastructure-team-backlog 
  
and #core_platform_team 
 and cc @JoeWalsh
  
  The issue is still there.
  
  By requesting the following API, it should give the corresponding Wikidata 
description with the language code in `Accept-Language`.
  
  
https://zh.wikipedia.org/w/api.php?action=query=json=description=%E4%B8%89%E7%81%A3%E9%84%89%20(%E5%8F%B0%E7%81%A3)
  
  According to the wikidata page: https://www.wikidata.org/wiki/Q713793
  
  When sending `Accept-Language: zh-hant`, it should show `位於苗栗縣` in 
`Traditional Chinese` column.
  When sending `Accept-Language: zh-hans`, it should show an empty description.
  
  And we should no longer use the wikidata description in `Chinese` column.

TASK DETAIL
  https://phabricator.wikimedia.org/T173842

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cooltey
Cc: JoeWalsh, shinjiman, Yuriy_kosygin, Addshore, CXuesong, fantasticfears, 
cscott, gerritbot, Liuxinyu970226, cooltey, Dbrant, Mholloway, bearND, Tbayer, 
Aklapper, RHo, Confetti68, Akuckartz, Joye_Zhang, darthmon_wmde, 
VulpesVulpes825, Sunny00217, 94rain, Nandana, Hamishcn, Charlotte, Lahi, Gq86, 
Sharvaniharan, BJ6123C7BTD, schoenbaechler, Maggouri, Jcasariego, 
GoranSMilovanovic, lisong, Allthingsgo, QZanden, LawExplorer, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, LNDDYL, Fuzheado, Cwek, Wikidata-bugs, 
aude, zhuyifei1999, Shizhao, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs