[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt closed this task as "Resolved".
Physikerwelt added a comment.


  Eventually it works on enwiki. Thank you @Ladsgroup for your great support, 
which was significant to complete this task after 1.5 years of perplexity.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, ReleaseTaggerBot
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[gerritbot]

gerritbot added a comment.


  Change 638094 **merged** by jenkins-bot:
  [mediawiki/extensions/Math@master] Implement wikidata entity selector
  
  https://gerrit.wikimedia.org/r/638094

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, gerritbot
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[gerritbot]

gerritbot added a comment.


  Change 649718 **abandoned** by Physikerwelt:
  [mediawiki/extensions/Math@master] WIP: Implement wikidata entity selector
  
  Reason:
  
  https://gerrit.wikimedia.org/r/649718

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, gerritbot
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[gerritbot]

gerritbot added a comment.


  Change 649718 had a related patch set uploaded (by Physikerwelt; owner: 
Physikerwelt):
  [mediawiki/extensions/Math@master] WIP: Implement wikidata entity selector
  
  https://gerrit.wikimedia.org/r/649718

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, gerritbot
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Ladsgroup]

Ladsgroup added a comment.


  Regarding that why number of RL modules should be kept at minimum 
T264334#6523308  might be 
useful. TLDR, it's a cost to get a way bigger gain.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, Ladsgroup
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt lowered the priority of this task from "High" to "Medium".

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt added a comment.


  I feel sorry. I did not intend to start a discussion on the principle of +2 
in general. To put the problem in a simple picture.
  
  Currently, I see the following situation:
  F33944354: production-bug.png 
  
  On the left side, you see a screenshot of Wikipedia and on the right side, 
you see a screenshot of Wikidata. On the Wikidata side, you can enter text to 
select a QID, and on the Wikipedia side, you don't see a dropdown but an error 
in the javascript console (if you have that opened). This is because Wikipedia 
has not the Wikibase repo extension enabled, which contains the dropdown code. 
I implemented the code to fix that following the recommendations and discussion 
in this ticket. Here the advice of @thiemowmde (how is a Wikibase expert) was 
essential for the implemented solution. Also, the +1 code review from @Esanders 
suggests that there is no obvious flaw from the OOUI perspective. Even though 
my feeling is that the solution I implemented is not optimal, I am not aware of 
a better solution nor of anyone who could help to implement a better solution 
with reasonable effort. Therefore, I am hoping for a final go. One alternative 
I see is to consult CPT as they help with mathoid and restbase related code in 
extension math. On the other hand this problem is just UI and not related to 
mathoid.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Krenair, Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T229939#6686312 , 
@thiemowmde wrote:
  
  > James, such a passive-aggressive tone is inakzeptable. If you are unable to 
explain yourself then please don't comment, especially if you are not even 
asked for your opinion.
  
  Sorry, I'll be clearer, rather than assume you remembered the policy:
  
  Please do not ever give such shockingly, grossly inappropriate and 
unprofessional advice, which is directly in contravention of the policy 
 to which you agreed 
when given C+2 rights. If you do it again, I will feel obliged to proposed that 
your C+2 rights are removed, per that policy.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, Jdforrester-WMF
Cc: Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[thiemowmde]

thiemowmde added a comment.


  James, such a passive-aggressive tone is inakzeptable. If you are unable to 
explain yourself then please don't comment, especially if you are not even 
asked for your opinion.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, thiemowmde
Cc: Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T229939#6684997 , 
@thiemowmde wrote:
  
  > this might be one of the rare situations where it's fine to self-merge your 
own patch. 路‍♂️
  
  No. It isn't.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, Jdforrester-WMF
Cc: Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, 
Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, 
Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, 
QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, 
xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, 
Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt added a comment.


  @thiemowmde thank you for your prompt reply. I am not confident enough to 
self-merge this. The interplay of PHP and JS code is too frightening to me. If 
it was just a PHP or JS code I might have a different opinion, but in this 
case, I think self-merging is not an option.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: TheDJ, awight, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, 
Aklapper, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, 
Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, 
Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[thiemowmde]

thiemowmde added a subscriber: TheDJ.
thiemowmde added a comment.


  I know this is frustrating. WMDE staff is happy to help, but is currently not 
in a position to invest substantial resources into the Math extension. 
According to https://www.mediawiki.org/wiki/Developers/Maintainers the owner of 
the extension is the WMF editing team (lead by @Esanders), as well as @TheDJ 
and you. My personal opinion: When there aren't any objections from Ed or their 
team, this might be one of the rare situations where it's fine to self-merge 
your own patch. 路‍♂️

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, thiemowmde
Cc: TheDJ, awight, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, 
Aklapper, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, 
Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, 
Lewizho99, Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, 
Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt added a subscriber: awight.
Physikerwelt added a comment.


  @thiemowmde @Esanders @Lucas_Werkmeister_WMDE  I am unsure how to proceed 
here. Is there anything I can do to get the patch merged? I think it is ok in 
its current form. Also for the ResourceLoader question, I got additional 
feedback by @awight  
https://lists.wikimedia.org/pipermail/wikitech-l/2020-December/094094.html . As 
the module will also be used to select the qid in the visual editor I think 
merging those two modules would not be desirable (if it was technically 
possible).
  Any feedback would be highly appreciated. I am not afraid of additional 
effort. I just don't know what else to do to get this little inconvenience 
fixed.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: awight, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, 
Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt added a comment.


  @thiemowmde do you have time for a code review?

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, 
Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[gerritbot]

gerritbot added a comment.


  Change 638094 had a related patch set uploaded (by Physikerwelt; owner: 
Physikerwelt):
  [mediawiki/extensions/Math@master] Implement wikidata entity selector
  
  https://gerrit.wikimedia.org/r/638094

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, gerritbot
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Akuckartz, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, 
LawExplorer, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, 
ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, gerritbot
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, 
Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, 
Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[hoo]

hoo added a comment.


  @Physikerwelt Nowadays we pull in some of the (JS) libraries using git 
submodules. Are your submodules in Wikibase all initialized and up to date?

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt, hoo
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, 
Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, 
Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, 
Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt added a comment.


  @thiemowmde ... I am still working on this... it is difficult for me to set 
up wikidata on my dev instance without js warnings... I see exceptions like
  
[105223064898a872602238d1] 
/load.php?lang=en=jquery%2Coojs%2Coojs-ui-core%2Csite%7Cjquery.client%2Cspinner%2Cthrottle-debounce%2Cui%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.suggester%7Cjquery.wikibase.entityselector%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2Cdebug%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui.styles.indicators%7Cskins.vector.legacy.js%7Cuser.defaults%7Cutil.inherit%7Cwikibase.ui.entitysearch=vector=1uw4m
   RuntimeException from line 485 of 
/var/www/html/includes/resourceloader/ResourceLoaderFileModule.php: 
ResourceLoaderFileModule::getFileContents: script file not found, or is not a 
file: 
"/var/www/html/extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.suggester.js"
Backtrace:
#0 /var/www/html/includes/resourceloader/ResourceLoaderFileModule.php(907): 
ResourceLoaderFileModule->getFileContents(string, string)
#1 /var/www/html/includes/resourceloader/ResourceLoaderFileModule.php(362): 
ResourceLoaderFileModule->readScriptFiles(array)
#2 /var/www/html/includes/resourceloader/ResourceLoaderModule.php(736): 
ResourceLoaderFileModule->getScript(ResourceLoaderContext)
#3 /var/www/html/includes/resourceloader/ResourceLoaderModule.php(704): 
ResourceLoaderModule->buildContent(ResourceLoaderContext)
#4 /var/www/html/includes/resourceloader/ResourceLoader.php(1191): 
ResourceLoaderModule->getModuleContent(ResourceLoaderContext)
#5 /var/www/html/includes/resourceloader/ResourceLoader.php(899): 
ResourceLoader->makeModuleResponse(ResourceLoaderContext, array, array)
#6 /var/www/html/load.php(51): 
ResourceLoader->respond(ResourceLoaderContext)
#7 /var/www/html/load.php(38): wfLoadMain()
#8 {main}
  
  and I am not 100% that this is unrelated to the problem we are working on in 
this ticket.

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, 
Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, 
Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, 
Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

[Physikerwelt]

Physikerwelt renamed this task from "Use wikidata entity selector in OOUI input 
field" to "Implement wikidata entity selector in OOUI input field".

TASK DETAIL
  https://phabricator.wikimedia.org/T229939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Physikerwelt
Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, MaxSem, 
thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, 
Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, 
Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, 
Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, 
Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs