[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Manuel]

Manuel closed this task as "Resolved".
Manuel claimed this task.
Manuel added a comment.


  This is fixed! Thank you for reporting it @matej_suchanek!

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Addshore]

Addshore added a comment.


  This should now be fixed in production.
  Ping @Manuel for verification

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) 
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be fixed with the next train.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 704793 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Update data-values/time to 1.0.4
  
  https://gerrit.wikimedia.org/r/704793

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 704792 **merged** by jenkins-bot:
  
  [mediawiki/vendor@master] Bump data-values/time to 1.0.4
  
  https://gerrit.wikimedia.org/r/704792

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 704793 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Update data-values/time to 1.0.4
  
  https://gerrit.wikimedia.org/r/704793

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 704792 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/vendor@master] Bump data-values/time to 1.0.4
  
  https://gerrit.wikimedia.org/r/704792

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Pull request preparing 1.0.4 release: https://github.com/wmde/Time/pull/158

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Pull request merged; we probably want to put out a new release of the library 
now, and use it in Wikibase / mediawiki-vendor?

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Manuel]

Manuel added a comment.


  Hi @Lucas_Werkmeister_WMDE, great that you spotted this! I see no reason to 
change the current behavior here: Let's continue to parse negative dates as is 
(e.g. “-1 234 BC” as -1234 BC).

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added subscribers: Manuel, Lydia_Pintscher.
Lucas_Werkmeister_WMDE added a comment.


  @Manuel or @Lydia_Pintscher, this is a question for one of you, I think.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Manuel, Mbch331, Addshore, Ladsgroup, 
Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  It turns out the pull request introduces some changes that may not be wanted. 
Currently (since Partial support for thousands separators in DateTimeParsers 
), we 
allow thousands separators in BC dates, under the assumption that “negative 
dates usually don’t have a month”. So you currently get the following parses 
(API request 
):
  
  - 1 BC: -0001-00-00T00:00:00Z, precision 9
  - 10 BC: -0010-00-00T00:00:00Z, precision 9
  - 100 BC: -0100-00-00T00:00:00Z, precision 9
  - 1 000 BC: -1000-00-00T00:00:00Z, precision 9
  - 10 000 BC: -1-00-00T00:00:00Z, precision 5
  - 100 000 BC: -10-00-00T00:00:00Z, precision 4
  - 1 000 000 BC: -100-00-00T00:00:00Z, precision 3
  - 10 000 000 BC: -1000-00-00T00:00:00Z, precision 2
  
  (The precision jumps because we “default to year precision for range 4000 BC 
to 4000” in `IsoTimestampParser::getPrecisionFromYear()`.)
  
  With the change to the `YearMonthTimeParser`, you instead get:
  
  - 1 BC: -0001-00-00T00:00:00Z, precision 9
  - 10 BC: -0010-00-00T00:00:00Z, precision 9
  - 100 BC: -0100-00-00T00:00:00Z, precision 9
  - 1 000 BC: --**01-00**T00:00:00Z, precision **10**
  - 10 000 BC: --**10-00**T00:00:00Z, precision **10**
  - 100 000 BC: -10-00-00T00:00:00Z, precision 4
  - 1 000 000 BC: -100-00-00T00:00:00Z, precision 3
  - 10 000 000 BC: -1000-00-00T00:00:00Z, precision 2
  
  Put differently: do we want to parse “1 234 BC” as 1234 BC, or as January 234 
BC?

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Ladsgroup]

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer 
Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  This is waiting on review (of https://github.com/wmde/Time/pull/148/files) if 
I understand it correctly.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Addshore]

Addshore moved this task from Prioritized Product (prioritised from top to 
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Addshore]

Addshore set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Screenshot of the issue that the pull request would hopefully fix:
  
  F34531390: Screenshot from 2021-06-29 10-36-36.png 

  
  String for easy copy+pasting: září 2019 BCE

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Biggs657, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek added a comment.


  I requested one more improvement to improve compat. with BCE dates. But it 
solves a todo, it isn't really high priority: 
https://github.com/wmde/Time/pull/148

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  This seems to be fixed as far as I can tell? In which case I assume it could 
be pulled out of the “prioritized” column :)

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 620954 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Test all unicode in month names (using 
new data-values/time)
  
  https://gerrit.wikimedia.org/r/620954

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 621524 **merged** by jenkins-bot:
  [mediawiki/vendor@master] Bump data-values/time to 1.0.2
  
  https://gerrit.wikimedia.org/r/621524

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek added a comment.


  > The patch doesn't fix this for dates BCE. When approved, I'll submit one 
more PR for this.
  
  https://github.com/wmde/Time/pull/148

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lydia_Pintscher]

Lydia_Pintscher closed subtask T260678: Test T233105 with Lydia as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[gerritbot]

gerritbot added a comment.


  Change 620954 had a related patch set uploaded (by Addshore; owner: Addshore):
  [mediawiki/extensions/Wikibase@master] WIP DNM:All unicode in month names 
(using new data-values/time)
  
  https://gerrit.wikimedia.org/r/620954

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek added a comment.


  The patch doesn't fix this for dates BCE. When approved, I'll submit one more 
PR for this.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Lydia_Pintscher]

Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Mbch331]

Mbch331 added a comment.


  I tried Regex101 too and after that I tried the same with a small php script 
which I ran on command line and that didn't work. That's when I started 
searching for what was wrong.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek added a project: Patch-For-Review.
matej_suchanek added a comment.


  Bingo! I could really have tried Google. Weird that https://regex101.com/ 
(which I used) still matches without `/u`.
  
  #patch-for-review : 
https://github.com/wmde/Time/pull/146

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[Mbch331]

Mbch331 added a comment.


  Found https://stackoverflow.com/questions/26611495/regex-pl-problems
  Solution:
  
if ( !preg_match( '/^(-?[\d\p{L}]+)\s*?[\/\-\s.,]\s*(-?[\d\p{L}]+)$/u', 
trim( $value ), $matches ) ) {
  throw new ParseException( 'Failed to parse year and month', $value, 
self::FORMAT_NAME );
}
  
  (Add a u as modifier for the regex)

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mbch331
Cc: Mbch331, Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, 
matej_suchanek, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

[matej_suchanek]

matej_suchanek added subscribers: Lucas_Werkmeister_WMDE, Ladsgroup, Addshore.
matej_suchanek added a comment.


  name=data-values\time\src\ValueParsers\YearMonthTimeParser.php
$logger = \MediaWiki\Logger\LoggerFactory::getInstance( 
'MyCoolLoggingChannel' );
$logger->debug( 'stringParse: {value}', [ 'value' => $value ] );
// Matches year and month separated by a separator.
// \p{L} matches letters outside the ASCII range.
if ( !preg_match( '/^(-?[\d\p{L}]+)\s*?[\/\-\s.,]\s*(-?[\d\p{L}]+)$/', 
trim( $value ), $matches ) ) {
  throw new ParseException( 'Failed to parse year and month', $value, 
self::FORMAT_NAME );
}
$logger->debug( 'stringParse: ok' );
  
  F32139630: obrazek.png 
  
  Works for some months but not for all. The `\p{L} matches letters outside the 
ASCII range.` trick apparently doesn't work.
  @Lucas_Werkmeister_WMDE @Addshore @Ladsgroup Could you help?

TASK DETAIL
  https://phabricator.wikimedia.org/T233105

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Addshore, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, matej_suchanek, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs