[Wikidata-bugs] [Maniphest] T243590: Fix WikibaseDataModel CI for php 7.4
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE added a comment. I think this is done now. TASK DETAIL https://phabricator.wikimedia.org/T243590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, hashar, Jakob_WMDE, Silvan_WMDE, kostajh, Pablo-WMDE, WMDE-leszek, Daimona, Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243590: Fix WikibaseDataModel CI for php 7.4
Lucas_Werkmeister_WMDE closed subtask T316923: Restore skipped test in ReferenceListTest.php as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T243590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Michael, hashar, Jakob_WMDE, Silvan_WMDE, kostajh, Pablo-WMDE, WMDE-leszek, Daimona, Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Nikerabbit, MaxSem, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243590: Fix WikibaseDataModel CI for php 7.4
hashar added subscribers: Silvan_WMDE, Jakob_WMDE, hashar.
hashar added a comment.
The `Wikibase\DataModel\Tests\ReferenceListTest::testSerializationStability`
is:
/**
* This test will change when the serialization format changes.
* If it is being changed intentionally, the test should be updated.
* It is just here to catch unintentional changes.
*/
public function testSerializationStability() {
$list = new ReferenceList();
$list->addNewReference( new PropertyNoValueSnak( 1 ) );
/*
* https://wiki.php.net/rfc/custom_object_serialization
*/
if ( version_compare( phpversion(), '7.4', '>=' ) ) {
$testString =
"a:1:{i:0;O:28:\"Wikibase\\DataModel\\Reference\":1:{s:35:\"\x00Wikibase\\DataModel\\"
.
"Reference\x00snaks\";O:32:\"Wikibase\\DataModel\\Snak\\SnakList\":2:{s:4:\""
.
'data";a:1:{i:0;C:43:"Wikibase\\DataModel\\Snak\\PropertyNoValueSnak":2:{P1}}s:5'
. ':"index";i:0;}}}';
} else {
$testString =
"a:1:{i:0;O:28:\"Wikibase\\DataModel\\Reference\":1:{s:35:\"\x00Wikibase\\DataModel\\"
.
"Reference\x00snaks\";C:32:\"Wikibase\\DataModel\\Snak\\SnakList\":100:{a:2:{s:4:\""
.
'data";a:1:{i:0;C:43:"Wikibase\\DataModel\\Snak\\PropertyNoValueSnak":2:{P1}}s:5'
. ':"index";i:0;';
}
$this->assertSame(
$testString,
$list->serialize()
);
}
It does take in account serialization has changed with php 7.4 and the code
is correct. The test fails on our CI because we have patched php7.4 to use the
old serialization format, the switch got made as part of upgrading Quibble to
1.4.6 https://gerrit.wikimedia.org/r/c/integration/config/+/828611
The reason we had to patch php 7.4 is the Wikimedia cluster currently runs a
mix of php 7.2 and 7.4. Thus when a process runs under php 7.4, the serialized
object is stored in the cache with the new format. When a later process running
with php 7.2 attempts to unserialize the new format, it fails leading to
T316601 .
The approach we took was to patch php 7.4 to use the old format as described
at T316601#8201209 . This
way we can finish the migration on the Wikimedia cluster. For this failing
test, it means that even if it varies its expectations based on `phpversion()
>= 7.4`, when it runs on our patched php 7.4 the serialization is done with the
old format. The test break.
@Jakob_WMDE and @Silvan_WMDE raised it on IRC in `#wikimedia-releng`. We
concluded the easiest course of action right now is to mark the test skipped
and restore it once Wikimedia has fully migrated to php 7.4 and that we move
the CI images to the original php 7.4 version.
TASK DETAIL
https://phabricator.wikimedia.org/T243590
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: toan, hashar
Cc: hashar, Jakob_WMDE, Silvan_WMDE, kostajh, Pablo-WMDE, WMDE-leszek, Daimona,
Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, Astuthiodit_1,
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Iflorez,
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher,
Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243590: Fix WikibaseDataModel CI for php 7.4
kostajh reopened this task as "Open".
kostajh added a comment.
Restricted Application added a project: wdwb-tech.
This seems to be an issue again now that CI is running PHP 7.4. See
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/56135/console
09:46:58 There was 1 failure:
09:46:58
09:46:58 1)
Wikibase\DataModel\Tests\ReferenceListTest::testSerializationStability
09:46:58 Failed asserting that two strings are identical.
09:46:58 --- Expected
09:46:58 +++ Actual
09:46:58 @@ @@
09:46:58
-'a:1:{i:0;O:28:"Wikibase\DataModel\Reference":1:{s:35:"Wikibase\DataModel\Referencesnaks";O:32:"Wikibase\DataModel\Snak\SnakList":2:{s:4:"data";a:1:{i:0;C:43:"Wikibase\DataModel\Snak\PropertyNoValueSnak":2:{P1}}s:5:"index";i:0;}}}'
09:46:58
+'a:1:{i:0;O:28:"Wikibase\DataModel\Reference":1:{s:35:"Wikibase\DataModel\Referencesnaks";C:32:"Wikibase\DataModel\Snak\SnakList":100:{a:2:{s:4:"data";a:1:{i:0;C:43:"Wikibase\DataModel\Snak\PropertyNoValueSnak":2:{P1}}s:5:"index";i:0;'
09:46:58
09:46:58
/workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/tests/unit/ReferenceListTest.php:545
09:46:58
09:46:58 FAILURES!
09:46:58 Tests: 24800, Assertions: 86154, Failures: 1, Skipped: 97.
TASK DETAIL
https://phabricator.wikimedia.org/T243590
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: toan, kostajh
Cc: kostajh, Pablo-WMDE, WMDE-leszek, Daimona, Jdforrester-WMF, srishakatux,
Reedy, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja, ItamarWMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Lydia_Pintscher, Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
