[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-09 Thread Addshore 
Addshore moved this task from Peer review to Done on the Wikibase REST API 
Schema board.
Addshore closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5003/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, Addshore
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-09 Thread Pablo-WMDE 
Pablo-WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-09 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  Will try and document this "gotcha" and that it may come up again in the 
future.

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-09 Thread Addshore 
Addshore added a comment.


  We decided to write a Gotchas document in the git repo that coveres the 
reasoning and possible confusions that the status quo here might cause people

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-08 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  > you are always creating a newly addressable resource when updating 
qualifiers or references
  
  I'm understanding this as "the hash changes through the update"? Yes, the 
name sort of implies that I just somewhat considered that a misnomer.
  Makes you wonder if the hash is then really good choice for an identifying 
criterion in an URI...

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-08 Thread Addshore 
Addshore added a comment.


  My thinking here is that this has to do with the fact that you are always 
creating a newly addressable resource when updating qualifiers or references, 
as the hash will change.

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-06 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  I was going to write that e.g. `POST 
​/statements​/{statement_id}​/qualifiers`, which in my understanding is a 
collection to which the request adds an object, and that this fits my 
understanding of the purpose of `POST` but now realize that this is probably 
about e.g. `/statements/{statement_id}/qualifiers/{qualifier_hash}`...
  
  And for that I don't have an answer, not even a suspicion at the moment.

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264544: Why are qualifiers and references updated via POST?

2020-10-04 Thread Silvan_WMDE 
Silvan_WMDE created this task.
Silvan_WMDE added projects: Wikibase REST API Schema, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Most resources in the proposed spec are replaced with `PUT` and updated with 
`PATCH`. However, `qualifiers` and `references` are updated using `POST`, which 
otherwise is reserved for creating new resources. Is that intentional? If it 
is, maybe it the underlying reasons should be documented somewhere, since they 
aren't immediately obvious.

TASK DETAIL
  https://phabricator.wikimedia.org/T264544

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5003/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Silvan_WMDE
Cc: Silvan_WMDE, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs