[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lydia_Pintscher]

Lydia_Pintscher closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to ❌ 
Blocked on the Wikidata Query Builder board.
Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata 
Query Builder (Wikidata Query Builder - sprint 6).

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup moved this task from Peer Review to ❌ Blocked on the Wikidata Query 
Builder (Wikidata Query Builder - sprint 6) board.
Ladsgroup added a comment.


  Okay, reverted and deployed. Looks good so far but will keep an eye on it in 
the next two days.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5143/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Sure.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup added a subscriber: Lydia_Pintscher.
Ladsgroup added a comment.


  In T269224#6744325 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T269224#6740250 , 
@Ladsgroup wrote:
  >
  >>> Is there a way to check which version of the QueryService UI is deployed 
in production? For example, can I see the git commit hash somewhere or 
something similar?
  >>
  >> Yes, https://github.com/wikimedia/wikidata-query-deploy/commits/master
  >
  > Well, that doesn’t tell you that much, since the Git author date might be a 
long time before the commit was actually deployed. Checking the time when 
something was merged on Gerrit would probably be more representative.
  
  https://gerrit.wikimedia.org/r/q/project:wikidata/query/deploy but in one or 
two cases the deployer bypassed gerrit and pushed directly to the repo
  
  > But now that we’re supposed to have faster deployments thanks to 
microsites, should we try to revert the URL part and see if it affects the data?
  
  If @Lydia_Pintscher  is fine we potentially lose a day or two of data, I'm 
fine.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T269224#6740250 , 
@Ladsgroup wrote:
  
  >> Is there a way to check which version of the QueryService UI is deployed 
in production? For example, can I see the git commit hash somewhere or 
something similar?
  >
  > Yes, https://github.com/wikimedia/wikidata-query-deploy/commits/master
  
  Well, that doesn’t tell you that much, since the Git author date might be a 
long time before the commit was actually deployed. Checking the time when 
something was merged on Gerrit would probably be more representative.
  
  But now that we’re supposed to have faster deployments thanks to microsites, 
should we try to revert the URL part and see if it affects the data?

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup added a comment.


  In T269224#6740202 , 
@Michael wrote:
  
  > In T269224#6736658 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> The example at 
https://developer.mozilla.org/en-US/docs/Web/API/Document/URL#result seems to 
show that `document.URL` returns the URL of the inner document, not the 
top-level window.
  >
  > Ok, so adding `document.URL` there should not have made any difference. So, 
maybe the query service UI wasn't actually deployed after we added the code for 
`document.referrer`?
  
  I double checked and we getting data aligns with the second deployment (and 
not the first).
  
  > Is there a way to check which version of the QueryService UI is deployed in 
production? For example, can I see the git commit hash somewhere or something 
similar?
  
  Yes, https://github.com/wikimedia/wikidata-query-deploy/commits/master

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael added a comment.


  In T269224#6736658 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > The example at 
https://developer.mozilla.org/en-US/docs/Web/API/Document/URL#result seems to 
show that `document.URL` returns the URL of the inner document, not the 
top-level window.
  
  Ok, so adding `document.URL` there should not have made any difference. So, 
maybe the query service UI wasn't actually deployed after we added the code for 
`document.referrer`?
  
  Is there a way to check which version of the QueryService UI is deployed in 
production? For example, can I see the git commit hash somewhere or something 
similar?

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T269224#6719226 , 
@Ladsgroup wrote:
  
  > In T269224#6719125 , 
@Michael wrote:
  >
  >> Ok, then let's try `document.URL` 👍
  >>
  >> If you have a link to share that goes into more detail as to what is 
available to JS in an iframe, then I would be happy to learn more about it :)
  >
  > I don't have phd in iframeology but I have a feeling that js for iframe is 
being run in the context of the main frame meaning document.URL is needed 
instead of document.referrer.
  
  The example at 
https://developer.mozilla.org/en-US/docs/Web/API/Document/URL#result seems to 
show that `document.URL` returns the URL of the inner document, not the 
top-level window.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Hazizibinmahdi, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 5 to 
Wikidata Query Builder - sprint 6 on the Wikidata Query Builder board.
Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query 
Builder - sprint 6); removed Wikidata Query Builder (Wikidata Query Builder - 
sprint 5).

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Manishsamota
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael added a comment.


  In T269224#6719226 , 
@Ladsgroup wrote:
  
  > In T269224#6719125 , 
@Michael wrote:
  >
  >> Ok, then let's try `document.URL` 👍
  >>
  >> If you have a link to share that goes into more detail as to what is 
available to JS in an iframe, then I would be happy to learn more about it :)
  >
  > I don't have phd in iframeology but I have a feeling that js for iframe is 
being run in the context of the main frame meaning document.URL is needed 
instead of document.referrer.
  
  🤞

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup added a comment.


  In T269224#6719125 , 
@Michael wrote:
  
  > Ok, then let's try `document.URL` 👍
  >
  > If you have a link to share that goes into more detail as to what is 
available to JS in an iframe, then I would be happy to learn more about it :)
  
  I don't have phd in iframeology but I have a feeling that js for iframe is 
being run in the context of the main frame meaning document.URL is needed 
instead of document.referrer.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 654228 **merged** by Ladsgroup:
  [wikidata/query/gui-deploy@production] Merging from 
94034f916853b177068051bf86ba942f0f6b618a:
  
  https://gerrit.wikimedia.org/r/654228

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 654228 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [wikidata/query/gui-deploy@production] Merging from 
94034f916853b177068051bf86ba942f0f6b618a:
  
  https://gerrit.wikimedia.org/r/654228

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 654222 **merged** by jenkins-bot:
  [wikidata/query/gui@master] Check document.URL for query-builder referrer too
  
  https://gerrit.wikimedia.org/r/654222

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael added a comment.


  Ok, then let's try `document.URL` 👍
  
  If you have a link to share that goes into more detail as to what is 
available to JS in an iframe, then I would be happy to learn more about it :)

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup moved this task from Done to Peer Review on the Wikidata Query 
Builder (Wikidata Query Builder - sprint 5) board.
Ladsgroup added a comment.


  It got deployed and it seems it didn't work. I investigated and this came up. 
^

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 654222 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [wikidata/query/gui@master] Check document.URL for query-builder referrer too
  
  https://gerrit.wikimedia.org/r/654222

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-12-21T08:31:46Z] 
 Finished deploy [wdqs/wdqs@512d713]: GUI updates (T269224 
+i18n updates) (duration: 08m 57s)

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-12-21T08:22:49Z] 
 Started deploy [wdqs/wdqs@512d713]: GUI updates (T269224 
+i18n updates)

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup added a comment.


  In T269224#6699377 , 
@Michael wrote:
  
  > This still needs a few things:
  >
  > [ ] the change needs to be deployed
  > [ ] we need Grafana boards for it
  
  I was doing it as part of the story itself (maybe a new subtask?) because 
once the patch is merged we usually call the task (not the story) done.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael moved this task from Done to To Do on the Wikidata Query Builder 
(Wikidata Query Builder - sprint 5) board.
Michael added a comment.


  This still needs a few things:
  
  [ ] the change needs to be deployed
  [ ] we need Grafana boards for it

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 645045 **merged** by jenkins-bot:
  [wikidata/query/gui@master] Make ResultView.js track based on referrer as well
  
  https://gerrit.wikimedia.org/r/645045

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Alter-paule, Manishsamota, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[gerritbot]

gerritbot added a comment.


  Change 645045 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [wikidata/query/gui@master] Make ResultView.js track based on referrer as well
  
  https://gerrit.wikimedia.org/r/645045

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder 
(Wikidata Query Builder - sprint 5) board.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Manishsamota, Hazizibinmahdi, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

[Michael]

Michael created this task.
Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query 
Builder - sprint 5).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  In T265243 , it was investigated 
how to track the outcomes of the queries made by the Query Builder. It was 
concluded that using Hadoop would not be ideal, but that we much easier use the 
embedded query service results view for tracking.
  
  This embedded query service results view has already tracking of its own in 
ResultView.js 
.
  
  We want to add tracking for:
  
  - Query Builder queries that are successful (even if they returned no matches)
  - Query Builder queries that resulted in a timeout
  - Query Builder queries that resulted in any other error
  
  We can use `document.referrer` to tell referrers apart.
  
  **Acceptance criteria:**
  
  [ ] track the referrers based on a list (no-referrer, query-builder, other)
  [ ] for each referrer track success results, error and timeouts
  
  **Open Question:**
  
  - is tracking the referrer based on an explicit list the best way to do it?
- tracking every referrer could be a privacy problem? Also it would 
introduce/track arbitrary data in Grafana
- tracking based on a list makes the Query Service UI aware of specific 
external consumers which seems to be the wrong way around

TASK DETAIL
  https://phabricator.wikimedia.org/T269224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs