[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-19 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-19 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-19 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-19 Thread gerritbot 
gerritbot added a comment.


  Change 656433 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Maintenance script for removing 
deleted items from the term store
  
  https://gerrit.wikimedia.org/r/656433

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-15 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-15 Thread gerritbot 
gerritbot added a comment.


  Change 656433 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/Wikibase@master] Maintenance script for removing 
deleted items from the term store
  
  https://gerrit.wikimedia.org/r/656433

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2021-01-11 Thread Rosalie_WMDE 
Rosalie_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2020-12-16 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  There seems to be some confusion at the moment about whose responsibility it 
is to ensure terms are unused when they’re cleaned. The `TermStoreCleaner` 
interface says:
  
  > Delete the given term in lang IDs.
  > Ensuring that they are unreferenced is the caller’s responsibility.
  
  But the `DatabaseUsageCheckingTermStoreCleaner` implementation does:
  
  > Checks the provided TermInLangIds for existence and usage in either
  > on both Items and Properties.
  >
  > Those that do actually exist and are unused are passed to an inner cleaner.
  
  
  
$unusedTermInLangIds = $this->findActuallyUnusedTermInLangIds( 
$termInLangIds, $dbw );
$this->innerCleaner->cleanTermInLangIds( $dbw, $dbr, $unusedTermInLangIds );
  
  I think the “it’s the caller’s responsibility” was the original design, but 
then Split new term storage cleaning into own transaction 
 happened (T244115 
, cc @Addshore) and now the cleaner 
has to check for unused terms as well. We should check how the interface is 
currently used; if all callers now rely on the cleaner checking for usage, then 
it’s probably best to update the interface documentation (and the 
`InMemoryTermStore` implementation) while leaving the 
`DatabaseUsageCheckingTermStoreCleaner` unchanged.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270247: Write maintenance script for removing deleted items from the term store

2020-12-16 Thread noarave 
noarave created this task.
noarave added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

TASK DESCRIPTION
  This is done to ensure we clean up not just wbt_term_in_lang, but also 
wbt_text_in_lang and wbt_text. 
  The maintenance script shouldn’t need to do much more than call 
TermStoreCleaner::cleanTermInLangIds(), after checking that the term really 
isn’t used anymore.
  
  Script to be located in repo/maintenance/.

TASK DETAIL
  https://phabricator.wikimedia.org/T270247

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Lucas_Werkmeister_WMDE, Aklapper, Addshore, MisterSynergy, noarave, 
Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs