[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Charlie_WMDE closed this task as "Resolved". Charlie_WMDE added a comment. okay, that makes sense! thanks for looking into it. closing this ticket now \o/ TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Charlie_WMDE Cc: Lydia_Pintscher, Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Ladsgroup added a comment.
The style is:
.querybuilder__condition-placeholder {
margin-block: $dimension-layout-xsmall;
padding-block: $dimension-layout-xsmall;
}
Which in turn becomes 1em in the output. Normally it's 16px but I assume
given that the font-size is `.875em`, the computed em value also changes to
14px. (16*.875=14)
I'm not good at frontend stuff but this from
https://www.w3.org/Style/Examples/007/units.en.html so I might be wrong:
> The em and ex units depend on the font and may be different for each
element in the document. The em is simply the font size.
TASK DETAIL
https://phabricator.wikimedia.org/T272053
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup
Cc: Lydia_Pintscher, Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi,
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Charlie_WMDE added a comment. @Ladsgroup looks good but all the spacing is 14px instead of 16px(dimension-layout-xsmall) for some reason. is that some firefox issue? TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Charlie_WMDE Cc: Lydia_Pintscher, Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Lydia_Pintscher added a comment. \o/ @Charlie_WMDE Please close if it's also good from your side. TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lydia_Pintscher Cc: Lydia_Pintscher, Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to Test (Verification) on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata Query Builder (Wikidata Query Builder - sprint 6). TASK DETAIL https://phabricator.wikimedia.org/T272053 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lydia_Pintscher Cc: Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Devouring the cookie: https://github.com/wmde/query-builder/pull/161 TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Charlie_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well
Charlie_WMDE renamed this task from "Make the last condition removable as well" to "(MS 2) Make the last condition removable as well". TASK DETAIL https://phabricator.wikimedia.org/T272053 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Aklapper, Charlie_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
