[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  If I understand the error correctly, it was a race condition that happened if 
`chd_seen` was increased between these two queries:
  
$row = $dbr->selectRow(
$this->changesTable,
'max( change_id ) as maxid',
[],
__METHOD__ );

$maxId = $row ? $row->maxid : 0;
  
  
  
$where = [
'( chd_touched < ' . $dbr->addQuotes( $freshDispatchTime ) . // and 
wasn't touched too recently or
// or it's lagging by more than batchSize
' OR ( ' . (int)$maxId . ' - CAST(chd_seen AS SIGNED) ) > ' . 
(int)$this->batchSize . ') ' ,
'chd_seen < ' . (int)$maxId, // and not fully up to date.
'chd_disabled = 0' // and not disabled
];
  
  At least, I assume it’s usually the case that `chd_seen < change_id`. If 
that’s true, this would be pretty difficult to test, since you’d need a second 
process to insert and dispatch new changes while the first process is right 
between those queries (which immediately follow one another in 
`SqlChangeDispatchCoordinator::getCandidateClients()`).
  
  (Though there is a TODO to “pass the max change ID as a parameter”, so 
presumably this condition would become more likely if that TODO was 
implemented.)

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: Urbanecm, WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, 
Ladsgroup, Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Izno, Verdy_p, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread WMDE-leszek 
WMDE-leszek added a comment.


  It is likely too late so it is likely purely speculative comment:
  I wonder if there could be some sensible automated tests provided that could 
have caught this kind of regression? Maybe some kind of property-based test 
that would be punching in some "well-formed" data and verify that INSERT/UPDATE 
succeeds? Might be very arbitrary, hence not particularly useful (a.k.a. 
overkill)
  I'm not an expert in low-level database world so I simply don't know what 
practices might exist.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, WMDE-leszek
Cc: Urbanecm, WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, 
Ladsgroup, Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Izno, Verdy_p, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup merged a task: T274169: Error 1690: BIGINT UNSIGNED value is out of 
range in (1350732636 - 
`wikidatawiki`.`wb_changes_dispatch`.`chd_seen`) (10.64.48.172) Function: 
Wikibase\Repo\Store\Sql\SqlChangeDispatchCoordinator::getCandidateClients.
Ladsgroup added a subscriber: Urbanecm.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Urbanecm, WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, 
Ladsgroup, Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Izno, Verdy_p, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup added a project: Wikimedia-production-error.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Verdy_p, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup added a comment.


  I agree. I think it's good enough. It's just it's not deployed yet and we 
need to wait for wmf.29 to get deployed.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I moved this to Verification but then remembered that I initially only 
proposed the cast as a quick fix :D @Ladsgroup do you think this needs a 
different, proper fix? Or is the cast actually the correct solution? (I’m 
leaning towards the latter but not sure.)

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 
2021-02-02); removed MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662666 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Cast chd_seen as signed 
integer
  
  https://gerrit.wikimedia.org/r/662666

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662667 **abandoned** by Ladsgroup:
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.27] Cast chd_seen as signed 
integer
  
  Reason:
  Can't work with 27 easily. Let's just wait for wmf.29 to reach production
  
  https://gerrit.wikimedia.org/r/662667

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662667 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.27] Cast chd_seen as signed 
integer
  
  https://gerrit.wikimedia.org/r/662667

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662666 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Cast chd_seen as signed 
integer
  
  https://gerrit.wikimedia.org/r/662666

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup added a comment.


  Yeah. "Fun"

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Probably, but how much? wmf.29 and also wmf.27 I guess?

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup added a comment.


  Shall we backport?

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662635 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Cast chd_seen as signed integer
  
  https://gerrit.wikimedia.org/r/662635

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer 
Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup claimed this task.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread gerritbot 
gerritbot added a comment.


  Change 662635 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Cast chd_seen as signed integer
  
  https://gerrit.wikimedia.org/r/662635

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Marostegui 
Marostegui added a comment.


  In T274091#6809810 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > As a quick fix, we could probably change the query to use `CAST(chd_seen AS 
SIGNED)`; apparently that casts to a signed //64-bit// integer, so we 
(hopefully) wouldn’t even run into overflow problems once the value grows 
beyond a 31-bit integer (which it hasn’t yet, anyways).
  
  I would support this idea!

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Marostegui
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  As a quick fix, we could probably change the query to use `CAST(chd_seen AS 
SIGNED)`; apparently that casts to a signed //64-bit// integer, so we 
(hopefully) wouldn’t even run into overflow problems once the value grows 
beyond a 31-bit integer (which it hasn’t yet, anyways).

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup added a comment.


  This is interesting, I think MySQL is being a bit picky. Here's some similar 
error reports: 
https://stackoverflow.com/questions/5605085/bigint-unsigned-value-is-out-of-range
 and 
https://dba.stackexchange.com/questions/212838/bigint-unsigned-value-is-out-of-range
  
  It basically happens when value of `( 1350455613 - chd_seen )` in `( 
1350455613 - chd_seen ) > 420` becomes negative. I can be mitigated by setting 
`NO_UNSIGNED_SUBTRACTION` to false but OTOH, this condition seems a bit like 
magic. Why you need something like that? I dig deeper.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-08 Thread Ladsgroup 
Ladsgroup removed LucasWerkmeister as the assignee of this task.
Ladsgroup added a subscriber: LucasWerkmeister.

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: LucasWerkmeister, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
Marostegui, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T274091: Errors on wikidatawiki.wb_changes_dispatch.chd_seen

2021-02-07 Thread Marostegui 
Marostegui created this task.
Marostegui added projects: Wikidata, Technical-Debt, wdwb-tech-focus (backlog), 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

TASK DESCRIPTION
  Probably related to the schema change requested at T273874: Make 
wb_changes_dispatch.chd_seen unsigned in production 
 I am seeing these errors on 
logstash: https://logstash.wikimedia.org/goto/2f4001fc1b07e15617f6eea15e3d3465
  
error
BIGINT UNSIGNED value is out of range in '(1350455613 - 
`wikidatawiki`.`wb_changes_dispatch`.`chd_seen`)' (10.64.48.172)

message
Error 1690 from 
Wikibase\Repo\Store\Sql\SqlChangeDispatchCoordinator::getCandidateClients, 
BIGINT UNSIGNED value is out of range in '(1350455613 - 
`wikidatawiki`.`wb_changes_dispatch`.`chd_seen`)' (10.64.48.172) SELECT  
chd_site AS `value`  FROM `wb_changes_dispatch`WHERE (( chd_touched < 
'20210208073506' OR ( 1350455613 - chd_seen ) > 420) ) AND (chd_seen < 
1350455613) AND (chd_disabled = 0)  ORDER BY chd_seen ASC LIMIT 15   
10.64.48.172

exception.trace
from 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/Database.php(1683)
#0 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/Database.php(1661):
 Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, 
string)
#1 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/Database.php(1230):
 Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, 
boolean)
#2 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/Database.php(1910):
 Wikimedia\Rdbms\Database->query(string, string, integer)
#3 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/Database.php(1772):
 Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
#4 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/DBConnRef.php(68):
 Wikimedia\Rdbms\Database->selectFieldValues(string, string, array, string, 
array)
#5 
/srv/mediawiki/php-1.36.0-wmf.27/includes/libs/rdbms/database/DBConnRef.php(306):
 Wikimedia\Rdbms\DBConnRef->__call(string, array)
  
  There are not many errors, but I think this needs to be investigated

TASK DETAIL
  https://phabricator.wikimedia.org/T274091

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Marostegui
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Marostegui, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs