[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE added a comment.


  We could do that, since we've been accumulating several component changes 
without pre-releasing and updating the QB. 
  Otherwise, we could also wait until the whole list of required tasks to be 
tackled before the next major WiKit release is completed (see task 
). There are a couple of tasks that 
still need to be worked on, but I believe both tasks received very low 
estimations, so the situation might need to be reassessed. I was planning on 
bringing this as a discussion topic for our DS grooming session today.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Michael]

Michael added a comment.


  In T274261#7165137 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > PR merged. What’s next – do we cut a new release and update the query 
builder too?
  
  Eventually yes, but as I understand it, we want to get in some more changes 
before doing a big release: T280159: Release WiKit (Wikidata/Wikibase Design 
System) version 2.0.0 

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) 
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  PR merged. What’s next – do we cut a new release and update the query builder 
too?

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  https://github.com/wmde/wikit/pull/436

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  From a discussion with Sarai: We’ll do it in three steps:
  
  1. For the start-* and end-* positions, swap the axes, e.g. turn `start-top` 
into `top-start`. If that’s not enough to resolve the overflow:
  2. Flip the horizontal axis, e.g. turn `top-start` into `top-end`. If that’s 
not enough to resolve the overflow:
  3. Reduce the max-width, down to 256px.
  
  There will be a flag to force the component to respect the original position, 
disabling steps 1 and 2 (but keeping 3).

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Hi! The suggestion documented in the Figma file is to start by flipping the 
position of the popover (this might be the solution in the majority of the 
cases) and then adjust the width of the popover in case it's still needed (the 
assumption is that the size adjustment might be less frequent and minor thanks 
to the new position).
  
  F34499275: Screenshot 2021-06-14 at 11.35.38.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  @Sarai-WMDE the instructions in Figma are a bit unclear to me – do we first 
flip the position, and then resize up to 256px if flipping wasn’t enough, or do 
we first resize and then flip if we would have to resize below 256px?

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T274261#6878528 , 
@Michael wrote:
  
  > Ways to approach it:
  >
  > Apply minimum calculation for the max width #362 
 to shrink it
  
  I looked into this but it doesn’t seem to be possible in CSS alone. I think 
we would need something like
  
max-width: min(384px, calc(95vw - element-position-left()));

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Addshore]

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE updated the task description.
Sarai-WMDE set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[WMDE-leszek]

WMDE-leszek added a comment.


  Initial estimate on the range 3-8 story points

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T274261: The popover component should be responsive to prevent overflow

[Sarai-WMDE]

Sarai-WMDE renamed this task from "the popover should be responsive to prevent 
making the screen scroll" to "The popover component should be responsive to 
prevent overflow".
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T274261

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Sarai-WMDE, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org