[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-07-20 Thread Addshore 
Addshore moved this task from To Prioritize to Triaged Low (0-50) on the 
wdwb-tech board.
Addshore triaged this task as "Low" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3532/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE 
ItamarWMDE added a comment.


  Cool, thanks for the reply, yeah the "fix" shouldn't be too much trouble, I 
just wasn't sure if this was intentional, or even worth spending time on, 
since, as you say, the resulting lookup would act exactly the same either way. 
I can take care of it after T277314  
is fully merged.

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread Addshore 
Addshore added a comment.


  So the top level of dispatching happens in 
https://github.com/wikimedia/Wikibase/blob/4eefb25d289d928f81230f306570a1a575a7ceba/data-access/src/MultipleEntitySourceServices.php#L95-L108
  This currently gets a PrefetchingTermLookup for the whole entity source, 
rather than for a specific entity type from the entity source.
  It appears this is why things get wrapped twice.
  
  Although appearing a bit odd this should end up doing the right thing and 
shouldn't have much overhead.
  
  A "fix" would be to modify 
https://github.com/wikimedia/Wikibase/blob/4eefb25d289d928f81230f306570a1a575a7ceba/data-access/src/SingleEntitySourceServices.php#L346-L377
 / `SingleEntitySourceServices` to allow retrieval of services like this 
specific to one of the entity types that they are the source for.

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE 
ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread Addshore 
Addshore added a comment.


  Possibly related T253754: Make Wikibase type dispatching services more 
uniform 

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277737: PrefetchingTermLookup Service returns a doubly nested Term Lookup

2021-03-18 Thread ItamarWMDE 
ItamarWMDE added projects: Wikidata, wdwb-tech-focus.

TASK DETAIL
  https://phabricator.wikimedia.org/T277737

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs