[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Addshore]

Addshore closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Addshore
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, 
Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Maintenance_bot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, 
Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Suran38, 
Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, ReleaseTaggerBot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, 
Aklapper, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[gerritbot]

gerritbot added a comment.


  Change 715707 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Add separators to 
UniqueValueChecker
  
  https://gerrit.wikimedia.org/r/715707

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, 
Aklapper, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[gerritbot]

gerritbot added a comment.


  Change 715707 had a related patch set uploaded (by Tobias Andersson; author: 
Tobias Andersson):
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Add separator
  
  https://gerrit.wikimedia.org/r/715707

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[toan]

toan claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Hm, maybe it’s possible in SPARQL after all. I think adding this snippet for 
each separator property ID ought to be equivalent to the `MainSnakContext` 
methods (in particular `haveSameQualifiers`):
  
MINUS {
  ?statement pq:$separator ?qualifier.
  MINUS {
?otherStatement pq:$separator ?qualifier.
  }
}
MINUS {
  ?otherStatement pq:$separator ?qualifier.
  MINUS {
?statement pq:$separator ?qualifier.
  }
}
MINUS {
  ?statement a wdno:$separator.
  MINUS {
?otherStatement a wdno:$separator.
  }
}
MINUS {
  ?otherStatement a wdno:$separator.
  MINUS {
?statement a wdno:$separator.
  }
}
  
  That is, if the current statement has a non-“no value” qualifier and the 
other statement doesn’t have the same qualifier, or vice versa, or the current 
statement has a “no value” qualifier and the other statement doesn’t, or vice 
versa, then the statements are considered different, are not returned from the 
query, and don’t generate a violation. (“Unknown value” is always considered to 
be different from other “unknown value”, both in the query service and in the 
constraints extension, so an “unknown value” qualifier automatically means the 
statement is separated from all other statements, which is what we want.)
  
  I haven’t tested this query yet; in particular, we’d need to make sure if 
nested `MINUS` works this way. Or maybe use `FILTER NOT EXISTS` instead.
  
  I guess the second half, for “no value”, could also be:
  
FILTER(EXISTS { ?statement a wdno:$separator. }
== EXISTS { ?otherStatement a wdno:$separator. })

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Some tech notes:
  
  First of all, the distinct values constraint type is supported on qualifiers 
and references (T175561 ), but I 
assume the separators parameter only applies on the main snak.
  
  I’m also not sure how this should best be implemented. I can see two options: 
in SPARQL, or after SPARQL.
  
  Currently, we find items with the same value using a SPARQL query 
(`SparqlHelper::findEntitiesWithSameStatement()`), with a hard-coded `LIMIT 
10`: the constraint violation message will display at most ten other items with 
the same value. (IIRC, lists of items in constraint violation messages also 
generally get truncated at some number, possibly 10 as well. Maybe the SPARQL 
limit should be 11 instead of 10 so that we can distinguish between “exactly 
10” and “more than 10”…) We could take those up to 10 other items, load them in 
PHP, and check if they have different qualifiers for the separator property; if 
yes, then there’s no violation. The problem with this is that there could be 
many items with the same value but different qualifiers, and also some items 
that are genuine constraint violations, but unless those few items happen to be 
returned in the first 10 query results, we won’t find them. (On the bright 
side, this is a false positive – a missing constraint violation – which is the 
preferable kind of error here. A false negative, constraint violation when 
everything’s actually okay, is worse.)
  
  The other option would be to check the separators directly in the SPARQL 
query; the downside is that this makes the query more complicated, especially 
if there are several separator properties. I feel like it will be pretty tricky 
to ensure it behaves exactly the same as the PHP implementation of separators 
(which is in `MainSnakContext::getSnakGroup()` and related methods).

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Addshore]

Addshore moved this task from Prioritized Product (prioritised from top to 
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Addshore]

Addshore set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Esc3300]

Esc3300 added a comment.


  It could be interesting to get this to work for identifiers that are 
re-assigned, e.g. ISO country codes or airport codes.
  
  Start/end date qualifiers differentiate them. An "identifier shared with" 
qualifier could work too.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Nikki]

Nikki added a comment.


  I created this ticket is because I want a way to resolve the constraint 
violations for the Duden ID property. I don't care whether we use the existing 
"separator" property (renaming it if necessary) or whether we add a new 
property which does the same thing, but I think a proposal for a new property 
would probably be rejected.
  
  I don't understand what the semantic distinction you're making is - why would 
PRONOM make sense if Duden doesn't?

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I’m not convinced by the Duden ID example – “identifier shared with” isn’t 
really semantically a separator, in my opinion – but there are some other 
properties with separators on distint-values constraints 

 already, some of which make more sense to me, such as mobile country code 
 (separated by start time, end time, 
point in time) or PRONOM file format identifier 
 (separated by software version).

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Manuel, Esc3300, Moebeus, Nikki, Aklapper, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Esc3300]

Esc3300 added a comment.


  I think T236295  could solve this 
too.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Esc3300, Moebeus, Nikki, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, abian, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Lydia_Pintscher]

Lydia_Pintscher triaged this task as "Medium" priority.
Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Moebeus, Nikki, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Moebeus, Nikki, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277855: Support "separators" parameter for distinct value constraints

[Nikki]

Nikki created this task.
Nikki added projects: Wikibase-Quality-Constraints, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  There is often not quite a one-to-one mapping between entities and external 
identifiers which causes entities to create constraint violations for the 
single value and distinct value constraints.
  
  When a single entity has multiple identifiers, we can use the separator 
 property on the constraint to 
specify which qualifiers can be used to make the entity not trigger a 
constraint violation (see T173594 ). 
I would like to have a similar thing for the distinct value constraint which 
would allow us to use qualifiers like identifier shared with 
 on the statements instead of 
having to list the entities as exceptions to the constraint.

TASK DETAIL
  https://phabricator.wikimedia.org/T277855

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Aklapper, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs