[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Michael]

Michael added a comment.


  Makes sense, thanks!
  
  Running a codesearch with the regex from the description does reveal new 
matches, but they are all in the two categories already mentioned above: 
phpunit XML syntax and the spam-blacklist name:
  
  
https://codesearch.wmcloud.org/things/?q=%28white%7Cblack%29%5B+%5C-%5D%3Flist===Extension%3AWikibase
  (7 matching files total: 4 phpunit xml, 1 referencing phpunit xml, 2 in the 
rest-api mentioning error-codes from spam-blacklist)

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Michael, JArguello-WMF, toan, Aklapper, Reedy, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, Lydia_Pintscher, 
siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think `NoBadUsageTestBase` would work for cases where we want to prevent 
PHP things (e.g. `DB_MASTER` instead of `DB_PRIMARY`), but for such a general 
check, I’m not convinced it’s worth checking automatically.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, JArguello-WMF, toan, Aklapper, Reedy, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, Lydia_Pintscher, 
siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Michael]

Michael added a subscriber: Lucas_Werkmeister_WMDE.
Michael added a comment.


  In T277971#9607911 , 
@Reedy wrote:
  
  > [...]
  >
  > If someone has double checked that no new instances (that again are first 
party, and can be fixed) have come in since this was filed, I think it's fine 
to close the task.
  
  Mh, I wonder if that would be something worth adding to the respective tests 
extending `NoBadUsageTestBase`, like `ClientNoBadUsageTest` etc. That way we 
can also reliably prevent that in the future. I'm curious what 
@Lucas_Werkmeister_WMDE thinks.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Michael, JArguello-WMF, toan, Aklapper, Reedy, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, Lydia_Pintscher, 
siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Reedy]

Reedy added a comment.


  I think as long as the first party ones are fixed, that's the main thing.
  
  Tasks like T254650: Rename TitleBlacklist 
 and T254649: Rename SpamBlacklist 
 exist to fix those underlying 
issues, and as we normally would expect in our day to day development, when 
those tasks themselves are addressed, eventually there will be followup here, 
and in any other usages. Similar for documentation referring to how things are 
named in PHPUnit.
  
  It was more of a case for ease that all matches were just dumped to the bugs.
  
  If someone has double checked that no new instances (that again are first 
party, and can be fixed) have come in since this was filed, I think it's fine 
to close the task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Michael, JArguello-WMF, toan, Aklapper, Reedy, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Dinoguy1000, Amire80, Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Michael]

Michael added a comment.


  The stylelint one has been fixed in the meantime.
  
  From looking at the description, all the remaining occurrences are either 1) 
upstream-syntax (phpunit) or 2) directly referencing upstream syntax or naming 
(SpamBlacklist, phpunit.xml's whitelist)
  
  How do we move forward with this?

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, JArguello-WMF, toan, Aklapper, Reedy, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Dinoguy1000, Amire80, Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[JArguello-WMF]

JArguello-WMF added a comment.


  Hi, @Reedy and @toan, I'm trying to use T-shirt sizes to measure the effort 
required for each task to invite folks at the WMF to join and decide which ones 
they'd like to tackle by giving them information about the effort and any other 
info you consider relevant.
  
  | Size | Time   | Score |
  | XS   | At Most 1 Hour | 0 |
  | S| At Most 1 Day  | 1 |
  | M| At Most 3 Days | 3 |
  | L| At Most 5 Days | 5 |
  | XL   | Needs Re-Eval  | 9 |
  | ?| Unknown|   |
  |
  
  For this specific task, T277971 , 
What would you say the size is?

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JArguello-WMF
Cc: JArguello-WMF, toan, Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Aklapper, Reedy, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g, Alter-paule, Beast1978, Un1tY, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[gerritbot]

gerritbot added a comment.


  Change 673657 **merged** by jenkins-bot:
  [wikibase/termbox@master] Improve wording of a comment
  
  https://gerrit.wikimedia.org/r/673657

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Reedy, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Reedy]

Reedy updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Aklapper, Reedy, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Reedy, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[gerritbot]

gerritbot added a comment.


  Change 673657 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [wikibase/termbox@master] Improve wording of a comment
  
  https://gerrit.wikimedia.org/r/673657

TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Reedy, maantietaja, Akuckartz, darthmon_wmde, Nandana, lucamauri, 
Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

[Reedy]

Reedy created this task.
Reedy added projects: Voice & Tone, Wikibase, 
MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION


TASK DETAIL
  https://phabricator.wikimedia.org/T277971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Aklapper, Reedy, maantietaja, Akuckartz, darthmon_wmde, Nandana, lucamauri, 
Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Dinoguy1000, Amire80, 
Lydia_Pintscher, siebrand, Mbch331, Jay8g, Quiddity
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs