[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Maintenance_bot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, ReleaseTaggerBot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the 
Wikibase Service Migration board.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread gerritbot 
gerritbot added a comment.


  Change 676038 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Remove TODO comment for item 
vocabulary base URI
  
  https://gerrit.wikimedia.org/r/676038

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread gerritbot 
gerritbot added a comment.


  Change 676038 had a related patch set uploaded (by Itamar Givon; author: 
Itamar Givon):
  
  [mediawiki/extensions/Wikibase@master] Remove TODO comment for item 
vocabulary base URI
  
  https://gerrit.wikimedia.org/r/676038

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread ItamarWMDE 
ItamarWMDE added a comment.


  As per Leszek's reply on 675790 
, I 
will remove the comment.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-31 Thread ItamarWMDE 
ItamarWMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-30 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278850: Check TODO comment for item vocabulary base URI

2021-03-30 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration, 
wdwb-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The WikibaseRepo `ItemVocabularyBaseUri` service has the following TODO 
comment:
  
  > We currently use the local repo concept URI here. This should be 
configurable,
  > to e.g. allow 3rd parties to use Wikidata as their vocabulary repo.
  
  We kept this comment while migrating the service to the service container 
(T277576 ), but we’re not sure if it 
still applies. The “local repo concept URI” is almost definitely outdated – the 
code was changed from `$this->getLocalEntitySource()->getConceptBaseUri()` to 
`$this->getEntitySourceDefinitions()->getSourceForEntityType( Item::ENTITY_TYPE 
)->getConceptBaseUri()` in Cleanup repo Item vocab uri parsing & fix federated 
units  
– but does that mean that the TODO can be removed completely, or is there still 
something to be done and it should just be updated?
  
  @WMDE-leszek and @Addshore would probably be the main people who know more 
about this.

TASK DETAIL
  https://phabricator.wikimedia.org/T278850

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs