[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
Lalamarie69, maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, 
eprodromou, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, 
Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[gerritbot]

gerritbot added a comment.


  Change 692264 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/core@master] Hard-deprecate DBAccessBase class
  
  https://gerrit.wikimedia.org/r/692264

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In that case I guess we go ahead with hard deprecation immediately.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > I assume at least the soft-deprecation can be backported to MediaWiki 1.36 
as well?
  
  Apparently not.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Lalamarie69, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[gerritbot]

gerritbot added a comment.


  Change 683819 **merged** by jenkins-bot:
  
  [mediawiki/core@master] Soft-deprecate DBAccessBase class
  
  https://gerrit.wikimedia.org/r/683819

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
Lalamarie69, maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, 
eprodromou, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, 
Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Addshore]

Addshore added a comment.


  Related T281453: Abstract database connections between Client and Repository 


TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Addshore
Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
Lalamarie69, maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, 
eprodromou, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, 
Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE removed a project: Wikibase Service Migration.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, Gaboe420, 
Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, Gaboe420, 
Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Banyek, Gaboe420, 
Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[gerritbot]

gerritbot added a comment.


  Change 683819 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/core@master] Soft-deprecate DBAccessBase class
  
  https://gerrit.wikimedia.org/r/683819

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Wikibase no longer uses `DBAccessBase`, so I assume the class can now be 
soft-deprecated in core, and then hard-deprecated and eventually removed later.
  
  I’m not sure if we’ll backport all the Wikibase changes to `REL1_36`, but I 
assume at least the soft-deprecation can be backported to MediaWiki 1.36 as 
well?

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281114: Stop using DBAccessBase in 
PropertyInfoTable as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281115: Stop using DBAccessBase in 
SiteLinkTable as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281113: Stop using DBAccessBase in 
EntityChangeLookup as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281116: Stop using DBAccessBase in 
WikiPageEntityMetaDataLookup as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281117: Stop using DBAccessBase in 
WikiPageEntityRevisionLookup as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T281118: Stop using DBAccessBase in 
SqlSiteLinkConflictLookup as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[daniel]

daniel edited projects, added Platform Team Workboards (Clinic Duty Team); 
removed Platform Engineering.
daniel triaged this task as "Low" priority.
daniel added a comment.


  Not high prio for the PET team, but if anyone wants to take it on, please do 
:)

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Naike, Akuckartz, eprodromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g, 
WDoranWMF, holger.knust, EvanProdromou
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[daniel]

daniel added a comment.


  Yea, it's not good to use a base class for this. It should be a trait, or 
just be removed.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Pchelolo]

Pchelolo added a subscriber: daniel.
Pchelolo added a comment.


  cc @Daniel as original author.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Pchelolo]

Pchelolo added a comment.


  I think we can go even further and just eliminate the class entirely. It 
provides no value - it has 3 lines of very simple code in it, no other classes 
seem to have methods typed with "DBConnectionBase" - zero value.
  
  For marking value objects that 'belong to a certain wiki' in cross-wiki 
environment, we now have `WikiAwareEntity` interface and a corresponding trait 
- see UserIdentityValue, PageIdentityValue etc for examples. For fetching a 
load balancer from a set domain we can just copy-paste that one line of code.
  
  If wikibase repos dependency on this class we can hard-deprecate it.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, 
Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikimedia-Rdbms, Wikidata, Wikibase 
Service Migration.
Restricted Application added a subscriber: Aklapper.
Restricted Application added projects: Platform Engineering, wdwb-tech.

TASK DESCRIPTION
  `DBAccessBase` is a base class for objects that need access to other wiki’s 
databases. Its constructor calls 
`MediaWikiServices::getInstance()->getDBLoadBalancerFactory()`, which means 
that this class, and any class extending it, is impossible to use in a unit 
test (where the service wiring is not set up). The lb factory should instead be 
injected into the constructor (optionally falling back to `MediaWikiServices`).
  
  An added complication is that, although `DBAccessBase` is only extended in 
Wikibase, the class itself is defined in MediaWiki, and marked `@stable to 
extend`.

TASK DETAIL
  https://phabricator.wikimedia.org/T279063

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs