[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: Aklapper, Michael, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Aklapper, Michael, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Biggs657, Lalamarie69, Alter-paule, Beast1978, Un1tY, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Aklapper, Michael, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread gerritbot
gerritbot added a comment.


  Change 703581 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Avoid using wfGetDB in 
SqlItemsWithoutSitelinksFinder
  
  https://gerrit.wikimedia.org/r/703581

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread gerritbot
gerritbot added a comment.


  Change 703581 had a related patch set uploaded (by Ladsgroup; author: 
Ladsgroup):
  
  [mediawiki/extensions/Wikibase@master] Avoid using wfGetDB in 
SqlItemsWithoutSitelinksFinder
  
  https://gerrit.wikimedia.org/r/703581

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Aklapper, Michael, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread Ladsgroup
Ladsgroup claimed this task.
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing 
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Michael, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-06 Thread Michael
Michael created this task.
Michael added projects: Wikidata, Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞).

TASK DESCRIPTION
  Note that `wfGetDB()` uses 
`\Wikimedia\Rdbms\LoadBalancer::getMaintenanceConnectionRef` internally. Check 
if //that// connection ref is really necessary for this use case.
  
  Also note from the documentation of `wfGetDB()`:
  
* Note 3: When replacing calls to this with calls to methods on an injected
* LoadBalancer, LoadBalancer::getConnectionRef is more commonly needed than
* LoadBalancer::getMaintenanceConnectionRef, which is needed for more 
advanced
* administrative tasks. See the IMaintainableDatabase and IDatabase 
interfaces
* for details.
  
  Acceptance Criteria:
  
  [ ] `wfGetDB()` is no longer used in `SqlItemsWithoutSitelinksFinder`
  [ ] `wfGetDB()` is no longer used in tests for this class

TASK DETAIL
  https://phabricator.wikimedia.org/T286252

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org