[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[Manuel]

Manuel removed a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: toan, Michael, Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, 
Jdforrester-WMF, hashar, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, TheReadOnly, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Peteosx1x, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar added a comment.


  When trying the jobs yesterday they failed again. The reason is that the 
extension dependencies are not injected by Zuul since the change is in progress 
and not deployed. I have been testing them by manually triggering them on 
Jenkins, I have added a temp change 
https://gerrit.wikimedia.org/r/c/integration/config/+/790984 to inject 
`EXT_DEPENDENCIES=mediawiki/skins/MinervaNeue\nmediawiki/extensions/MobileFrontend\nmediawiki/extensions/UniversalLanguageSelector`.
  
  Looking at the steps durations for the jobs:
  
  wikibase-selenium-bridge-docker 

  
  - 55 seconds to finish clone, dependencies and MediaWiki installation
  - 1m24 for `npm ci`
  - 2m08 for wdio
  
  wikibase-selenium-repo-docker 

  
  - 52 seconds to finish clone, dependencies and MediaWiki installation
  - 1m23 for `npm ci`
  - 1m20 for wdio
  
  In the wmf-quibble-selenium-php72-docker job 
 
that would shred roughly 5 minutes and 30 seconds of build time if I get it 
right.  Given that jobs takes 12 to 15 minutes to run, that would be a 
noticeable improvement.
  
  Then I guess from Wikibase repository we can rename the `selenium-test` 
target which will prevent Quibble from discovering them and thus stop running 
them in the CI jobs:
  
  name=Wikibase/package.json
"scripts": {
"selenium-test": "npm-run-all --continue-on-error selenium-test:*",
"selenium-test:repo": "wdio repo/tests/selenium/wdio.conf.js",
"selenium-test:bridge": "npm --prefix client/data-bridge run 
selenium-test",
}

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: toan, Michael, Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, 
Jdforrester-WMF, hashar, Aklapper, Fernandobacasegua34, Astuthiodit_1, 786, 
TheReadOnly, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Peteosx1x, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar added a comment.


  I have found the issue!
  
  I have created the Selenium jobs after the wikibase-client-docker and 
wikibase-repo-docker phpunit jobs which invoke the 
`extensions/Wikibase/build/jenkins/mw-apply-wb-settings.sh` with `-r client` or 
`-r repo` respectively.  For Selenium testing we need the repo to be setup I 
have thus made the jobs to always pass `-r repo`.
  
  For the dependencies `Cite` does not seem to be needed.
  
  https://gerrit.wikimedia.org/r/676107 creates bridge and repo Selenium jobs 
which has MobileFrontend, MinervaNeue and UniversalLanguageSelector as 
dependencies. The jobs are triggered from all those repositories as well as 
from mediawiki/core and mediawiki/vendor. I have done it in a similar way as 
the gated jobs (wmf-quibble-*). That should give a guarantee it will never 
break.
  
  Then I guess we can remove or rename `selenium-test` from the Wikibase 
package.json in order for Quibble to no more run it for other extensions. That 
would speed up the wmf-quibble-selenium-* job.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: toan, Michael, Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, 
Jdforrester-WMF, hashar, Aklapper, 786, TheReadOnly, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Peteosx1x, Alter-paule, 
Beast1978, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, 
Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar added a comment.


  I got the `repo` variant passing by adding a few extensions as dependencies:
  
  | mediawiki/skins/MinervaNeue|
  | mediawiki/extensions/Cite  |
  | mediawiki/extensions/MobileFrontend|
  | mediawiki/extensions/UniversalLanguageSelector |
  |
  
  The `client` one still fails with the same issue though, maybe it needs some 
more dependencies.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: toan, Michael, Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, 
Jdforrester-WMF, hashar, Aklapper, 786, TheReadOnly, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Peteosx1x, Alter-paule, 
Beast1978, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, 
Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar added a comment.


  In T287582#7368381 , 
@Addshore wrote:
  
  > I have a suspicion that we would not want to split out `client/data-bridge` 
tests.
  > data-bridge integrated directly with MediaWiki and should be gated, the 
browser tests cover this integration.
  
  We could have the job running `npm run selenium-test:bridge` to be triggered 
solely from mediawiki/core and Wikibase this way we keep the gating between the 
two projects but we no more run those tests for every single jobs or repository 
that include Wikibase as a dependency (`wmf-quibble-selenium-php72-docker` or 
Math which depends on Wikibase).
  
  Then it fails with `Error: badvalue: Unrecognized value for parameter 
"action": wbeditentity.`, maybe because it depends on some other extensions 
which would have to trigger that job as well.
  
  > `termbox` could be a better candidate to split out into a separate job that 
would not run as part of gated jobs as an initial step
  
  If my digging is correct the chain is:
  
  | `npm run selenium-test:repo`   |
  | Read config `repo/tests/selenium/wdio.conf.js` |
  | Add `/repo/tests/selenium/specs/*.js`  |
  | Add `/view/lib/wikibase-termbox/tests/selenium/specs/*.js` |
  |
  
  May we get a new `npm run selenium-test:termbox` and split that one to a 
standalone job as a first step? If those tests are no more run by changes 
affecting non Wikibase that will already by small win though they only take ~ 
40 seconds to run.
  
  > I would also propose that we put this firmly in the hands of extensions 
rather than in CI configuration and make some generic commands for use by wmf 
ci such as `ci-selenium-test-gate` and `ci-selenium-test` that we could then 
chop and change what runs as we see fit without needing to change things 
centrally.
  > This could perhaps then be used by other extensions too in the same generic 
way?
  
  Currently CI crawls all the repository looking for a `selenium-test` npm 
script and blindly run all of them serially.  If I understand your intent we 
would need a second entry point that would be invoked solely for the repository 
that triggered the patch?  We have a similar system for PHPUnit so that run 
tests of a repository marked `@group Standalone` solely for a change that 
targets that repository.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: toan, Michael, Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, 
Jdforrester-WMF, hashar, Aklapper, 786, TheReadOnly, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Peteosx1x, Alter-paule, 
Beast1978, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, 
Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[Addshore]

Addshore added a comment.


  I have a suspicion that we would not want to split out `client/data-bridge` 
tests.
  data-bridge integrated directly with MediaWiki and should be gated, the 
browser tests cover this integration.
  
  `termbox` could be a better candidate to split out into a separate job that 
would not run as part of gated jobs as an initial step
  
  I would also propose that we put this firmly in the hands of extensions 
rather than in CI configuration and make some generic commands for use by wmf 
ci such as `ci-selenium-test-gate` and `ci-selenium-test` that we could then 
chop and change what runs as we see fit without needing to change things 
centrally.
  This could perhaps then be used by other extensions too in the same generic 
way?
  
  Something relevant to other complexities highlighted in this task would be 
T97012: [Task] Wikibase defaults should be usable out of the box 


TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Jakob_WMDE, Ladsgroup, Jdforrester-WMF, hashar, 
Aklapper, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, 
darthmon_wmde, Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Liudvikas, Scott_WUaS, thcipriani, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar moved this task from INBOX to Next on the Release-Engineering-Team board.
hashar edited projects, added Release-Engineering-Team (Next); removed 
Release-Engineering-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

WORKBOARD
  https://phabricator.wikimedia.org/project/board/20/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Jakob_WMDE, Ladsgroup, Jdforrester-WMF, hashar, Aklapper, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Liudvikas, 
Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[gerritbot]

gerritbot added a comment.


  Change 676107 had a related patch set uploaded (by Hashar; author: Hashar):
  
  [integration/config@master] jjb: Provide 'client' and 'repo' Wikibase 
selenium jobs
  
  https://gerrit.wikimedia.org/r/676107

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jakob_WMDE, Ladsgroup, Jdforrester-WMF, hashar, Aklapper, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Mgagat, Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Liudvikas, 
Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[hashar]

hashar added a comment.


  I have renamed the bridge Jenkins job to client.  Amended the configuration 
to run `extensions/Wikibase/build/jenkins/mw-apply-wb-settings.sh` with either 
`-r client` or `-r repo`.
  
  `selenium-test:repo`
  
  
  
https://integration.wikimedia.org/ci/job/wikibase-selenium-repo-docker/5/console
  
  Spec Files:5 passed, 4 failed, 9 total
  
  termbox ones are still failing with `element 
(".wb-ui-all-entered-languages-expandable__switch") still not existing after 
1ms`
  
  `selenium-test:bridge`
  ==
  
  
https://integration.wikimedia.org/ci/job/wikibase-selenium-client-docker/5/console
  
  Spec Files:0 passed, 7 failed, 7 total
  
  The specs now fail with:
  
  counterexample
Error: badvalue: Unrecognized value for parameter "action": wbeditentity.
  
  The top of `LocalSettings.php` has:
  


TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Ladsgroup, Jdforrester-WMF, hashar, Aklapper, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Mgagat, 
Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Liudvikas, 
Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T287582

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Ladsgroup, Jdforrester-WMF, hashar, Aklapper, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Mgagat, 
Akuckartz, Totolinototo3, Hook696, darthmon_wmde, Kent7301, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Liudvikas, 
Scott_WUaS, thcipriani, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org