[Wikidata-bugs] [Maniphest] T301004: Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar

[Aklapper]

Aklapper removed cscott as the assignee of this task.
Aklapper added a comment.


  @cscott: Removing task assignee as this open task has been assigned for more 
than two years - see the email sent to all task assignees on 2024-04-15.
  Please assign this task to yourself again if you still realistically [plan 
to] work on this task - it would be welcome! :)
  If this task has been resolved in the meantime, or should not be worked on by 
anybody ("declined"), please update its task status via "Add Action…  Change 
Status".
  Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for 
tips how to best manage your individual work in Phabricator. Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T301004

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aklapper
Cc: Tacsipacsi, Aklapper, cscott, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
DAlangi_WMF, Akuckartz, Dringsim, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Jrf, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
ssastry, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T301004: Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar

[Tacsipacsi]

Tacsipacsi added a comment.


  As far as I see, it’s executed at most once per parse (assuming that 
ContentAlterParserOutput 
 is 
called at most once), so it should be safe to continue using 
`ParserOutput::setExtensionData`. (It sets an array, but in one pass. And the 
order matters, which is not guaranteed if the set behavior of 
`ParserOutput::appendExtensionData` is taken seriously.)

TASK DETAIL
  https://phabricator.wikimedia.org/T301004

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cscott, Tacsipacsi
Cc: Tacsipacsi, Aklapper, cscott, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
DAlangi_WMF, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Nirmos, Jrf, Cwek, Wikidata-bugs, aude, Dinoguy1000, ssastry, Arlolra, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T301004: Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T301004

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cscott, Maintenance_bot
Cc: Aklapper, cscott, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Jrf, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
ssastry, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T301004: Use OutputPage::appendExtensionData for wikibase-otherprojects-sidebar

[cscott]

cscott created this task.
cscott added projects: MediaWiki-Parser, Patch-For-Review, Parsoid, 
MediaWiki-extensions-WikibaseClient.
Restricted Application removed a project: Patch-For-Review.

TASK DESCRIPTION
  As evidenced in SidebarHookHandlerTest, wikibase uses ::setExtensionData for 
the `wikibase-otherprojects-sidebar` data.  This should probably use 
`::appendExtensionData` instead, to avoid destructive updates (see parent task 
for rationale).

TASK DETAIL
  https://phabricator.wikimedia.org/T301004

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: cscott
Cc: Aklapper, cscott, Akuckartz, lucamauri, JJMC89, Nirmos, Jrf, Cwek, 
Wikidata-bugs, Dinoguy1000, ssastry, Arlolra, Jackmcbarn
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org