[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[WMDE-leszek]

WMDE-leszek added a comment.


  Regarding "filtering commits" - not sure if you want to keep in this task
  
  I've gone into a rabbit hole of sorts and didn't get a success yet:
  
  - git rebase commands that are the last of bringing changes from 
lib/packages/wikibase/data-mode to wmde/WikibaseDataModel fail to apply the 
commit 0d18f39caeac755b8509ef4951a2b329eba0c807 

 "EntityId: Remove Serializable interface and methods"
  - I seem to be able to reproduce this rebase failure and am moderately 
convinced it is because git rebase command somehow manages to miss the commit 
somewhere before the above one 4bcc371c75cd640f933fd2717b664b78c5a0d5b6 

 "Restore "EntityId: Hard-deprecate Serializable methods""
  - it seems to make sense that the Remove serializable.. commit fails to apply 
cleanly if the state of the branch misses changes from "Restore hard deprecate" 
as the latter touched many of the files the former, newer commit changes too
  - I managed to have a successful git rebase run if I manually (via 
interactive rebase) force git to include commit "restore hard depracate" before 
the other one
  - That said, success is not there as I have failed so far to:
- fully understand why git rebase ignores one commit. It looks it might be 
something related to how rebase and git reverting commits interplay but no 
clean outcome to this thread yet
- have a non-interactive git rebase command that could possibly be used in 
the CI to overcome the current challenge.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, 
Tarrow, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I guess we can keep using this task, but if it was previously prioritized for 
just the last AC, we need to reprioritize it again. (But my impression is that 
it wasn’t really prioritized at all, at least not after the workflow was fixed 
last time.)
  
  Comparing the history of lib/packages/wikibase/data-model in Wikibase 

 and the history of wmde/WikibaseDataModel 
,
 I notice that both of them have “Remove obsolete comments and enable 
FunctionComment.WrongStyle sniff”, but after that, WikibaseDataModel jumps 
directly to “Drop reimplementations of is_iterable() & iterator_to_array()”, 
somehow skipping “EntityId: Remove Serializable interface and methods” and 
“EntityId: Assert valid serialization in unserialize()”. I don’t know how this 
could’ve happened (I don’t remember us force-pushing anything in Wikibase), but 
I think we might have to force-push WikibaseDataModel to resolve this 

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, 
Tarrow, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Michael]

Michael added a comment.


  This broke again two months ago  (failing action 
,
 gerrit commit 
).
  
  Now the error is different - merge conflicts:
  
  counterexample
Auto-merging RELEASE-NOTES.md
CONFLICT (content): Merge conflict in RELEASE-NOTES.md
Auto-merging src/Entity/ItemId.php
CONFLICT (content): Merge conflict in src/Entity/ItemId.php
Auto-merging src/Entity/NumericPropertyId.php
CONFLICT (content): Merge conflict in src/Entity/NumericPropertyId.php
Auto-merging tests/unit/Entity/EntityIdTest.php
Auto-merging tests/unit/Entity/EntityIdValueTest.php
Auto-merging tests/unit/Entity/ItemIdTest.php
CONFLICT (content): Merge conflict in tests/unit/Entity/ItemIdTest.php
Auto-merging tests/unit/Entity/NumericPropertyIdTest.php
CONFLICT (content): Merge conflict in 
tests/unit/Entity/NumericPropertyIdTest.php
Rebasing (1/1)
error: could not apply 293be2693e... EntityId: Remove Serializable 
interface and methods
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm ", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git 
rebase --abort".
Could not apply 293be2693e... EntityId: Remove Serializable interface and 
methods
  
  Not sure if we should open a new task for this or uncheck the ACs here. But I 
am noting that this task's AC for the email notification is still unfulfilled, 
which is why we did not notice this for two months. 﫤

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, 
Tarrow, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[darthmon_wmde]

darthmon_wmde removed a project: Wikibase Suite Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: darthmon_wmde
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, 
Tarrow, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, RickiJay-WMDE, 
roti_WMDE, jdfraine
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[darthmon_wmde]

darthmon_wmde removed a project: [DEPRECATED] wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: darthmon_wmde
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, Michael, 
Tarrow, RickiJay-WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, roti_WMDE, 
Themindcoder, Adamm71, Jersione, jdfraine, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Michael]

Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Michael]

Michael added a comment.


  In T314987#8668559 , 
@Lucas_Werkmeister_WMDE wrote:
  
  >>> double check if any commits were missed while it was broken and if so, 
push them to the respective places
  >>
  >> Did we do this?
  >
  > I looked at the history of some of the repositories and saw new commits 
there; I don’t think a thorough check of all commits is needed: the action 
pushes the full history, not just the latest commit. On wmde/WikibaseDataModel 
 a lot of commits got 
pushed, at least:
  > F36894349: image.png 
  >
  > Let’s tag the Suite then.
  
  Ah, I wasn't aware that this is how it works. Yeah, then I'll consider that 
AC met.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Winston_Sung]

Winston_Sung added a comment.


  In T314987#8667970 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > It’s finally working again.
  > F36893928: image.png 
  
  Perfect! Thanks.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Winston_Sung
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a project: Wikibase Suite.
Lucas_Werkmeister_WMDE added a comment.


  >> double check if any commits were missed while it was broken and if so, 
push them to the respective places
  >
  > Did we do this?
  
  I looked at the history of some of the repositories and saw new commits 
there; I don’t think a thorough check of all commits is needed: the action 
pushes the full history, not just the latest commit. On wmde/WikibaseDataModel 
 a lot of commits got 
pushed, at least:
  F36894349: image.png 
  
  Let’s tag the Suite then.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Michael]

Michael added a comment.


  > double check if any commits were missed while it was broken and if so, push 
them to the respective places
  
  Did we do this?
  
  > Should we keep the task open for the email notification AC, or close it?
  
  I'll probably add a #wikibase_suite 
 tag and leave it open, 
as I don't really feel like that this is my call to make. Maybe once they 
actually have developers, then they can decide what they want to happen here. 
But if anyone already has strong feelings on this, then I'm not blocking any 
resolution here either.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  It’s finally working again.
  F36893928: image.png 
  
  Should we keep the task open for the email notification AC, or close it?

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[gerritbot]

gerritbot added a comment.


  Change 894589 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Bump 
wmde/git-monorepo-splice-docker-action from v1 to v2
  
  https://gerrit.wikimedia.org/r/894589

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[gerritbot]

gerritbot added a comment.


  Change 894589 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Bump 
wmde/git-monorepo-splice-docker-action from v1 to v2
  
  https://gerrit.wikimedia.org/r/894589

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Also https://github.com/wmde/git-monorepo-splice-docker-action/pull/2.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[gerritbot]

gerritbot added a comment.


  Change 894538 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Bump 
wmde/git-filter-repo-docker-action from v1 to v2
  
  https://gerrit.wikimedia.org/r/894538

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[gerritbot]

gerritbot added a comment.


  Change 894538 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Bump 
wmde/git-filter-repo-docker-action from v1 to v2
  
  https://gerrit.wikimedia.org/r/894538

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Winston_Sung]

Winston_Sung added a comment.


  (Reminder: GitHub pull request approved but haven't merge.)

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Winston_Sung
Cc: Winston_Sung, hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, 
Michael, Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, Michael, 
Tarrow, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Should be fixed by PR #2 to the git-filter-repo-docker-action 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: hoo, Lucas_Werkmeister_WMDE, Addshore, WMDE-leszek, Aklapper, Michael, 
Tarrow, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, WMDE-leszek, Aklapper, Michael, Tarrow, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T314987: Wikibase GitHub workflow that extracts library commits is broken

[Michael]

Michael created this task.
Michael added projects: wdwb-tech, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Steps to replicate the issue** (include links if applicable):
  
  - Go to 
https://github.com/wikimedia/Wikibase/actions/workflows/filterCommits.yml
  
  **What happens?**:
  
  Everything is red.
  
  **What should have happened instead?**:
  Everything is green and does the job it is supposed to do.
  
  **Background**:
  
  This GitHub workflow was created in context of T289040: Migrate DataModel, 
DataModelServices, DataModelSerialization, WBInternalSerialization to 
Wikibase.git . It is "extracting 
out" commits that relate to standalone packages in the Wikibase monorepo and 
pushing them to read-only repositories for that standalone component.
  
  Source for this workflow: 
https://github.com/wikimedia/Wikibase/blob/master/.github/workflows/filterCommits.yml
  
  It might have been broken by a change to Git itself: 
https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9
  
  (Thank You to @Tarrow for helping me to figure out what might be going on 
here.)
  
  **Acceptance Criteria**:
  
  [ ] make that workflow work again
  [ ] double check if any commits were missed while it was broken and if so, 
push them to the respective places
  [ ] add some kind of email-notification or something, so that we notice when 
these jobs break again

TASK DETAIL
  https://phabricator.wikimedia.org/T314987

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Tarrow, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org