[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-10-18 Thread kostajh 
kostajh closed this task as "Resolved".
kostajh claimed this task.
kostajh added a comment.


  Thanks @Lucas_Werkmeister_WMDE!

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Lucas_Werkmeister_WMDE, kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, 
karapayneWMDE, Invadibot, caldera, Universal_Omega, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-10-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I think we can probably close this task? The specific circular service error 
doesn’t happen at the moment as far as I’m aware, and while it occasionally 
(and seemingly almost at random) pops up again, I don’t think having this task 
open in various backlogs is very useful.
  
  (For anyone else encountering these errors: as far as I can tell, the 
successful mitigation strategy seems to be to look at related test code and 
find some “integrated” MediaWiki objects that can be replaced by simpler mocks.)

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, 
karapayneWMDE, Invadibot, caldera, Universal_Omega, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-09-16 Thread kostajh 
kostajh edited projects, added Growth-Team; removed Growth-Team (Current 
Sprint).
kostajh added a comment.


  Not happening anymore, as far as I know, so removing from our current sprint.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331, IdtrA, 94rain
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-09-06 Thread Urbanecm_WMF 
Urbanecm_WMF added a comment.


  In T315489#8212560 , @Tgr 
wrote:
  
  > A new, similar CI break:
  >
  >   18:24:47 1) 
Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenNotArrayOfCallbacks_throwsException
 with data set #0 (array(null))
  >   18:24:47 Wikimedia\Services\RecursiveServiceDependencyException: 
Recursive service instantiation: Circular dependency when creating service! 
JobQueueGroupFactory -> MainWANObjectCache -> UserNameUtils -> TitleParser -> 
_MediaWikiTitleCodec -> InterwikiLookup -> MainWANObjectCache
  >
  > The dependency circle is different but it is again caused by 
`Session::__destruct()` being invoked at some random place (here 
,
 apparently, which makes even less sense than the previous instance).
  
  Attaching CI's output 

 and patch 

 (@Tgr, please correct me if this is incorrect).

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm_WMF
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-09-05 Thread Tgr 
Tgr added a comment.


  A new, similar CI break:
  
18:24:47 1) 
Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenNotArrayOfCallbacks_throwsException
 with data set #0 (array(null))
18:24:47 Wikimedia\Services\RecursiveServiceDependencyException: Recursive 
service instantiation: Circular dependency when creating service! 
JobQueueGroupFactory -> MainWANObjectCache -> UserNameUtils -> TitleParser -> 
_MediaWikiTitleCodec -> InterwikiLookup -> MainWANObjectCache
  
  The dependency circle is different but it is again caused by 
`Session::__destruct()` being invoked at some random place (here 
,
 apparently, which makes even less sense than the previous instance).

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread kostajh 
kostajh removed kostajh as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, ReleaseTaggerBot
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread Urbanecm_WMF 
Urbanecm_WMF lowered the priority of this task from "Unbreak Now!" to "Needs 
Triage".
Urbanecm_WMF added a comment.


  Bandaid fix was merged, and CI is no longer broken: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/819657.
 Resetting priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, Urbanecm_WMF
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread gerritbot 
gerritbot added a comment.


  Change 825297 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] EntityLinkFormatterFactoryTest: Use 
mock for language
  
  https://gerrit.wikimedia.org/r/825297

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread Urbanecm_WMF 
Urbanecm_WMF removed a parent task: T315516: [regression-wmf.25] mobile: 
Structured Add link task displays "Page is protected, abandoning structured 
task" for non-protected pages.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, Urbanecm_WMF
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread kostajh 
kostajh raised the priority of this task from "High" to "Unbreak Now!".
kostajh added a comment.


  In T315489#8174478 , 
@WMDE-leszek wrote:
  
  > @kostajh shouldn't it even be Unbreak Now? As it essentially blocks your 
work as I understand it?
  
  Yeah, I think that's right.
  
  > Thanks for the Wikibase patch, asking WMDE engineers to have a look today 
if still feasible. Feel free to merge it by your team if we do not get to it 
quickly enough. We can always revert and redo it, no reason to block your team.
  
  Thanks! We might merge it and a more comprehensive fix could come later from 
one of our teams.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331, RhinosF1
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread WMDE-leszek 
WMDE-leszek added a comment.


  @kostajh shouldn't it even be Unbreak Now? As it essentially blocks your work 
as I understand it?
  Thanks for the Wikibase patch, asking WMDE engineers to have a look today if 
still feasible. Feel free to merge it by your team if we do not get to it 
quickly enough. We can always revert and redo it, no reason to block your team.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, WMDE-leszek
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread kostajh 
kostajh moved this task from Incoming to Code Review on the Growth-Team 
(Current Sprint) board.
kostajh claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3450/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, 
caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, 
DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread gerritbot 
gerritbot added a comment.


  Change 825297 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/extensions/Wikibase@master] EntityLinkFormatterFactoryTest: Use 
mock for language
  
  https://gerrit.wikimedia.org/r/825297

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, 
karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, NavinRizwi, ItamarWMDE, 
Akuckartz, 94rain, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread kostajh 
kostajh triaged this task as "High" priority.
kostajh added a comment.


  Blocking patches for #growthexperiments 
 so upping the 
priority for our team.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, 
karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, NavinRizwi, ItamarWMDE, 
Akuckartz, 94rain, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-22 Thread kostajh 
kostajh edited projects, added Growth-Team (Current Sprint); removed 
Growth-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, 
karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, NavinRizwi, ItamarWMDE, 
Akuckartz, 94rain, DannyS712, Nandana, kostajh, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Tgr 
Tgr added a comment.


  I guess the nice thing to would be to properly dependency-inject UserNameInfo 
into SessionBackend, so what dependency loading order we end with does not 
depend on when session saving happens to be triggered.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, 
caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, 
kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, 
LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Tgr 
Tgr added a project: ci-test-error (WMF-deployed Build Failure).

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, 
caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, 
kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, 
LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Tgr 
Tgr removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, 
caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, kostajh, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, 
geraki, Mbch331, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Urbanecm_WMF 
Urbanecm_WMF added a comment.


  I added tasks with patches blocked by this issue as parent tasks of this one, 
so this is tracked.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm_WMF
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Urbanecm_WMF 
Urbanecm_WMF added a parent task: T314414: Grant  "enrollasmentor" right 
automatically according to community's specifications.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm_WMF
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Urbanecm_WMF 
Urbanecm_WMF added a parent task: T312842: 
[[MediaWiki:Growthexperiments-manage-mentors-remove-mentor-pretext/nl]] 
translation issue.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm_WMF
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Urbanecm_WMF 
Urbanecm_WMF added a parent task: T315516: [regression-wmf.25] mobile: 
Structured Add link task displays "Page is protected, abandoning structured 
task" for non-protected pages.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm_WMF
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Lydia_Pintscher 
Lydia_Pintscher added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread gerritbot 
gerritbot added a comment.


  Change 824293 **abandoned** by Gergő Tisza:
  
  [mediawiki/extensions/GrowthExperiments@master] [DNM] CI test
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/824293

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Tgr 
Tgr added a comment.


  Also, why is this affecting a single testcase in a single test file 
?
 It doesn't seem to be doing anything special, and plenty of other tests call 
`Language::factory` without breaking.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread Tgr 
Tgr added a comment.


  What a mess. The test calls `Language::factory`, which needs NamespaceInfo, 
which tries to initialize a bunch of configuration settings. Somehow something 
inside `new ServiceOptions( NamespaceInfo::CONSTRUCTOR_OPTIONS, 
$services->getMainConfig() )` triggers session handling (no idea how that would 
happen, and the stack trace doesn't tell anything about that). When exiting the 
method, the session destructor is called. The session is dirty (which I think 
shouldn't happen at this point, but then this is a unit test so who knows how 
many components behave in unusual ways) and validates the user's name, which 
requires UserNameUtils, which needs the content language, which would be 
created by the language factory.
  
  Why does that standard-looking ServiceOptions call trigger session handling, 
when a pretty much identical call in the LanguageFactory wiring doesn't? And 
what does any of it have to with the GrowthExperiments extension? Seems 
mystical to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-18 Thread gerritbot 
gerritbot added a comment.


  Change 824293 **restored** by Gergő Tisza:
  
  [mediawiki/extensions/GrowthExperiments@master] [DNM] CI test
  
  https://gerrit.wikimedia.org/r/824293

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, 
caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, kostajh, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, 
geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, 
caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, kostajh, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, 
Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, 
geraki, Mbch331, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, 
QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread Tgr 
Tgr added a comment.


  So it seems EarlyLifeCycleHooks is somehow causing this or contributing to 
it. Presumably because it adds a UserOptionsLookup dependency to 
language-related things (more specifically anything that would do message 
loading during initialization), but then why doesn't UserOptionsLookup appear 
in the dependency chain? And none of the constructors of the services indicated 
in the error do anything that would trigger the MessageCache__get hook.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, 786, Sgs, Biggs657, 
caldera, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, kostajh, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Gq86, Af420, Bsandipan, Nattes, Lewizho99, 
Maathavan, Iniquity, Taiwania_Justo, Neuronton, Wikidata-bugs, geraki
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread gerritbot 
gerritbot added a comment.


  Change 824293 **abandoned** by Gergő Tisza:
  
  [mediawiki/extensions/GrowthExperiments@master] [DNM] CI test
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/824293

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, 786, Sgs, Biggs657, 
caldera, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, kostajh, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Gq86, Af420, Bsandipan, Nattes, Lewizho99, 
Maathavan, Iniquity, Taiwania_Justo, Neuronton, Wikidata-bugs, geraki
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, 786, Sgs, Biggs657, 
caldera, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, kostajh, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Gq86, Af420, Bsandipan, Nattes, Lewizho99, 
Maathavan, Iniquity, Taiwania_Justo, Neuronton, Wikidata-bugs, geraki
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread gerritbot 
gerritbot added a comment.


  Change 824293 had a related patch set uploaded (by Gergő Tisza; author: Gergő 
Tisza):
  
  [mediawiki/extensions/GrowthExperiments@master] [DNM] CI test
  
  https://gerrit.wikimedia.org/r/824293

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Urbanecm_WMF, Aklapper, Tgr, Sgs, caldera, NavinRizwi, ItamarWMDE, 
Akuckartz, kostajh, lucamauri, Gq86, Nattes, Iniquity, Taiwania_Justo, 
Wikidata-bugs, geraki
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

2022-08-17 Thread Tgr 
Tgr created this task.
Tgr added projects: MediaWiki-extensions-WikibaseRepository, GrowthExperiments.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Growth-Team.

TASK DESCRIPTION
  Breaks CI for all patches in GrowthExperiments at least. Example: 
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php73-noselenium-docker/56960/console
  
10:26:38 1) 
Wikibase\Repo\Tests\Hooks\Formatters\EntityLinkFormatterFactoryTest::testGivenSameTypeAndLanguage_getLinkFormatterCachesResult
10:26:38 Wikimedia\Services\RecursiveServiceDependencyException: Recursive 
service instantiation: Circular dependency when creating service! 
LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> 
LanguageFactory
10:26:38 
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:435
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411
10:26:38 /workspace/src/includes/MediaWikiServices.php:299
10:26:38 /workspace/src/includes/MediaWikiServices.php:1117
10:26:38 /workspace/src/includes/ServiceWiring.php:450
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411
10:26:38 /workspace/src/includes/MediaWikiServices.php:299
10:26:38 /workspace/src/includes/MediaWikiServices.php:853
10:26:38 /workspace/src/includes/ServiceWiring.php:2047
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411
10:26:38 /workspace/src/includes/MediaWikiServices.php:299
10:26:38 /workspace/src/includes/MediaWikiServices.php:1922
10:26:38 /workspace/src/includes/session/SessionBackend.php:765
10:26:38 /workspace/src/includes/session/SessionBackend.php:236
10:26:38 /workspace/src/includes/session/Session.php:75
10:26:38 /workspace/src/includes/ServiceWiring.php:1131
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411
10:26:38 /workspace/src/includes/MediaWikiServices.php:299
10:26:38 /workspace/src/includes/MediaWikiServices.php:1320
10:26:38 /workspace/src/includes/ServiceWiring.php:803
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
10:26:38 
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411
10:26:38 /workspace/src/includes/MediaWikiServices.php:299
10:26:38 /workspace/src/includes/MediaWikiServices.php:1117
10:26:38 /workspace/src/includes/language/Language.php:299
10:26:38 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/Formatters/EntityLinkFormatterFactoryTest.php:59
10:26:38 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:498
  
  At a glance patches for other extensions seem to be passing so maybe this is 
somehow specific to GrowthExperiments. It is possible for one extension to 
interfere with another's tests via hooks, but it's not obvious to be how this 
would be happening here.

TASK DETAIL
  https://phabricator.wikimedia.org/T315489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Aklapper, Tgr, Sgs, caldera, NavinRizwi, ItamarWMDE, Akuckartz, kostajh, 
lucamauri, Gq86, Nattes, Iniquity, Taiwania_Justo, Wikidata-bugs, geraki
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org