[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-09-04 Thread Krinkle 
Krinkle closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Astuthiodit_1, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-31 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Maintenance_bot
Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Astuthiodit_1, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-31 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, ReleaseTaggerBot
Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, 
aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-31 Thread gerritbot 
gerritbot added a comment.


  Change 827502 **merged** by jenkins-bot:
  
  [mediawiki/core@master] rdbms: Convert SQLite values to string
  
  https://gerrit.wikimedia.org/r/827502

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, gerritbot
Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread CtrlZvi 
CtrlZvi added a comment.


  I wonder if there's benefit in migrating the MySQL and PostgreSQL 
implementations to PDO? That would probably resolve the issue where they return 
strings and unify behavior. I suspect it might be at the expense of 
performance, though?

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, CtrlZvi
Cc: Krinkle, CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread CtrlZvi 
CtrlZvi added a comment.


  I agree 100% with using the not being coupled to strings and using the native 
integer types. It seems like a positive change for a whole host of reasons. But 
that's a much larger change in a system I don't have experience in, and my 
experiments with trying to support both the strings returned by MySQL and 
PostgreSQL and the integers returned by SQLite were not successful.
  
  In the specific case I found in Wikibase, the complexity comes from taking 
the results and using them as keys in an associative array, which autocasts 
returned strings to integer, then taking those keys and comparing them to what 
comes from the database in a type sensitive way. MySQL and PostgreSQL require 
the cast back into string for that comparison, SQLite requires no cast. If 
that's the only place that's sensitive like that, a local workaround could be 
used, but I'm assuming if there's one place that breaks, there are others, too.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, CtrlZvi
Cc: Krinkle, CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread aaron 
aaron added a comment.


  I don't think wikibase, or MediaWiki code generally, should be so tightly 
coupled to the driver returning strings.
  
  Ideally, I somewhat prefer using native PHP integers...but the our 
sqlite/mysql/postgres Database subclasses should be consistent. We can possibly 
use ATTR_STRINGIFY_FETCHES for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron
Cc: Krinkle, CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread Krinkle 
Krinkle moved this task from Inbox to Backlog: Maintenance on the 
Performance-Team board.
Krinkle assigned this task to aaron.
Krinkle added a comment.


  Thanks. We'll review the patch and backport to stable REL branches.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1212/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron, Krinkle
Cc: Krinkle, CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, 
aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread gerritbot 
gerritbot added a comment.


  Change 827502 had a related patch set uploaded (by CtrlZvi; author: CtrlZvi):
  
  [mediawiki/core@master] rdbms: Convert SQLite values to string
  
  https://gerrit.wikimedia.org/r/827502

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: CtrlZvi, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, waldyrious, 
Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-28 Thread CtrlZvi 
CtrlZvi added a project: MediaWiki-libs-Rdbms.
CtrlZvi added a comment.
Restricted Application added a project: Performance-Team.


  Although discovered with Wikibase, this is not actually a Wikibase issue. PHP 
8.1 introduces a breaking change into the SqliteResultWrapper. Leaving the 
Wikibase tags for now in case there's a local workaround that's preferred, but 
I think I now have an idea of how to fix this at the core level and hope to 
have a patch soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CtrlZvi
Cc: CtrlZvi, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Rayssa-, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, waldyrious, 
Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-28 Thread CtrlZvi 
CtrlZvi added a comment.


  Digging a bit more, the type mismatch comes from loading the wbt_type table 
into the cache using the NameTableStore::loadTable() function. This function 
stores the returned values into an associative array by their key, and although 
PostgreSQL, MySQL, and SQLite prior to PHP 8.1 returned the ids as strings, the 
use of them as keys in the associate array results in them being cast to int 
. This is almost 
certainly why DatabaseTermInLangIdsAcquirer::acquireTermInLangIdsInner was 
casting back to a string.
  
  It seems like this might be caused by using PDO for SQLite and not the 
SQLite3 type, though I don't know if that type would return strings or not.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CtrlZvi
Cc: CtrlZvi, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-28 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T316487

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: CtrlZvi, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org