[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-04-11 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  As far as I can tell, this has been fixed with the above Gerrit changes.

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-02-01 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Adamm71, Jersione, Hellket777, LisafBia6531, 786, 
Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-02-01 Thread gerritbot 
gerritbot added a comment.


  Change 884356 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Don’t require wikibase.desktop 
module
  
  https://gerrit.wikimedia.org/r/884356

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-02-01 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-02-01 Thread gerritbot 
gerritbot added a comment.


  Change 884355 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Move itemlink styles to 
wikibase.alltargets
  
  https://gerrit.wikimedia.org/r/884355

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-30 Thread Nikki 
Nikki added a comment.


  Not related to mobile but T291817  
is another place where the indicators are still being shown

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-27 Thread gerritbot 
gerritbot added a comment.


  Change 884356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexeme@master] Don’t require wikibase.desktop 
module
  
  https://gerrit.wikimedia.org/r/884356

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-27 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-27 Thread gerritbot 
gerritbot added a comment.


  Change 884355 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Move itemlink styles to 
wikibase.alltargets
  
  https://gerrit.wikimedia.org/r/884355

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-27 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Another part of `wikibase.common` that gets lost on mobile is that the entity 
ID part of an entity link (“Douglas Adams (Q42)”) is shown in a slightly 
smaller font. I don’t think this is worth a separate Phabricator task, it’s 
just another bit of CSS that should be moved to the “all targets” module at the 
same time.

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328150: Language fallback indicators still shown for variant fallbacks on mobile Wikidata

2023-01-27 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Mobile, 
MediaWiki-extensions-WikibaseView.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a mobile Wikidata visitor, I don’t want to see language fallback 
indicators if the fallback is just within language variants, e. g. from British 
or Canadian English (`en-gb`, `en-ca`) to “English” (`en`).
  
  **Problem:**
  Language fallback indicators for variant fallbacks are hidden on desktop 
(implemented in T174318  and since 
then fixed in a few more places), but not on mobile. The relevant styles are 
currently in the desktop-only `wikibase.common` ResourceLoader module.
  
  **Tech note:** T325084  splits 
`wikibase.common` into two modules; the styles that hide variant fallback 
indicators should then move from `wikibase.desktop` to `wikibase.alltargets`. 
This also means that a bunch of places can stop loading the more heavyweight 
`wikibase.desktop` module – history views, Special:NewLexeme etc. only need the 
link styles from `wikibase.alltargets`.
  
  **Example:**
  This en-ca mobile item view 
 or this en-ca mobile diff 
 shows 
the indicators for the fallback from Canadian English to English:
  F36525577: image.png 
  F36525574: image.png 
  
  **Screenshots/mockups:**
  
  **BDD**
  GIVEN I am looking at the mobile version of the site
  AND my user interface language is a “variant” language
  WHEN looking at item links where the label fell back to the “base” language
  THEN there is no visible fallback indicator
  
  **Acceptance criteria:**
  
  - Language fallback indicators for variant fallbacks aren’t shown on mobile.
  - Language fallback indicators for //non//-variant fallbacks are still shown 
everywhere, of course.
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T328150

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org