[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, bwang, 
Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, LawExplorer, 
Flycatchr, Zppix, _jensen, rosalieper, Scott_WUaS, Volker_E, Izno, freephile, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Sarai-WMDE]

Sarai-WMDE closed this task as "Resolved".
Sarai-WMDE claimed this task.
Sarai-WMDE added a comment.


  The patch was merged 🎉  Now most icons in Wikidata pages resize nicely if the 
base font size is modified 🔍  Thanks for the great contribution, @Nikki!

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, 
LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, luca.favorido, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, 
KimKelting, LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[gerritbot]

gerritbot added a comment.


  Change #1016776 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use relative sizes for icons
  
  https://gerrit.wikimedia.org/r/1016776

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, luca.favorido, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, 
KimKelting, LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Nikki]

Nikki added a comment.


  I think that patch should fix 2, 3, 5, 6, 7, 9 and 10 from the description.
  
  1 and 4 are the triangular expand/collapse toggle icons. It would be possible 
to override the styles for it on the elements where Wikibase uses it, but I 
didn't include that because I have no idea which file to put it in or if I 
would even be allowed to do that.
  
  It wouldn't be ideal, those icons are PNGs, so scaling them up makes them 
slightly fuzzy. I would argue that it's still be an improvement, because crisp 
edges are not much use to you if it's not big enough for you see what it is.
  
  Here's how it looks scaled up for me with Chrome's "large" and "very large" 
default font sizes (150% and 200% I think):
  F44458726: Bildschirmfoto_2024-04-04_10-02-52.png 
 F44458733: 
Bildschirmfoto_2024-04-04_10-02-31.png 

  
  The rest of the changes are in different repositories (WikibaseLexeme and 
EntitySchema). I can make those use relative sizes too, but the icons in both 
of those extensions are inconsistent with the rest of the site, so if I do, I 
would really like to make them consistent (maybe most people don't notice, but 
//I// do), not just change the units:
  
  The icons for lemmas claim to have been copied from `.wikibase-toolbar-button 
.wb-icon` (link 
),
 but the size and opacity are different (20px instead of 16px, 0.7 opacity 
instead of 0.87).
  
  Screenshots of how the lemma buttons (at the top) and the senses buttons (at 
the bottom) currently look at a normal font size on the same page:
  F44459972: Bildschirmfoto_2024-04-04_10-39-37.png 
 F44459973: 
Bildschirmfoto_2024-04-04_10-39-21.png 

  
  The icons for entity schemas also claim to have been copied from 
`.wikibase-toolbar-button .wb-icon` (link 
)
 but the size, opacity and colour are all different (15px instead of 16px, 0.67 
opacity instead of 0.87, blue instead of black).
  
  Screenshot of how the edit buttons on entity schema pages currently look at a 
normal font size:
  F44460476: Bildschirmfoto_2024-04-04_10-46-23.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, 
LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Lydia_Pintscher]

Lydia_Pintscher added projects: Wikidata Dev Team, Wikidata-UX.

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, 
LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  The above change looks okay to me so far; there are still some icons that 
have the wrong size (most notably, the little “triangle” to collapse or expand 
things like references or the legacy termbox), but those might not be under our 
control (that triangle’s styles come from jQuery UI, shipped with MediaWiki 
core). And overall, the change certainly feels like an improvement already.
  
  @Sarai-WMDE do you have any objections to this?

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, 
Nikki, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, 
S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, 
LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, Nikki, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, 
Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, 
LawExplorer, Flycatchr, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Volker_E, Izno, freephile, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[gerritbot]

gerritbot added a comment.


  Change #1016776 had a related patch set uploaded (by Nikki; author: Nikki):
  
  [mediawiki/extensions/Wikibase@master] Use relative sizes for icons
  
  https://gerrit.wikimedia.org/r/1016776

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, Nikki, 
Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, bwang, 
Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, Orienteerix, KimKelting, LawExplorer, 
Flycatchr, Zppix, _jensen, rosalieper, Scott_WUaS, Volker_E, Izno, freephile, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Lydia_Pintscher]

Lydia_Pintscher added subscribers: Sarai-WMDE, Lydia_Pintscher.
Lydia_Pintscher added a comment.


  Thanks, @Nikki!
  @Sarai-WMDE: FYI

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Sarai-WMDE, Moebeus, Aklapper, Nikki, Astuthiodit_1, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, 
Flycatchr, Zppix, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Nikki]

Nikki added a comment.


  I attempted to find where in the source code the icons are defined:
  
  Wikibase:
  
  - edit, add, publish, cancel and remove icons used when editing terms, 
statements (5), sitelinks (6), senses (9) and forms (10): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.toolbarbutton.css#41
  - help icon for editing terms, statements (5) and sitelinks (6): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/toolbar/themes/default/jquery.wikibase.edittoolbar.css#11
  - rank selector (2): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css#11
  - snak type selector (3): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/jquery/wikibase/snakview/themes/default/snakview.SnakTypeSelector.css#9
  - sitelink badges (7): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/view/resources/wikibase/wikibase.badgedisplay.less#11
  
  WikibaseLexeme:
  
  - edit, publish and cancel icons for lemmas (8): 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/master/resources/lemma-widget.less#48
  
  EntitySchema:
  
  - edit icon for entity schemas (11): 
https://gerrit.wikimedia.org/g/mediawiki/extensions/EntitySchema/+/master/resources/viewSchema.less#6
  
  I couldn't work out where the triangular expand/collapse icons (1, 4) get 
added but the icons themselves seem to be in MediaWiki core.

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Moebeus, Aklapper, Nikki, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, 
Mooeena, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Orienteerix, LawExplorer, Flycatchr, Zppix, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T328387: Interface icons in Wikidata should scale based on the default font size

[Nikki]

Nikki created this task.
Nikki added projects: Wikidata, Accessibility.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Browsers let users adjust the default font size, e.g. for accessibility. 
Interface icons should be relative to the default font size so that they also 
get bigger.
  
  There are a number of places in the Wikidata interface where that does not 
happen. This includes:
  
  1. the triangular expand/collapse toggle icon for "In more languages"
  2. the statement rank icon
  3. the icon for selecting novalue, somevalue or custom value for statements
  4. the triangular expand/collapse toggle icon for references
  5. edit, add, publish, remove, cancel, help icons when editing statements
  6. edit, publish, cancel, help and remove icons when editing sitelinks
  7. sitelink badges
  8. edit, publish and cancel icons when editing lemmas
  9. edit, add, publish, remove and cancel icons when editing senses
  10. edit, add, publish, cancel, help and remove icons when editing forms
  11. edit icons when editing entity schemas
  
  Screenshots from Firefox with the default font size set to 32:
  
  1
  F36563004: inmorelanguages.png 
  
  2-5
  F36563006: statement.png 
  
  6
  F36563001: sitelinks.png 
  
  7
  F36563000: sitelink-badges.png 
  
  8
  F36563008: lemma-edit-2.png 
  F36563009: lemma-edit.png 
  
  9
  F36563016: sense-add-3.png 
  
  10
  F36563012: form.png 
  F36563020: form-2.png 
  
  11
  F36562998: entityschema.png 
  
  Pages used in these examples:
  
  - https://www.wikidata.org/wiki/Q97858392 (1-6)
  - https://www.wikidata.org/wiki/Q4540988 (7)
  - https://www.wikidata.org/wiki/Lexeme:L94183 (8, 10)
  - https://www.wikidata.org/wiki/Lexeme:L20980 (9)
  - https://www.wikidata.org/wiki/EntitySchema:E10 (11)

TASK DETAIL
  https://phabricator.wikimedia.org/T328387

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Aklapper, Nikki, Astuthiodit_1, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, Orienteerix, LawExplorer, Flycatchr, Zppix, _jensen, rosalieper, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org