[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Arian_Bozorg]

Arian_Bozorg closed subtask T356775: [MSMF] Set up a reliable benchmark to 
measure upload resources for 250 Mismatches as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Arian_Bozorg
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Arian_Bozorg]

Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata 
Dev Team (Quality Tools "Sprint") board.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Arian_Bozorg
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/880

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[guergana.tzatchkova]

guergana.tzatchkova claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Lydia_Pintscher]

Lydia_Pintscher added a parent task: T356742: inform uploader about the fact 
that we are ignoring reuploads of already reviewed mismatches.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[karapayneWMDE]

karapayneWMDE added a comment.


  In T329631#9096554 , 
@Sarai-WMDE wrote:
  
  > I'd advise for us to find a way to notify users (/uploaders) about which of 
the mismatches were ignored and why (either because they already exist or have 
been previously reviewed). Displaying this in the upload summary, if possible, 
would be a good idea.
  
  Sprint 3 Planning
  from a technical pov, keeping track of individual mismatches would be 
unnecessary overhead. But communicating about the upload is worthwhile and will 
be a separate task

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, 
Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[karapayneWMDE]

karapayneWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, 
Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[noarave]

noarave added a comment.


  During task breakdown a few questions came up. After discussing those with 
Lydia we decided to alter the task scope to skipping previously reviewed 
mismatches on upload. The task description was adjusted accordingly.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, 
Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, 
Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T329631#9505298 , 
@noarave wrote:
  
  > - if the mismatch already exists in the DB in its exact form, for this 
uploader, it is ignored during upload
  > - the existing mismatch gets tagged as "reviewed" in the "review_status" 
column of the csv summary of the upload
  
  These seem to be contradictory.
  We either import and mark as reviewed or we ignore it and don't import the 
particular mismatch. I highly recommend not importing.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, 
Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[noarave]

noarave added subscribers: HasanAkgun_WMDE, noarave.
noarave added a comment.


  Task Breakdown Notes:
  
  - the basic requirement of this is to compare the columns from the imported 
file against previously imported mismatches
  - if the mismatch already exists in the DB in its exact form, for this 
uploader, it is ignored during upload
  - the existing mismatch gets tagged as "reviewed" in the "review_status" 
column of the csv summary of the upload
  - we should make sure all developers have the same access rights to the 
mismatch finder DB and know how to query it
  
  Potential Plan of Action:
  
  - set up a reliable benchmark to measure upload resources for 250 Mismatches. 
This benchmark will be used to compare the performance trade of of this change. 
Subtask to be opened by @HasanAkgun_WMDE
  - The ImportController.php 

 class controls all the services related to the upload (validation, import 
etc.). We could have it call a dedicated service to perform the required 
comparison.
  - All mismatches with status "reviewed" are not to be displayed for review in 
the MSMF results page.
  - Decisions regarding what DB strategy we observe to fit this feature are to 
be made next week.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, HasanAkgun_WMDE, Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, 
Lydia_Pintscher, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[guergana.tzatchkova]

guergana.tzatchkova set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, Lydia_Pintscher, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[guergana.tzatchkova]

guergana.tzatchkova moved this task from Unified QT Backlog to Quality Tools 
"Sprint" on the Wikidata Dev Team board.
guergana.tzatchkova edited projects, added Wikidata Dev Team (Quality Tools 
"Sprint"); removed Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, Lydia_Pintscher, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Arian_Bozorg]

Arian_Bozorg updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, Lydia_Pintscher, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Arian_Bozorg]

Arian_Bozorg added a comment.


  This makes sense to me, in these instances it would make sense here to mark 
them as 'reviewed' in the 'review status' column in the csv.

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Sarai-WMDE, Mike_Peel, Aklapper, Lydia_Pintscher, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Arian_Bozorg]

Arian_Bozorg renamed this task from "[SW] Ignore already reviewed mismatches on 
reupload" to "Ignore already reviewed mismatches on reupload".

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Sarai-WMDE, Mike_Peel, Aklapper, Lydia_Pintscher, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T329631: Ignore already reviewed mismatches on reupload

[Lydia_Pintscher]

Lydia_Pintscher created this task.
Lydia_Pintscher added projects: Mismatch Finder, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a mismatch provider I want the Mismatch Finder to ignore mismatches from 
my previous uploads that have already been reviewed in order to not have to 
remove these mismatches from my upload.
  
  **Problem:**
  Several people have now set up workflows to automate uploading mismatches to 
the Mismatch Finder every x weeks. If a mismatch has been uploaded in week 1 
and is being reviewed in week 2 as being an intentional mismatch it means that 
neither the external source nor Wikidata has been adjusted so the two values 
match. The mismatch will show up again in the next upload in week 3 and will 
have to be reviewed again. This is not a good use of reviewer time.
  Removing the already reviewed mismatches by the mismatch provider is possible 
once T329156  is fixed and they have 
access to the review decisions. However this is additional work we're putting 
on them that should be avoided.
  
  We can solve this issue by simply ignoring mismatches in new uploads that we 
already have marked as reviewed in previous uploads.
  
  **Example:**
  
  **Screenshots/mockups:**
  
  **BDD**
  GIVEN 
  AND 
  WHEN
  AND
  THEN
  AND
  
  **Acceptance criteria:**
  
  [ ] this should only apply to an exact match of the mismatch
  [ ] this should only apply to comparisons between mismatches by the same 
mismatch provider
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T329631

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Mike_Peel, Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org