[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-08-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T337228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Celenduin, Aklapper, hoo, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, 
mrephabricator, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Alilje, Hook696, Nabetaro, Kent7301, joker88john, CucyNoiD, Nandana, 
MSantos, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, 
LawExplorer, Lewizho99, Ddproxy, Maathavan, _jensen, rosalieper, JGirault, 
Neuronton, Scott_WUaS, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, 
Planemad, Wikidata-bugs, aude, awight, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-08-23 Thread gerritbot 
gerritbot added a comment.


  Change 951844 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
author: Thiemo Kreuz (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Render  maps on entity pages 
in preview mode
  
  https://gerrit.wikimedia.org/r/951844

TASK DETAIL
  https://phabricator.wikimedia.org/T337228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: thiemowmde, Celenduin, Aklapper, hoo, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, lucamauri, Lahi, 
Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, 
Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, 
Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, awight, Yurik, 
TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-08-23 Thread thiemowmde 
thiemowmde added a comment.


  @hoo, can you please try setting the ParserOptions in your 
CachingKartographerEmbeddingHandler to be in preview mode? (Or section preview, 
if you prefer.) Not for the entire page but really only for the parsing of the 
`` tag. This will partially disable the problematic static map 
rendering. The thing is: It's impossible to render a static .png map when the 
renderer doesn't have access to the GeoJSON data. Which is the case here 
because the relevant piece of GeoJSON is created dynamically, not stored in the 
expected place, and not available via the `mapdata` query API. It's effectively 
only a "preview". But it's always possible to render a trivial static map based 
on nothing but a pair of coordinates and a zoom factor. This is the current 
no-JS fallback that probably also works on entity pages.
  
  It's also a good idea to test the https://www.wikidata.org/wiki/Q17151#P625 
example page with JavaScript disabled. This way the two bad requests can be 
seen directly as broken images.
  
  I worked a lot on the relevant Kartographer rendering code the past months. 
I'm happy to pair on this one!

TASK DETAIL
  https://phabricator.wikimedia.org/T337228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Celenduin, Aklapper, hoo, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, lucamauri, Lahi, 
Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, 
Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, 
Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, awight, Yurik, 
TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-05-22 Thread hoo 
hoo added a subtask: T337222: Properly inject the page and revision id when 
rendering Kartographer maps.

TASK DETAIL
  https://phabricator.wikimedia.org/T337228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Aklapper, hoo, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, 
lucamauri, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, 
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, 
phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, 
aude, awight, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org

2023-05-22 Thread hoo 
hoo created this task.
hoo added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Maps 
(Kartographer).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  For example on the current version of the Wikidata item for Thessaloniki 
 you can see two requests going to 
`https://maps.wikimedia.org/img/osm-intl,[…].png?lang=en=www.wikidata.org=Special%3ABadtitle%2Fdummy+title+for+API+calls+set+in+api.php=[…]`,
 which results in http 400:
  
"Invalid mapdata response for 
{\"action\":\"query\",\"formatversion\":\"2\",\"titles\":\"Special:Badtitle/dummy
 title for API calls set in 
api.php\",\"prop\":\"mapdata\",\"mpdlimit\":\"max\",\"mpdgroups\":\"_a5b61b56cc6eb2eccf0e4656ef3805aee1181d0e\"}"
  
  The correct page title (Q17151 in this case) should be used here, but 
Wikibase's formatter code prevents us from correctly determining that 
(`RequestContext::getMain()->getTitle()` is used).

TASK DETAIL
  https://phabricator.wikimedia.org/T337228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Aklapper, hoo, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, 
lucamauri, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, 
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, 
phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, 
aude, awight, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org