[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Our work done on 
the Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE set the point value for this task to "3".
Lucas_Werkmeister_WMDE assigned this task to hoo.
Lucas_Werkmeister_WMDE added a comment.


  I think this is done; I estimate at 3 points, feel free to change it.

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-21 Thread karapayneWMDE 
karapayneWMDE added a project: Wikidata Dev Team (Sprint-∞).

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-19 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 
2023-07-25); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-19 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-19 Thread gerritbot 
gerritbot added a comment.


  Change 938237 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] OutputPageBeforeHTMLHookHandler: Don’t 
load full entities
  
  https://gerrit.wikimedia.org/r/938237

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-14 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-14 Thread gerritbot 
gerritbot added a comment.


  Change 938237 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] OutputPageBeforeHTMLHookHandler: Don’t 
load full entities
  
  https://gerrit.wikimedia.org/r/938237

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-07-12 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  No `T340642` warnings in logstash for the past 7 days as far as I can see 
(and Wikidata has also been on wmf.16 for that long, see SAL 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread gerritbot 
gerritbot added a comment.


  Change 934322 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] OutputPageBeforeHTMLHookHandler: Log 
when loading full entities
  
  https://gerrit.wikimedia.org/r/934322

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread hoo 
hoo added a comment.


  In T340642#8973729 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Yeah, I was also wondering if this was still relevant when I looked at it… 
can probably be removed indeed. (Maybe we can first log a warning if it’s 
missing and see if that shows up in logstash?)
  
  Sounds good to me, I've uploaded a patch. Once that has been deployed for a 
while, we should have enough clarity here to be able to remove this code (or 
adopt the comment/ fix the callers).

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-29 Thread gerritbot 
gerritbot added a comment.


  Change 934322 had a related patch set uploaded (by Hoo man; author: Hoo man):
  
  [mediawiki/extensions/Wikibase@master] OutputPageBeforeHTMLHookHandler: Log 
when loading full entities
  
  https://gerrit.wikimedia.org/r/934322

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-28 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Yeah, I was also wondering if this was still relevant when I looked at it… 
can probably be removed indeed. (Maybe we can first log a warning if it’s 
missing and see if that shows up in logstash?)

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, hoo, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T340642: OutputPageBeforeHTMLHookHandler: Remove old fallback for missing OutputPage property

2023-06-28 Thread hoo 
hoo created this task.
hoo added projects: MediaWiki-extensions-WikibaseRepository, Wikidata, 
Technical-Debt.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: wdwb-tech.

TASK DESCRIPTION
  `OutputPageBeforeHTMLHookHandler` retrieves termbox entries for entity pages 
from the OutputPage (see 
`OutputPageBeforeHTMLHookHandler::getEntityTermsListHtml`). If this OutputPage 
property is empty we fall back to retrieving the full entity to extract the 
terms from that.
  `OutputPageBeforeHTMLHookHandler::getEntity` claims that in this case `// The 
parser cache content is too old to contain the terms list items`, but given 
this was added years ago (in 4b52cd637a1 

 in 2016), this surely isn't the case anymore.
  
  To do:
  
  1. Make sure the `wikibase-terms-list-items` property is actually set in all 
relevant cases
  2. Remove the fallback handling from `OutputPageBeforeHTMLHookHandler` and 
`EntityViewPlaceholderExpander`

TASK DETAIL
  https://phabricator.wikimedia.org/T340642

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Aklapper, hoo, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org