[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-10-11 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  樂 
  The general assumption should be valid for all entities, I'd say. I'm not 
sure if I'd enforce this strictly right now instead of just not adding the 
category from this extension. Unless it is significantly easier to do that I'd 
probably not prohibit categories completely for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-10-11 Thread Michael 
Michael added a comment.


  After reading through this for story writing, I wonder if this
  
  In T344577#9152488 , 
@Lydia_Pintscher wrote:
  
  > I'm inclined to not have the categories tbh because it gives the (wrong) 
impression that Item pages can be categorized.
  
  should maybe make us scope this task more like "Make sure Item pages do not 
receive any categories.", instead of focusing on "Pages with maps" in 
particular?
  Would the same be true for Properties and Lexemes as well?
  Should this be true for Wikibases on wikibase.cloud or on premise as well? 
(That is: Should this be configurable?)

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-10-11 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-09-08 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  I'm inclined to not have the categories tbh because it gives the (wrong) 
impression that Item pages can be categorized.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-09-06 Thread hoo 
hoo added a subscriber: thiemowmde.
hoo added a comment.


  I just looked into this and the tracking category should be recorded all the 
time (it's a bug that it's not).
  
  Here's how this happens: `TrackingCategories::resolveTrackingCategory`, which 
is called indirectly via `Parser::addTrackingCategory`, expects to get a 
`$contextPage`. If this passed `$contextPage` is null or a special page it will 
abort (and thus no tracking category will be recorded). In 
`CachingKartographerEmbeddingHandler` we use 
`RequestContext::getMain()->getTitle() ?? Title::makeTitle( NS_SPECIAL, 
'BlankPage' )` to determine the page (which will eventually end up as 
`$contextPage`). As can be seen here, depending on the context of the call, 
this might be the actual page (eg. when purging using 
https://www.wikidata.org/wiki/Q7105617?action=purge) or Special:BlankPage (eg. 
when editing or purging via API).
  
  T337222: Properly inject the page and revision id when rendering Kartographer 
maps  would solve this.
  
  As a stop gap, we could either manually add the category in Wikibase or 
loosen the checks in `TrackingCategories::resolveTrackingCategory`.
  
  If we decide that we don't want to have that tracking category after all, a 
setting could be added to Kartographer to turn it of for Wikidata (or just for 
entity namespaces).

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: thiemowmde, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-29 Thread Lydia_Pintscher 
Lydia_Pintscher removed a subscriber: Wikidata Dev Team.
Lydia_Pintscher added a project: Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g, #wikidata_dev_team
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-29 Thread Lydia_Pintscher 
Lydia_Pintscher removed a project: TestMe.
Lydia_Pintscher added subscribers: hoo, Wikidata Dev Team.
Lydia_Pintscher added a comment.


  Ok after some more poking around: it does show up for me after purging the 
page.
  F37640488: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: #wikidata_dev_team, hoo, Lydia_Pintscher, Izno, Aklapper, Nikki, 
Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g, TerraCodes
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-28 Thread Nikki 
Nikki added a comment.


  In T344577#9121959 , 
@Lydia_Pintscher wrote:
  
  > I just checked and I can not reproduce this anymore. I have hidden 
categories enabled. Can you check again?
  
  That's strange... I still see the category on the item I linked in the 
description, even after purging the page and after making an edit.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Lydia_Pintscher, Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, TerraCodes, 
_jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-27 Thread Lydia_Pintscher 
Lydia_Pintscher added a project: TestMe.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, TerraCodes, 
_jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, 
Planemad, Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-27 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  I just checked and I can not reproduce this anymore. I have hidden categories 
enabled. Can you check again?

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Alilje, Nandana, Lahi, Gq86, Looniverse, 
GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, _jensen, 
rosalieper, JGirault, Scott_WUaS, phabyogi, Susannaanas, lxbarth, Planemad, 
Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-21 Thread Bugreporter 
Bugreporter added a project: Maps.

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, mrephabricator, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Alilje, Nandana, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, 
Orienteerix, LawExplorer, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, 
Susannaanas, lxbarth, Planemad, Wikidata-bugs, aude, Yurik, TheDJ, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-21 Thread Izno 
Izno added a comment.


  Categories probably shouldn't even be generated for items. 
https://www.wikidata.org/wiki/Category:Pages_with_maps has got a few others. 
Maybe a leftover from some bad deployment or another?

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Izno
Cc: Izno, Aklapper, Nikki, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T344577: Wikidata item pages show incorrect category section when the item has coordinates

2023-08-20 Thread Nikki 
Nikki created this task.
Nikki added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Steps to replicate the issue** (include links if applicable):
  
  - Enable hidden categories in your preferences
  - Open an item with coordinates, e.g. https://www.wikidata.org/wiki/Q7105617
  -
  
  **What happens?**:
  
  A categories section is shown at the bottom of the page, claiming the page is 
in the hidden category "Pages with maps" when it isn't.
  
  **What should have happened instead?**:
  
  The categories section should not be shown.
  
  **Software version** (skip for WMF-hosted wikis like Wikipedia):
  
  **Other information** (browser name/version, screenshots, etc.):

TASK DETAIL
  https://phabricator.wikimedia.org/T344577

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Aklapper, Nikki, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org