[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Arian_Bozorg]

Arian_Bozorg closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Arian_Bozorg
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE added a comment.


  All fixes done! 

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/831
  
  The white space under the footer issue is not part of the Textarea but it 
solved in a different PR: 
https://github.com/wmde/wikidata-mismatch-finder/pull/832

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Hello, @Sarai-WMDE , the white space below the footer is not related to the 
textarea, it is an issue of the height of the page... Don't know if it makes 
sense to put in these changes. We had already worked on this issue but it seems 
like the solution wasn't bulletproof. :/

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Thanks for the replacement! Here's a list of issues detected in all browsers:
  
  1. Missing label: The TextArea/Field should still display a label that says 
"Please add one Item identifier per line". (This label should be announced by 
screen readers, but I believe that'll be the case by default).
  
  F41650567: Screenshot 2024-01-04 at 15.39.13.png 

  
  2. Unwanted white space under footer: When the TextArea's height is reduced 
to the minimum, white space appears under the Mismatch app footer.
  
  F41650563: Screenshot 2024-01-04 at 15.34.44.png 

  
  3. ProgressBar's width: Applying a 50% width to the bar makes sense in wider 
viewports, but this makes it become a bit too small below the tablet breakpoint:
  
  F41650542: Screenshot 2024-01-04 at 15.17.13.png 

  
  Recommendation: add a media query to increase the width of the bar to 80% 
below the tablet breakpoint. This is sort of an arbitrary value, given that the 
responsive behavior of ProgressBar hasn't been defined yet (see T352844 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Sarai-WMDE
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/771

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[guergana.tzatchkova]

guergana.tzatchkova claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[ItamarWMDE]

ItamarWMDE added a comment.


  **Task Breakdown Notes**:
  
  - The task is probably not parallelizable
  
  **Potential plan of action**:
  
  1. Create a Mismatch Finder wrapper component that combines the Relevant 
codex components: `TextArea`, `Field`, `ProgressBar` - With Vue component tests
  2. Make the component reactive to the loading state and messages, the various 
states are detailed in the design specs
  3. Incorporate the new wrapper component within `Home.vue`

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[karapayneWMDE]

karapayneWMDE moved this task from Unified QT Backlog to Quality Tools "Sprint" 
on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Quality Tools 
"Sprint"); removed Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[karapayneWMDE]

karapayneWMDE updated the task description.
karapayneWMDE set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T347190: [WtC-M2] Replace WiKit TextArea component by Codex's

[Sarai-WMDE]

Sarai-WMDE created this task.
Sarai-WMDE added projects: Wikidata Dev Team, Wikidata Design System, Wikidata, 
Mismatch Finder.

TASK DESCRIPTION
  Problem
  ---
  
  The Mismatch Finder's user interface was composed using a combination of Vue 
2 custom components and WiKit elements, such as `TextArea`. The WiKit design 
system is now on its deprecation path, as it has been superseded by Codex, the 
official Wikimedia design system. The utilization of WiKit components is not 
recommended, and they should be replaced in order to reduce maintenance costs 
and ensure consistency.
  
  Solution
  
  
  We have to replace the WiKit `TextArea` by the Codex equivalent: 
`cdx-text-area`. This will take us a step closer to switching to the new design 
system and deprecating the old.
  
  F37750937: Screenshot 2023-09-22 at 17.16.24.png 

  
  Considerations
  --
  
  There are a couple of TextArea states that are either missing or not 
consistent with Codex. We'll bypass them by design:
  
  - Loading state missing: The WiKit text area displays an indeterminate inline 
progress bar to communicate its loading state, but this is not aligned with 
Codex’s guidelines. We’ll show Codex's indeterminate ProgressBar 

 on top of a read-only TextArea to communicate that the request is being 
processed.


  
  - Warning state: In MSMF, the TextArea displays a warning when users try to 
submit an empty request. This state is part of the Wikit component. In Codex, 
the inline validation of form fields is managed (among other things) by a 
different element: the Field 

 component, which at the moment doesn't provide a warning state. We’ll use 
Field's error message instead to facilitate the migration.
  
  | Loading state   

| Warning state replaced by error |
  | 
---
 | --- |
  | F37751084: loading state.png  
See specifications 

 | F37751086: e1.png   
 |
  |
  
  
  
  Acceptance criteria
  ---
  
  [ ] WiKit's TextArea is replaced by its Codex equivalent
  [ ] We use Codex's Field to add a label and inline validation messages to 
TextArea

TASK DETAIL
  https://phabricator.wikimedia.org/T347190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Michael, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, STH, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org