[Wikidata-bugs] [Maniphest] T364228: SDC edits not reflected in read actions with parsoid read views enabled

2024-05-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Well, that would be why.
  
  name=RevisionRenderer::combineSlotOutput()
// short circuit if there is only the main slot
// T351026 hack: if use-parsoid is set, only return main slot 
output for now
// T351113 will remove this hack.
if ( array_keys( $slots ) === [ SlotRecord::MAIN ] || 
$options->getUseParsoid() ) {
return $rrev->getSlotParserOutput( SlotRecord::MAIN, 
$hints );
}
  
  I guess someone thought the other slots aren’t important? But they are for 
SDC >.<
  
  So we’ll just have to wait for T351113 
 to remove the T351026 
 hack.

TASK DETAIL
  https://phabricator.wikimedia.org/T364228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, taavi, Aklapper, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, 
maantietaja, FRomeo_WMF, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, 
Dringsim, DannyS712, Nandana, JKSTNK, Jony, Amorymeltzer, Lahi, Gq86, 
E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, 
KimKelting, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, Izno, Fuzheado, Jrf, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, cscott, 
Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, ssastry, 
Arlolra, Jdforrester-WMF, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T364228: SDC edits not reflected in read actions with parsoid read views enabled

2024-05-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I can reproduce the issue locally (after installing Extension:ParserMigration 
with `$wgParserMigrationEnableQueryString = true;`), so that’s good.
  
  `WikibaseMediaInfoHooks::extractStructuredDataHtml()` tries to get the 
structured data part from the given HTML; if it can’t find it, it instead 
renders an empty structured data view and renders that. This is apparently 
what’s happening; its regex looks for `` elements in the HTML, 
but I see no trace of that in the `$html` I  see in the debugger.
  
  As far as I can tell, non-Parsoid page renders call 
`MediaInfoView::getContent()` via `EntityHandler::fillParserOutput()` and 
`FullEntityParserOutputGenerator::addHtmlToParserOutput()`; Parsoid page 
renders don’t even reach `EntityHandler::fillParserOutput()` when the page is a 
file. (But they do reach it for normal page renders. No idea what’s different 
about file pages yet.)

TASK DETAIL
  https://phabricator.wikimedia.org/T364228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, taavi, Aklapper, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, 
maantietaja, FRomeo_WMF, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, 
Dringsim, DannyS712, Nandana, JKSTNK, Jony, Amorymeltzer, Lahi, Gq86, 
E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, 
KimKelting, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, Izno, Fuzheado, Jrf, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, cscott, 
Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, ssastry, 
Arlolra, Jdforrester-WMF, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T364228: SDC edits not reflected in read actions with parsoid read views enabled

2024-05-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  That’s weird. My first guess was that `mw.values.get( 'wbEntity' )` was 
missing, but it’s there AFAICT. So why is the WikibaseMediaInfo UI not picking 
it up?
  
  I can also reproduce the issue at 
https://commons.wikimedia.org/wiki/File:CSD_Berlin_2019_-_Lucas_Werkmeister_-_24_-_Bi,_Pan,_Ace_Flags.jpg?useparsoid=1
 (so it’s not limited to `P180` / depicts).
  
  Looking at the code in `filepage/init.js`, I think the code is actually 
trying to “hydrate” the existing markup (rather than recreate it) – and it 
looks like the Parsoid markup has the statements group empty. (It’s present, 
but has no content.) Screenshot without JavaScript:
  F50162702: image.png 
  So we need to find out how that’s added in PHP – maybe some hook that Parsoid 
doesn’t use? (But then you’d expect it to be completely absent, not empty…)

TASK DETAIL
  https://phabricator.wikimedia.org/T364228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, taavi, Aklapper, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, SLopes-WMF, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, 
maantietaja, FRomeo_WMF, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, 
Dringsim, DannyS712, Nandana, JKSTNK, Jony, Amorymeltzer, Lahi, Gq86, 
E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, 
KimKelting, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, Izno, Fuzheado, Jrf, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, cscott, 
Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, ssastry, 
Arlolra, Jdforrester-WMF, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T364228: SDC edits not reflected in read actions with parsoid read views enabled

2024-05-04 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T364228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: taavi, Aklapper, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, 
SLopes-WMF, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, maantietaja, 
FRomeo_WMF, ItamarWMDE, DAlangi_WMF, Nintendofan885, Akuckartz, Dringsim, 
DannyS712, Nandana, JKSTNK, Jony, Amorymeltzer, Lahi, Gq86, E1presidente, 
Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, KimKelting, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Scott_WUaS, Susannaanas, Izno, Fuzheado, Jrf, Jane023, Wikidata-bugs, Base, 
matthiasmullie, aude, Daniel_Mietchen, cscott, Dinoguy1000, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Raymond, ssastry, Arlolra, Jdforrester-WMF, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T364228: SDC edits not reflected in read actions with parsoid read views enabled

2024-05-04 Thread taavi 
taavi renamed this task from "SDC edits not reflected in read actions" to "SDC 
edits not reflected in read actions with parsoid read views enabled".

TASK DETAIL
  https://phabricator.wikimedia.org/T364228

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: taavi
Cc: taavi, Aklapper, SLopes-WMF, toberto, GFontenelle_WMF, FRomeo_WMF, 
DAlangi_WMF, Nintendofan885, DannyS712, JKSTNK, Jony, Amorymeltzer, Lahi, 
E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Tramullas, Acer, Salgo60, 
Silverfish, Susannaanas, Izno, Fuzheado, Jrf, Jane023, Wikidata-bugs, Base, 
matthiasmullie, Daniel_Mietchen, cscott, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Raymond, ssastry, Arlolra, Jdforrester-WMF, Steinsplitter
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org