[Wikidata-bugs] [Maniphest] [Updated] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities
dom_walden added a comment. I can access and submit the Special:NewItem and Special:NewProperty forms unless I am partially blocked from the Main or Property namespace (resp.) I setup partial blocks for a user and their IP (i.e. a composite block), which used page restrictions to block the user from specific wikidata items. I performed the following special page actions on items they were and were not blocked from, and was allowed or not allowed as appropriate. - Special:MergeItems - Special:RedirectEntity - Special:SetSiteLink - Special:SetAliases - Special:SetDescription - Special:SetLabel - Special:SetLabelDescriptionAliases - Using the "Add links" on client wikidata wikis I could also edit items (e.g. adding statements, links, etc.) unless I was blocked from them specifically. I note that some of the block messages were a bit uninformative (e.g. some just said "Permission denied.", no extra info.) I assume this is a preexisting bug. > As for edits through the API, these block checks are already handled via the edit actions an EditEntityAction -> Action.php in core. So nothing to do there... I did not test the API, apart from the API calls that appear to happen when editing an item. Although, I see there are some phpunit checks <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/repo/tests/phpunit/includes/Api/ApiUserBlockedTest.php> that simulate performing certain API requests while blocked. I did all this testing on my local Vagrant environment, with the `wikidata` role enabled. - MediaWiki 1.34.0-alpha (dbdbeb7 <https://phabricator.wikimedia.org/rMWdbdbeb7af2a7f0ee00bdc4dfc1297edf0405a8fd>) 06:23, 14 August 2019 - WikibaseRepository (dfadb52 <https://phabricator.wikimedia.org/rEWBAdfadb52b2bc539cddc2b35aea28867514b7c894f>) 07:16, 14 August 2019 I was not able to test Special:NewLexeme. It is not included in the vagrant role nor on https://commons.wikimedia.beta.wmflabs.org/wiki/. It is on https://wikidata.beta.wmflabs.org/wiki/, but I am not an administrator there. @addshore, may I be added to the admin group on wikidata.beta, if you think this matters? TASK DETAIL https://phabricator.wikimedia.org/T207893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, dom_walden Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities
dom_walden added a comment. I am blocked from https://wikidata.beta.wmflabs.org/wiki/Special:NewLexeme even if I am only partially blocked. Maybe the appropriate change needs to be made here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/master/src/MediaWiki/Specials/SpecialNewLexeme.php#120 TASK DETAIL https://phabricator.wikimedia.org/T207893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, dom_walden Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities
dom_walden added a comment. In T207893#5429435 <https://phabricator.wikimedia.org/T207893#5429435>, @dbarratt wrote: > Oversight on my part, it looks like the creation code (in both patches) is using `AbstractBlock::isSitewide()` instead of `AbstractBlock::appliesToNamespace()` (as is outlined in the task description). Using the former means that someone who is blocked from a namespace **will** be allowed to create an item in that namespace, using the latter will ensure they are blocked properly from that namespace. As I understand it, the namespace blocking for Lexemes was done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/520200. But please confirm this. Testing on beta <https://wikidata.beta.wmflabs.org/wiki>, I **cannot** create a new Lexeme (either via Special:NewLexeme or api.php?action=wbeditentity) if I am partially blocked from the "Lexeme" namespace or if I am sitewide blocked. I **can** if I am partially blocked but not from the Lexeme namespace. TASK DETAIL https://phabricator.wikimedia.org/T207893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, dom_walden Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities
dom_walden moved this task from QA/Testing to Done on the Anti-Harassment (The Letter Song) board. dom_walden added a comment. In T207893#5431725 <https://phabricator.wikimedia.org/T207893#5431725>, @WMDE-leszek wrote: > thanks @dom_walden ! So are we fine to conclude this is now resolved? If everyone else is happy, then I'm happy :) TASK DETAIL https://phabricator.wikimedia.org/T207893 WORKBOARD https://phabricator.wikimedia.org/project/board/4113/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, dom_walden Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T235906: Cannot access replica databases
dom_walden added a comment. In T235906#5587865 <https://phabricator.wikimedia.org/T235906#5587865>, @JHedden wrote: > @dom_walden I verified that your account is now working again, please let us know if you're still unable to connect to the replica databases. Thanks! I can now access. TASK DETAIL https://phabricator.wikimedia.org/T235906 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JHedden, dom_walden Cc: JHedden, Krenair, Betacommand, Harej, Aklapper, #cloud-services, #toolforge, dom_walden, Zylc, 1978Gage2001, aborrero, Chicocvenancio, Tbscho, Freddy2001, JJMC89, srodlund, Luke081515, Jitrixis, Gryllida, jayvdb, scfc, coren ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T235906: Cannot access replica databases
dom_walden created this task. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION After SSH'ing into `login.tools.wmflabs.org` as user `dwalden`, after doing: - `sql enwiki`, or - `mysql --defaults-file=$HOME/replica.my.cnf -h enwiki.analytics.db.svc.eqiad.wmflabs enwiki_p` I get the error: `ERROR 1045 (28000): Access denied for user 'u20968'@'x' (using password: YES)` I believe my `replica.my.cnf` is correct and symlinked as `my.cnf`. This has worked for me in the past. TASK DETAIL https://phabricator.wikimedia.org/T235906 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: Aklapper, #cloud-services, #toolforge, dom_walden ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T289842: Diffs do not work as expected when comparing changes made to structured data
dom_walden added a project: Multi-Content-Revisions. dom_walden added a comment. Diffs appear to be including Multi-Content Revision <https://www.mediawiki.org/wiki/Multi-Content_Revisions> slots, not just the `main` slot. Another example, not from Commons: 1. Go to https://en.wikisource.org/w/index.php?title=Page:Hoffmann%27s_strange_stories.From_the_German.._(IA_hoffmannsstrange00hoff).pdf/202=edit 2. Enter some text 3. Click "Show Changes" TASK DETAIL https://phabricator.wikimedia.org/T289842 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: dom_walden, Jdx, Aklapper, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, CBogen, Nintendofan885, Akuckartz, DannyS712, Nandana, JKSTNK, Amorymeltzer, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Agabi10, Scott_WUaS, Susannaanas, Jane023, Wikidata-bugs, WMDE-Fisch, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist
dom_walden added projects: MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T296712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: dom_walden, Aklapper, Akuckartz, lucamauri, Gq86, Vali.matei, xSavitar, Nirmos, Wikidata-bugs, Dinoguy1000, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: All Selenium tests using authentication are broken
dom_walden added a comment. In T320471#8306640 <https://phabricator.wikimedia.org/T320471#8306640>, @dom_walden wrote: > I can reproduce this problem on beta normally if I clear my browser cookies. I now can reproduce even without clearing my browser cookies, just by logging out of an existing session and trying to login again. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: All Selenium tests using authentication are broken
dom_walden added a comment. I **can** login to https://login.wikimedia.beta.wmflabs.org TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: All Selenium tests using authentication are broken
dom_walden added a comment. I can reproduce this problem on beta normally if I clear my browser cookies. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: dom_walden Cc: dom_walden, kostajh, Aklapper, Sgs, caldera, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, lucamauri, Nattes, Iniquity, xSavitar, Taiwania_Justo, SBisson, Wikidata-bugs, geraki, Catrope, zeljkofilipin, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
