[WikiEN-l] Flagged Protection Revert Etiquette (Re: Renaming Flagged Protections)

2010-05-22 Thread Rob Lanphier
On Fri, May 21, 2010 at 9:58 PM, Carcharoth carcharot...@googlemail.comwrote:

 By the way, I'm assuming that some edits will be of the sort I would
 normally remove the material and start a talk page discussion. In
 that case, is the right thing to do to approve the edit and then
 remove the material and start a talk page discussion, and presumably
 as a reviewer, your edit removing the material won't be caught up in
 flagged revisions itself?


Starting a separate thread since this is off of the naming topic.

I don't think it's necessary to accept the edit, since the unaccepted
version is never really marked as rejected in the edit history per se, but
rather, just never gets promoted.  The edit will still exist in the edit
history, so it's not lost forever.

The right thing to do is to do the exact same thing you would do with an
unprotected page.  If it's not obviously vandalism, you can use the undo
function with a polite note in the edit comment to discuss the change on the
talk page.  Presumably, you're doing this as an autoconfirmed user, which
means that your edits will be automatically accepted.

Rob
___
WikiEN-l mailing list
WikiEN-l@lists.wikimedia.org
To unsubscribe from this mailing list, visit:
https://lists.wikimedia.org/mailman/listinfo/wikien-l


Re: [WikiEN-l] Flagged Protection Revert Etiquette (Re: Renaming Flagged Protections)

2010-05-22 Thread Rob Lanphier
On Sat, May 22, 2010 at 12:05 AM, Carcharoth carcharot...@googlemail.comwrote:

 Can you reject with a let's discuss on the talk page? What I am
 thinking is that some people use edit summaries to alert other editors
 to a talk page discussion, and if this is not possible with the
 FlaggedRevs system, I would be inclined to accept an edit and then
 revert it and suggest a talk page discussion.




At this very moment, there is no reject button.  That's one of the last
minute features that we're working on here:
http://flaggedrevs.labs.wikimedia.org/wiki/Wikimedia:Reject_Pending_Revision

There is already a comment entry field beside the approve (accept) button
right now, and there's no reason I can see why that same comment entry field
won't be used for the proposed reject button.

There is currently a de-approve button (which we're renaming unaccept),
but that's only for the rare case where someone has accepted a revision, and
then you're unmarking it.



 What I'm asking is whether you need to accept first or not.


Nope, you shouldn't need to.



 I get the
 impression from what you are saying that you can click undo
 straightaway and that automatically accepts the edit and undoes it in
 one step (I would replace the automatic undo summary).



Not quite.  This is what a whiteboard is really handy for  :)  I'm guessing
you may have a slightly incorrect way of thinking about how the feature
works, and that's causing some confusing in cases like this.

It may be helpful to understand how this feature works under the hood to be
able to visualize what's happening.  Each revision has a flag associated
with it (the accepted flag) which by default is false (unaccepted).
 Approving/accepting an article flips that flag to true (accepted).  The
article that gets shown is the latest one with the flag set true
(accepted).

The thing that's very confusing for people is that they want to think about
three states for a given revision:  approved, rejected, and
unreviewed.  That's not the way the feature is implemented though.
 Rejected and unreviewed are indistinguishable at the database level.

There is a distinction that's a fair approximation for rejected versus
unreviewed, which is by answering the question is there a later accepted
revision than this unaccepted revision I'm looking at?  If there is, then
the revision is implictly rejected.  If there isn't, then the revision is
implicitly unreviewed.  That's how this feature works.  We treat
unaccepted revisions after the latest accepted revision as pending
revisions.

So, back to your question.  When you click undo on a pending revision,
there's no magic accepting going on of the pending revision.  Instead,
you're just putting an accepted revision after it, thus implicitly rejecting
that revision.



 Normally, when
 reverting and adding a custom edit summary, I load the previous page
 version and save that with an edit summary. But I don't think that
 will work here, though maybe it will.


Yup, that will still work just fine.



 I suspect that any action by an autoconfirmed user will automatically
 accept something of any actions not yet reviewed. Will those
 autoconfirmed users get a warning that they might unwittingly be
 accepting edits they might not have reviewed?


Yup, they do.  There's a banner at the top of the page that tells them
exactly this.

Rob
___
WikiEN-l mailing list
WikiEN-l@lists.wikimedia.org
To unsubscribe from this mailing list, visit:
https://lists.wikimedia.org/mailman/listinfo/wikien-l


Re: [WikiEN-l] Flagged Protection Revert Etiquette (Re: Renaming Flagged Protections)

2010-05-22 Thread Carcharoth
On Sat, May 22, 2010 at 8:43 AM, Rob Lanphier ro...@robla.net wrote:

snip

 Not quite.  This is what a whiteboard is really handy for  :)  I'm guessing
 you may have a slightly incorrect way of thinking about how the feature
 works, and that's causing some confusing in cases like this.

I think I was getting a bit confused. Thanks for explaining it so
clearly (whiteboard or not)! It has made things quite a bit clearer
for me, though not as clear as if I actually played around on the test
wiki, though I can maybe claim I want to see what the change will be
like for the vast majority who may be thrown by the changeover. Either
that, or I'm being lazy! :-)

Carcharoth

PS. Some diagrams would be helpful, do the pages people are pointed at
have diagrams?

___
WikiEN-l mailing list
WikiEN-l@lists.wikimedia.org
To unsubscribe from this mailing list, visit:
https://lists.wikimedia.org/mailman/listinfo/wikien-l