[MediaWiki-CodeReview] [MediaWiki r85546]: New comment added
User Fomafix posted a comment on MediaWiki.r85546. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85546#c15794 Comment: Should it be included in 1.17, because r80495 from Bug 26708 also is in 1.17? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85546]: New comment added
User Krinkle posted a comment on MediaWiki.r85546. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85546#c15795 Comment: You're right. I've tagged it for merge. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Narayam User Interface Improvements
On 6 April 2011 00:44, Trevor Parscal tpars...@wikimedia.org wrote: When Roan Kattouw reviewed, and then rewrote most of the Narayam extension, I reviewed his code, and found many things about the user interface that could be, and need to be improved. I have both some observations and some suggestions, expressed in the attached PDF. The exact design I'm proposing isn't a requirement, but hopefully is provides a starting point for a way to get this extension's user interface where we need it to be. Could you make a similar proposal for the WebFonts extension? Input methods and web fonts are quite related. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85660]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85660#c15796 Comment: I'd imagine this error message would be pretty annoying if you had no idea what is going on. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85662]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85662. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85662#c15797 Comment: Can also be written max( 1, $procs ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85670]: New comment added
User Freakolowsky posted a comment on MediaWiki.r85670. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85670#c15798 Comment: had to do this partial merge ... because r8104 was not merged installer and search were broken in this branch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] WMDE offers a contract for implementing GraphServe (part of next-gen CatScan)
Hi all! Wikimedia Deutschland is offering a contract for implementing the GraphServ component for our Graph Processor project. Anyone interested is invited to apply, the official call for bids is at http://wikimedia.de/wiki/Ausschreibung/GraphServ. The Graph Processor project aims to develop an infrastructure for rapidly analyzing and evaluating Wikipedia's category structure. It's supposed to become part of the Toolserver infrastructure (and eventually, the WMF search cluster) that allows CatScan-like queries to run in under a second instead of minutes. The contract offered here covers the implementation of the GraphServ component, which is to function as a service by which applications can access the category structures of different wikis, similar to the way a database server would provide access to information stored in databases. Technically, GraphServ is a server that manages TCP connections and attaches them to instances of GraphCore, which do the actual processing of the category structures https://github.com/jkroll20/graphcore/blob/master/spec.rst. The server will be accessed by applications via client libraries written in PHP, Python, etc, which are not in scope of the contract but will be developed in parallel by Wikimedia Deutschland. A rough specification of the GraphServ component along with requirements for the implementations can be found at http://wikimedia.de/wiki/Ausschreibung/GraphServ/Spec. Note that GraphServ will be released as Open Source Software. While Wikimedia Deutschland will be the copyright holder for the software developed under contract, we will include the name of the actual authors in the copyright notice. Applications should include the following: * The applicant's prior experience with designing and implementing client/server software, as well as any other relevant qualifications * An overview of the intended architecture of the implementation and the technologies used, along with a rationale for choosing this architecture and technologies over others. * A rough road map of the implementation, documentation and testing phases, with the appropriate mile stones. * Estimate of working hours needed * Time frame for the implementation (calendar weeks) * Total expected cost, including taxes Please send your application to tech...@wikimedia.de by April 29. Cheers, Daniel PS: please forward this to anyone you think could be interested. thanks! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85668]: New comment added
User Reach Out to the Truth posted a comment on MediaWiki.r85668. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85668#c15799 Comment: Mark your own revisions as OK shouldn't include the second person pronoun your. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85668]: New comment added
User Reedy posted a comment on MediaWiki.r85668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85668#c15800 Comment: So 'Mark own revisions as OK' ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Narayam User Interface Improvements
I will see if I can get some time dedicated to this. If/when I do, I will probably have some more questions about the extension - are you a good person to contact about it? - Trevor On Apr 8, 2011, at 4:50 AM, Niklas Laxström wrote: On 6 April 2011 00:44, Trevor Parscal tpars...@wikimedia.org wrote: When Roan Kattouw reviewed, and then rewrote most of the Narayam extension, I reviewed his code, and found many things about the user interface that could be, and need to be improved. I have both some observations and some suggestions, expressed in the attached PDF. The exact design I'm proposing isn't a requirement, but hopefully is provides a starting point for a way to get this extension's user interface where we need it to be. Could you make a similar proposal for the WebFonts extension? Input methods and web fonts are quite related. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Narayam User Interface Improvements
Santhosh who made it is probably the best and I can try to answer questions about it too. On 8 April 2011 18:48, Trevor Parscal tpars...@wikimedia.org wrote: I will see if I can get some time dedicated to this. If/when I do, I will probably have some more questions about the extension - are you a good person to contact about it? - Trevor -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85677]: New comment added
User Bawolff posted a comment on MediaWiki.r85677. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85677#c15802 Comment: I think you got the revision number wrong in the commit summary. r85672 has to do with fixing parser tests for a change in math output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85668]: New comment added
User Bryan posted a comment on MediaWiki.r85668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85668#c15804 Comment: Shouldn't this also check for resolved? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85668]: New comment added
User Reedy posted a comment on MediaWiki.r85668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85668#c15805 Comment: Best ask the guy that wanted it... WMF won't be using it I'd guess ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85689]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r85689. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85689#c15806 Comment: Regressed in r82885. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Aquestion about templates parsing and caching
I'd like to know something more about template parsing/caching for performance issues. My question is: when a template is called, it's wikicode, I suppose, is parsed and translated into something running - I can't imagine what precisely, but I don't care so much about (so far :-) ). If a second call comes to the server for the same template, but with different parameters, the template is parsed again from scratch or something from previous parsing is used again, so saving a little bit of server load? If the reply is yes, t.i. if the running code of the whole template is somehow saved and cached, ready to be used again with new parameters, perhaps it could be a good idea to build templates as librares of different templates, using the name of the template as a library name and a parameter as the name of specific function; a simple #switch could be used to use the appropriate code of that specific function. On the contrary, if nothing is saved, there would be good reasons to keep the template code as simple as possible, and this idea of libraries would be a bad one. Alex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r83418]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r83418. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83418#c15807 Comment: I think this code needs to be copied into parserTest.inc as well (cf [[bugzilla:15892]]) but as I'm not sure the status of migration between backends, I don't want to mess with it without checking. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85684]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r85684. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85684#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85686]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r85686. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85686#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85669]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85669.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85669#c15808
Comment:
Rather than using the $wgDBprefix global, you should use
$dbw-tableName('si_text_idx') etc to get the full table name. This will be
more consistent with other code that constructs manual SQL, and avoids
accidentally using the wrong prefix if there's a complex setup with different
prefixes on different connections (eek!)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85664]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r85664. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85664#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Aquestion about templates parsing and caching
On Fri, Apr 8, 2011 at 2:11 PM, Alex Brollo alex.bro...@gmail.com wrote: I'd like to know something more about template parsing/caching for performance issues. My question is: when a template is called, it's wikicode, I suppose, is parsed and translated into something running - I can't imagine what precisely, but I don't care so much about (so far :-) ). If a second call comes to the server for the same template, but with different parameters, the template is parsed again from scratch or something from previous parsing is used again, so saving a little bit of server load? Currently there's not really a solid intermediate parse structure in MediaWiki (something we hope to change; I'll be ramping up some documentation for the soon-to-begin mega parser redo project soon). Approximately speaking... In the current system, the page is preprocessed into a partial preprocessor tree which identifies certain structure boundaries (for templates and function tag-hook extensions); templates and some hooks get expanded in, then it's all basically flattened back to wikitext. Then the main parser takes over, turning the whole wikitext document into HTML output. I believe we do locally (in-process) cache the preprocessor structure for pages and templates, so multiple use of the same template won't incur as much preprocessor work. But, the preprocessor parsing is usually one of the fastest parts of the whole parse. If the reply is yes, t.i. if the running code of the whole template is somehow saved and cached, ready to be used again with new parameters, perhaps it could be a good idea to build templates as librares of different templates, using the name of the template as a library name and a parameter as the name of specific function; a simple #switch could be used to use the appropriate code of that specific function. I think for the most part, it'll be preferable to only have to work with the functions that are needed, rather than fetching a large number of unneeded functions at once. Even if it's pre-parsed, loading unneeded stuff means more CPU used, more memory used, more network bandwidth used. But being able to bundle together related things as a unit that can be distributed together would be very nice, and should be considered for future work on new templating and gadget systems. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85464]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r85464. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85464#c15809 Comment: This unfortunately doesn't seem to take effect on fractions which are rendered as a table, probably because the Sanitizer is breaking the table out of the surrounding span. But there may not be much to do about that, other than junking the awful rendering mode. :P Could maybe detect it and change it to a div since the span would break anyway... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85464]: New comment added
User Reedy posted a comment on MediaWiki.r85464. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85464#c15811 Comment: Fixed in the database! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85699]: Revision status changed
User Krinkle changed the status of MediaWiki.r85699. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85699#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Aquestion about templates parsing and caching
On 11-04-08 02:37 PM, Brion Vibber wrote: On Fri, Apr 8, 2011 at 2:11 PM, Alex Brolloalex.bro...@gmail.com wrote: I'd like to know something more about template parsing/caching for performance issues. My question is: when a template is called, it's wikicode, I suppose, is parsed and translated into something running - I can't imagine what precisely, but I don't care so much about (so far :-) ). If a second call comes to the server for the same template, but with different parameters, the template is parsed again from scratch or something from previous parsing is used again, so saving a little bit of server load? Currently there's not really a solid intermediate parse structure in MediaWiki (something we hope to change; I'll be ramping up some documentation for the soon-to-begin mega parser redo project soon). Approximately speaking... In the current system, the page is preprocessed into a partial preprocessor tree which identifies certain structure boundaries (for templates and function tag-hook extensions); templates and some hooks get expanded in, then it's all basically flattened back to wikitext. Then the main parser takes over, turning the whole wikitext document into HTML output. I believe we do locally (in-process) cache the preprocessor structure for pages and templates, so multiple use of the same template won't incur as much preprocessor work. But, the preprocessor parsing is usually one of the fastest parts of the whole parse. -- brion I could swear we locally cache template wikitext, and save preprocessed data to the object cache. Least I think thats what I gathered last time I read the code. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Aquestion about templates parsing and caching
On 11-04-08 02:37 PM, Brion Vibber wrote: On Fri, Apr 8, 2011 at 2:11 PM, Alex Brolloalex.bro...@gmail.com wrote: I'd like to know something more about template parsing/caching for performance issues. My question is: when a template is called, it's wikicode, I suppose, is parsed and translated into something running - I can't imagine what precisely, but I don't care so much about (so far :-) ). If a second call comes to the server for the same template, but with different parameters, the template is parsed again from scratch or something from previous parsing is used again, so saving a little bit of server load? Currently there's not really a solid intermediate parse structure in MediaWiki (something we hope to change; I'll be ramping up some documentation for the soon-to-begin mega parser redo project soon). Approximately speaking... In the current system, the page is preprocessed into a partial preprocessor tree which identifies certain structure boundaries (for templates and function tag-hook extensions); templates and some hooks get expanded in, then it's all basically flattened back to wikitext. Then the main parser takes over, turning the whole wikitext document into HTML output. I believe we do locally (in-process) cache the preprocessor structure for pages and templates, so multiple use of the same template won't incur as much preprocessor work. But, the preprocessor parsing is usually one of the fastest parts of the whole parse. -- brion I could swear we locally cache template wikitext, and save preprocessed data to the object cache. Least I think thats what I gathered last time I read the code. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85702]: Revision status changed
User Platonides changed the status of MediaWiki.r85702. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85702#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Aquestion about templates parsing and caching
Daniel Friesen wrote: I believe we do locally (in-process) cache the preprocessor structure for pages and templates, so multiple use of the same template won't incur as much preprocessor work. But, the preprocessor parsing is usually one of the fastest parts of the whole parse. I could swear we locally cache template wikitext, and save preprocessed data to the object cache. Least I think thats what I gathered last time I read the code. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]Yes Yes. Calling a template twice will only fetch the text once, won't increase the 'used templates' counter... Preprocessing of wikitext over a threshold is cached serialized (it's easier to reprocess if it's too small). On the original question: The tree will be reused, but it has to be expanded again. It's not clear that you gain by using a library since you will pay the library costs on all articles using it. Templates should be kept simple (yes, enwiki is particularly bad at that). In early 2007, eswiki implemented a library template (Plantilla:Interproyecto) which was used for adding any interwikis to sister projects. It caused server problems and got disabled by the sysadmins. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Actions and Special Pages
I also think it's cleaner to make move an action than edit a Special page. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Moving math/texvc to Math extension for 1.18 (packagers take note)
I've taken the liberty of moving most of the math guts out of MediaWiki core into its own Math extension: https://bugzilla.wikimedia.org/show_bug.cgi?id=14202 http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85706 We meant to do this years ago -- I even got partway through it once but got held up on the horrid Special:Preferences system we had back in the day and never finished it. The modern Preferences class is a lot more flexible, and I was able to just grab the function that sets up that portion of the form and move it over. Yay! There are a few cleanup bits still to do; I didn't want to dive into the message files just yet. There are some legacy interfaces on Language for getting the math option names, so that'll need a little more fixin' to remove those (the strings _should_ all be in the regular message area now) and then break the message files out. People doing third-party packages of MediaWiki should take note: the texvc subprogram source will live in the extension now, not core, so build scripts for 'mediawiki-math' packages will need to be updated. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85706]: New comment added
User ^demon posted a comment on MediaWiki.r85706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85706#c15812 Comment: I love you. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85707]: New comment added
User Reedy posted a comment on MediaWiki.r85707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85707#c15813 Comment: Think you need to check your autoprops are set :) [[Subversion/auto-props]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85706]: New comment added
User Reedy posted a comment on MediaWiki.r85706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85706#c15814 Comment: I'm guessing the language files need carefully stripping of math stuff too... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Mediawiki-l] Sidebar Customization
On 11-04-08 09:49 AM, Henny Savenije wrote: At 12:45 AM 4/9/2011, Trevor wrote: Take a look at the Vector extension. It offers a variety of progressive enhancements for the Vector skin. I tried to install that but I get a blank page. _ _ (o) (o) oOOO(_)OOOo--- Henny (Lee Hae Kang) By any chance are you running 1.16? The Vector extension is only compatible with 1.17+. For 1.16 you need to use the UsabilityInitiative extension that the Vector extension was split out from around 1.17. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
