[MediaWiki-CodeReview] [MediaWiki r104837]: Revision status changed
Siebrand changed the status of MediaWiki.r104837 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104837 Old status: new New status: ok Commit summary for MediaWiki.r104837: Add support for Nepali, Konkani and Bhojpuri ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104393]: Revision status changed
Siebrand changed the status of MediaWiki.r104393 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104393 Old status: new New status: ok Commit summary for MediaWiki.r104393: Change the scope of config to local. Follow up r102770 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103925]: Revision status changed
Siebrand changed the status of MediaWiki.r103925 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103925 Old status: new New status: ok Commit summary for MediaWiki.r103925: Narayam: Remove cc-by-sa from my contributions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102770]: Revision status changed
Siebrand changed the status of MediaWiki.r102770 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102770 Old status: new New status: resolved Commit summary for MediaWiki.r102770: Create ext.webfonts.init and ext.webfonts.core modules, set 'position' = 'top' for both of these modules so that they start loading and initializing from the head and only execute after document is ready. ext.webFonts.fontlist.js extends mw.webfonts.config object with the list of fonts and languages As per https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WebFonts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102375]: Revision status changed
Siebrand changed the status of MediaWiki.r102375 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102375 Old status: new New status: ok Commit summary for MediaWiki.r102375: Use the fonts for the variant script for wikis with multiple scripts(sr,zh etc). Use wgUserVariant variable to find out the variant language code. Font selection is based on uservariant, contentlanguage , and userlanguage. i18n card #117 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103637]: New comment added
Siebrand posted a comment on MediaWiki.r103637. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103637#c27122 Commit summary for MediaWiki.r103637: Apparently behaviour changed in trunk, so blacklisting actions instead of whitelisting Siebrand's comment: Hmm. Blacklisting instead of whitelisting is inherently unsafe. Do you know where this was changed, as we may want to point that out there... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105418]: Revision status changed
Siebrand changed the status of MediaWiki.r105418 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105418 Old status: new New status: ok Commit summary for MediaWiki.r105418: Adding the License for Madan font. Upstream just says that it is GPL. So following the license text used by Fedora package maintainers. It is a copy of the text given inside the font. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104842]: Revision status changed
Siebrand changed the status of MediaWiki.r104842 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104842 Old status: new New status: resolved Commit summary for MediaWiki.r104842: Fix the pointer behaviour in the menu items of Narayam extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104838]: Revision status changed
Siebrand changed the status of MediaWiki.r104838 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104838 Old status: new New status: ok Commit summary for MediaWiki.r104838: Add GPL licensed font Madan for Nepali language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104653]: Revision status changed
Siebrand changed the status of MediaWiki.r104653 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104653 Old status: new New status: ok Commit summary for MediaWiki.r104653: update Lohit Oriya fonts from upstream. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104652]: Revision status changed
Siebrand changed the status of MediaWiki.r104652 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104652 Old status: new New status: ok Commit summary for MediaWiki.r104652: Update Lohit Tamil from upstream. Use font names as per upstream. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104542]: Revision status changed
Siebrand changed the status of MediaWiki.r104542 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104542 Old status: new New status: ok Commit summary for MediaWiki.r104542: Update Lohit Tamil font with Embolden transformation to fix hinting issues. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103132]: Revision status changed
Siebrand changed the status of MediaWiki.r103132 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103132 Old status: new New status: ok Commit summary for MediaWiki.r103132: Along with checking the font from cookie is available, check for 'none' too. Otherwise 'reset' option will not be remembered across pages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102766]: Revision status changed
Siebrand changed the status of MediaWiki.r102766 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102766 Old status: new New status: ok Commit summary for MediaWiki.r102766: Moving $.webfonts into the mw object instead of the jQuery object. As per https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WebFonts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105122]: New comment added
Nikerabbit posted a comment on MediaWiki.r105122. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105122#c27123 Commit summary for MediaWiki.r105122: Adding new debugging toolbar Needs a UI cleanup still, but for the most part is working. Nikerabbit's comment: The good thing and the bad thing about $wgDebugComments is that it is invisible unless you look for it. But I kind of like this too. Even more if it was re-sizable :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104454]: Revision status changed
Siebrand changed the status of MediaWiki.r104454 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104454 Old status: deferred New status: resolved Commit summary for MediaWiki.r104454: * Improve i18n (use formatNum for all numbers, add dir lang attribute) * Change td to th elements for titles (this also makes the sort script work again) * General whitespace fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105112]: Revision status changed
Siebrand changed the status of MediaWiki.r105112 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105112 Old status: new New status: ok Commit summary for MediaWiki.r105112: follow-up 104454: use list() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105078]: Revision status changed
Siebrand changed the status of MediaWiki.r105078 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105078 Old status: new New status: fixme Commit summary for MediaWiki.r105078: * Show the list of wikis in two columns, to save space * Add a list of all databases, excluding those that are defined in the wiki set; this makes it more clear on which wikis an opt-out set is enabled, and on which wikis an opt-in set is disabled ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105090]: Revision status changed
Siebrand changed the status of MediaWiki.r105090 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105090 Old status: new New status: ok Commit summary for MediaWiki.r105090: The response title should be in the wiki content language ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104892]: Revision status changed
Siebrand changed the status of MediaWiki.r104892 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104892 Old status: new New status: ok Commit summary for MediaWiki.r104892: (bug 32075) Always add lowercase interwikis. Patch by Vitaliy Filippov. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104426]: Revision status changed
Siebrand changed the status of MediaWiki.r104426 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104426 Old status: new New status: ok Commit summary for MediaWiki.r104426: no need to hardcode font-weight:bold, tr is bold by default ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102998]: Revision status changed
Siebrand changed the status of MediaWiki.r102998 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102998 Old status: new New status: ok Commit summary for MediaWiki.r102998: MFT r98140 r100023 r102786 r102802 r102893 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102667]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r102667 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102667 Old status: new New status: ok Commit summary for MediaWiki.r102667: Narayam: Update Assamese transliteration rules. For bug 32120 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103657]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r103657 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103657 Old status: new New status: ok Commit summary for MediaWiki.r103657: Make Narayam work with page content language, so it detects the correct language of the edit field. Thanks to Santosh ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103652]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r103652 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103652 Old status: new New status: ok Commit summary for MediaWiki.r103652: Narayam keymapping for Punjabi in Gurmukhi script, based on Fedora keyboard layout. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki 2.0
* Trevor Parscal tpars...@wikimedia.org [Tue, 6 Dec 2011 17:21:43 -0800]: The hype of 2.0 aside, is there a guideline for what should constitute a major version number change? It looks like we are doing something like: Major.Minor.Release 1.18 = Major: 1, Minor: 18, (alpha|beta|etc.) I'm just curious what people think would constitue a major version. We've certainly had major rewrites of systems in the past that didn't seem to justify a version bump. Is there anything wrong with having version 1.249? Is there a practical reason for bumping the version at some point (like when the minor version hits tripple digits)? Also, a rewrite of MediaWiki should for sure be done in Node.js :) - Trevor Is Javascript really that good? Some people dislike prototypical inheritance, it seems that jQuery prefers to use wrappers instead (that's a kind of suboptimal architecture). Also, Google had some complains about Javascript flaws (for example primitive types don't allow high performance available in Java / C#), suggesting to replace it with something else.. Although having common clientside / serverside codebase is nice thing, for sure. And there's nothing more widespread than Javascript at client side. Also, it's object side is strong (something like Lisp with C-syntax), however it does not have generics, named parameters etc.. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki 2.0
* Erik Moeller e...@wikimedia.org [Tue, 6 Dec 2011 17:32:06 -0800]: IMO a switch to a visual editor as the default editing environment would be sufficient to merit the 2.0 moniker. Heck, it'd be sufficient to get rid of the double square brackets in the logo. ;-) Let's hope that raw wikitext still will be available to ones who prefer old fashioned way of article formatting. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki 2.0
* Tim Starling tstarl...@wikimedia.org [Wed, 07 Dec 2011 12:54:22 +1100]: On 07/12/11 12:34, Dan Nessett wrote: On Wed, 07 Dec 2011 12:15:41 +1100, Tim Starling wrote: How many servers do you have? 3. It would help to get it down to 2. I assume my comments apply to many other small wikis that use MW as well. Most operate on a shoe string budget. You should try running MediaWiki on HipHop. See http://www.mediawiki.org/wiki/HipHop It's not possible to pay developers to rewrite MediaWiki for less than what it would cost to buy a server. But maybe getting a particular MW installation to run on HipHop with a reduced feature set would be in the same order of magnitude of cost. -- Tim Starling An easier and probably more exotic-extension-compatible way is to use upcoming PHP 5.4, they promised faster execution and smaller memory footprint comparing to PHP 5.3. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r103664]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r103664 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103664 Old status: new New status: ok Commit summary for MediaWiki.r103664: Narayam: Changes suggested by Marathi wikipedians at Hackathon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104159]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r104159 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104159#c27124 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r104159: Limit the Narayam menu height so that it doesn't overflow the screen - had to increase padding to accommodate the scrollbars. Santhosh.thottingal's comment: r105281 fixed the IE scroll issue. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104577]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r104577. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104577#c27125 Commit summary for MediaWiki.r104577: Adding Tamil InScript mapping. Santhosh.thottingal's comment: In Malayalam it is required since there is a rule: ['ര്\\]', '', 'ർ'], which required lookbacklength 2. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104594]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r104594. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104594#c27126 Commit summary for MediaWiki.r104594: Followup to r104577, adding characters according to the standard. Santhosh.thottingal's comment: -['\\*', '', 'ஷ்ர'], - why this removed? I see this mapping in standard. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105280]: New comment added
Edokter posted a comment on MediaWiki.r105280. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280#c27127 Commit summary for MediaWiki.r105280: Diff colors now use the french Wikipedia scheme The french community has been using a specific set of colors for diff, it is believed to be easier to read for people perceiving colors differently. Source is from: http://fr.wikipedia.org/w/index.php?oldid=72567845uselang=en This commit override r94429 / r94461. See also docs/uidesign/mediawiki.action.history.diff.html Edokter's comment: You're welcome :) I heard because Brion spilled the beans on wikitech-l. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104577]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r104577 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104577#c27128 Old Status: new New Status: fixme Commit summary for MediaWiki.r104577: Adding Tamil InScript mapping. Santhosh.thottingal's comment: ['\\}', '', 'ஞ்'], is wrong. It is ['\\}', '', 'ஞ'], ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104594]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r104594 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104594#c27129 Old Status: new New Status: fixme Commit summary for MediaWiki.r104594: Followup to r104577, adding characters according to the standard. Santhosh.thottingal's comment: Either we need to add the extended layer as per the Inscript 2 draft standard, Or we need to make it compatible the existing inscript( http://fedoraproject.org/wiki/I18N/Indic/TamilKeyboardLayouts#Inscript_Keyboard_Layout) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104160]: Revision status changed
Nikerabbit changed the status of MediaWiki.r104160 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104160 Old status: new New status: ok Commit summary for MediaWiki.r104160: Follow-up r99389: Lower diacritics are invisible in titles in Indic languages Assamese, Bengali and Odiya. Add bug numbers and issue description to release notes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105414]: New comment added
Nikerabbit posted a comment on MediaWiki.r105414. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105414#c27130 Commit summary for MediaWiki.r105414: Follow up r105160. Make sure that resourceloader get correct module name. Nikerabbit's comment: Do I see a bit of code duplication here? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki 2.0
On 7 December 2011 01:21, Trevor Parscal tpars...@wikimedia.org wrote: It looks like we are doing something like: Major.Minor.Release 1.18 = Major: 1, Minor: 18, (alpha|beta|etc.) I'm just curious what people think would constitue a major version. We've certainly had major rewrites of systems in the past that didn't seem to justify a version bump. Is there anything wrong with having version 1.249? Is there a practical reason for bumping the version at some point (like when the minor version hits tripple digits)? Drop the first digit, as Java and Emacs did. The current release is MediaWiki 18. MediaWiki 19 is in progress. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105415]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105415 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105415 Old status: new New status: ok Commit summary for MediaWiki.r105415: Add a small shadow for the menu. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105416]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105416 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105416 Old status: new New status: ok Commit summary for MediaWiki.r105416: Add a small shadow for the webfonts menu. Remove an unwanted css style definition. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105414]: New comment added
Nikerabbit posted a comment on MediaWiki.r105414.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105414#c27131
Commit summary for MediaWiki.r105414:
Follow up r105160. Make sure that resourceloader get correct module name.
Nikerabbit's comment:
And we usually write } else { in one line.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105414]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105414 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105414 Old status: new New status: ok Commit summary for MediaWiki.r105414: Follow up r105160. Make sure that resourceloader get correct module name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105281]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r105281 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105281#c27132 Old Status: ok New Status: fixme Commit summary for MediaWiki.r105281: Fix Narayam for monobook skin(Bug 32124) Fix IE scrolling issue of the menu in Vector skin. Placed the menu in body instead of hidden block in the pt-narayam. On mouse hover, show it in proper position. Nikerabbit's comment: # Now the menu does not disappear if the cursor never hovers it - not a big problem. # More annoying is that there is considerable delay before the menu becomes visible. # This line should have some more spaces: + $( 'body').prepend($menu); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103786]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r103786 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103786#c27133 Old Status: new New Status: ok Commit summary for MediaWiki.r103786: (bug 27793) Make a config variable ($wgBabelUseUserLanguage) to make the Babel user language header and Users by language footer be in user language instead of page/content language. This feature is intended to be used on commons. Nikerabbit's comment: Should we even enable this by default? Most of the users are small wikies which don't see any performance hit. Heck, if WMF doesn't need to disable it, we could do it unconditionally. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103649]: Revision status changed
Nikerabbit changed the status of MediaWiki.r103649 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103649 Old status: new New status: ok Commit summary for MediaWiki.r103649: Fix r103637 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103637]: New comment added
Nikerabbit posted a comment on MediaWiki.r103637. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103637#c27134 Commit summary for MediaWiki.r103637: Apparently behaviour changed in trunk, so blacklisting actions instead of whitelisting Nikerabbit's comment: in_array() already returns boolean. X ? true : false; is redundant then. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103735]: New comment added
Nikerabbit posted a comment on MediaWiki.r103735. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103735#c27135 Commit summary for MediaWiki.r103735: Hindi Transliteration by Junaid, originally implemented on https://hi.wikipedia.org/wiki/%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Hi_rules.js Nikerabbit's comment: Really? + * @date 2011-02-26 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103737]: Revision status changed
Nikerabbit changed the status of MediaWiki.r103737 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103737 Old status: new New status: resolved Commit summary for MediaWiki.r103737: Narayam: Gujarathi ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103637]: Revision status changed
Nikerabbit changed the status of MediaWiki.r103637 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103637 Old status: new New status: fixme Commit summary for MediaWiki.r103637: Apparently behaviour changed in trunk, so blacklisting actions instead of whitelisting ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102912]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102912 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102912 Old status: new New status: ok Commit summary for MediaWiki.r102912: Don't show the Users by language footer if it doesn't link to a page. (The Babel user information top still makes sense without link). See also bug 31115. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102900]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102900 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102900 Old status: new New status: ok Commit summary for MediaWiki.r102900: The first parameter should be the level... $categoryLevel wasn't used, and $categoryMain was used twice. Strange. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102899]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102899 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102899 Old status: new New status: ok Commit summary for MediaWiki.r102899: Do not depend on the level category being configured, when adding the main category (or not). Having $wgBabelMainCategory configured and the level set to false, will now add the main category. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102759]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102759 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102759 Old status: new New status: ok Commit summary for MediaWiki.r102759: mw.util.addCSS will not work for IE if the css is font-face style. IE crashes. Reverting to old way of adding css. http://stackoverflow.com/questions/7931658/dynamically-adding-font-face-rule-in-ie-8-and-less ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102754]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102754 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102754 Old status: new New status: resolved Commit summary for MediaWiki.r102754: Better the css construction using array of fontformats and then joining. Add the css using mw.util.addCSS, also adding mediawiki.util as dependency. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102509]: Revision status changed
Nikerabbit changed the status of MediaWiki.r102509 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102509 Old status: new New status: resolved Commit summary for MediaWiki.r102509: Followup r102501, css cleanup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105425]: Revision status changed
Siebrand changed the status of MediaWiki.r105425 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105425 Old status: new New status: ok Commit summary for MediaWiki.r105425: Spell language name consistently ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105420]: Revision status changed
Siebrand changed the status of MediaWiki.r105420 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105420 Old status: new New status: ok Commit summary for MediaWiki.r105420: Fix 3 message keys from r104974 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105247]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105247 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105247 Old status: deferred New status: ok Commit summary for MediaWiki.r105247: Messages for property creation now come from Semantic MediaWiki, not from Page Schemas ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105251]: New comment added
Nikerabbit posted a comment on MediaWiki.r105251. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105251#c27136 Commit summary for MediaWiki.r105251: have the setup script run via the db update hook, so people do not have to do this separately Nikerabbit's comment: This looks wrong: + * @param DatabaseUpdater $updater|null ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105253]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105253 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105253 Old status: deferred New status: ok Commit summary for MediaWiki.r105253: Follow up to r105251; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105255]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105255 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105255 Old status: deferred New status: ok Commit summary for MediaWiki.r105255: Minor fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105258]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105258 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105258 Old status: deferred New status: ok Commit summary for MediaWiki.r105258: Additions and small fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105270]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105270 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105270 Old status: deferred New status: ok Commit summary for MediaWiki.r105270: 0.4.1 rel ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105271]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105271 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105271 Old status: deferred New status: ok Commit summary for MediaWiki.r105271: oops, its 1.4.1, and extension type should fall back to other, not parserhook ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104210]: Revision status changed
Siebrand changed the status of MediaWiki.r104210 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104210 Old status: deferred New status: resolved Commit summary for MediaWiki.r104210: else if - elseif ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105256]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105256 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105256 Old status: deferred New status: ok Commit summary for MediaWiki.r105256: up rel notes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102187]: New comment added
Siebrand posted a comment on MediaWiki.r102187. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102187#c27137 Commit summary for MediaWiki.r102187: * Merged Title::userCanRead() check in Title::getUserPermissionsErrors() * (bug 26020) Setting $wgEmailConfirmToEdit to true no longer removes diffs from recent changes feeds * Added second parameter to Title::userCan() and Title::quickUserCan() to allow callers to pass the User object to use for checks; this changes Title::userCan()'s second parameter from do expensive queries flag to User, but all callers should have been updated in r102183 * Updated callers that might throw a PermissionsError to use getUserPermissionsErrors() instead and pass the error array to the exception * Refactored duplicate code in missingPermissionError() * Moved Title::isNamespaceProtected() a bit upper and Title::userCanRead() near Title::userCan() to have related functions in the same location * Some minor refactoring in permission-related functions in Title Siebrand's comment: Done in r102896. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102880]: Revision status changed
Siebrand changed the status of MediaWiki.r102880 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102880 Old status: new New status: ok Commit summary for MediaWiki.r102880: Quick fix for r102187 breakage ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102886]: Revision status changed
Siebrand changed the status of MediaWiki.r102886 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102886 Old status: new New status: ok Commit summary for MediaWiki.r102886: Follow-up r102187: fixed two remaining hooks that were expecting 'read' to not be checked with getUserPermissionsErrors(Expensive)? hooks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102884]: Revision status changed
Siebrand changed the status of MediaWiki.r102884 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102884 Old status: new New status: ok Commit summary for MediaWiki.r102884: Make language name manipulable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102866]: Revision status changed
Siebrand changed the status of MediaWiki.r102866 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102866 Old status: new New status: ok Commit summary for MediaWiki.r102866: Shut up PHP Warning: array_values() expects parameter 1 to be array, boolean given ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102296]: Revision status changed
Siebrand changed the status of MediaWiki.r102296 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102296 Old status: new New status: ok Commit summary for MediaWiki.r102296: Skiplanguages were overwriting all other conditions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105281]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r105281 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105281 Old status: fixme New status: new Commit summary for MediaWiki.r105281: Fix Narayam for monobook skin(Bug 32124) Fix IE scrolling issue of the menu in Vector skin. Placed the menu in body instead of hidden block in the pt-narayam. On mouse hover, show it in proper position. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105296]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105296 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105296 Old status: deferred New status: ok Commit summary for MediaWiki.r105296: fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105299]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105299 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105299 Old status: deferred New status: ok Commit summary for MediaWiki.r105299: added missing items ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105302]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105302 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105302 Old status: new New status: ok Commit summary for MediaWiki.r105302: Remove unused $wgInteractiveBlockMessageCacheTimeout Fix some minor style issues Remove one redundant else block ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105386]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105386 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105386 Old status: deferred New status: ok Commit summary for MediaWiki.r105386: these are seconds, not ms, and the touched time does not get updated on render, so this caused 2h+ invalidation :/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105394]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105394 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105394 Old status: deferred New status: ok Commit summary for MediaWiki.r105394: 1.7 beta 1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki 2.0
On 07.12.2011 13:33, Dmitriy Sintsov wrote: * Trevor Parscaltpars...@wikimedia.org [Tue, 6 Dec 2011 17:21:43 -0800]: The hype of 2.0 aside, is there a guideline for what should constitute a major version number change? It looks like we are doing something like: Major.Minor.Release 1.18 = Major: 1, Minor: 18, (alpha|beta|etc.) I'm just curious what people think would constitue a major version. We've certainly had major rewrites of systems in the past that didn't seem to justify a version bump. Is there anything wrong with having version 1.249? Is there a practical reason for bumping the version at some point (like when the minor version hits tripple digits)? Also, a rewrite of MediaWiki should for sure be done in Node.js :) - Trevor Is Javascript really that good? Some people dislike prototypical inheritance, it seems that jQuery prefers to use wrappers instead (that's a kind of suboptimal architecture). Also, Google had some complains about Javascript flaws (for example primitive types don't allow high performance available in Java / C#), suggesting to replace it with something else.. Although having common clientside / serverside codebase is nice thing, for sure. And there's nothing more widespread than Javascript at client side. Also, it's object side is strong (something like Lisp with C-syntax), however it does not have generics, named parameters etc.. Dmitriy A small correction: functional side, not object side. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r103786]: New comment added
Bawolff posted a comment on MediaWiki.r103786. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103786#c27138 Commit summary for MediaWiki.r103786: (bug 27793) Make a config variable ($wgBabelUseUserLanguage) to make the Babel user language header and Users by language footer be in user language instead of page/content language. This feature is intended to be used on commons. Bawolff's comment: I mostly had it disabled by default because it seemed controversial based on r82967. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105404]: New comment added
Nikerabbit posted a comment on MediaWiki.r105404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105404#c27139 Commit summary for MediaWiki.r105404: commited for brion for review Nikerabbit's comment: have a look at mw.util.wikiScript too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105427]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105427 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105427 Old status: new New status: ok Commit summary for MediaWiki.r105427: Avoid showing the no-op link if there are no input methods available. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105404]: New comment added
Petrb posted a comment on MediaWiki.r105404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105404#c27140 Commit summary for MediaWiki.r105404: commited for brion for review Petrb's comment: Thanks for replies, please note that Brion already updated that, I will try to look it up and add as follow up. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105426]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105426 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105426 Old status: new New status: ok Commit summary for MediaWiki.r105426: CSS cleanup, Dont wait, just show the menu without animation And some spaces. Follow up r105281 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105281]: Revision status changed
Nikerabbit changed the status of MediaWiki.r105281 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105281 Old status: new New status: resolved Commit summary for MediaWiki.r105281: Fix Narayam for monobook skin(Bug 32124) Fix IE scrolling issue of the menu in Vector skin. Placed the menu in body instead of hidden block in the pt-narayam. On mouse hover, show it in proper position. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105419]: New comment added
Hashar posted a comment on MediaWiki.r105419. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105419#c27141 Commit summary for MediaWiki.r105419: (bug 32853) DBA cache broken in MW 1.18 DBABagOStuff was not refactored by r83140 which pass BagOStuff constructors an array. This patch honor the 'dir' parameter to let you override the global $wgTmpDirectory. Need backport in REL1_18 Hashar's comment: Need back port in REL1_18. WMF does not use DBA. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105428]: New comment added
Hashar posted a comment on MediaWiki.r105428. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105428#c27142 Commit summary for MediaWiki.r105428: (bug 32473) [[Special:PasswordReset]] can not be used on private wiki This patch is a quick fix for REL1_18 branch. For later: We should not have hack in Title.php to allow some specific special pages this should be made possible using SpecialPage. Would make code cleaner. Hashar's comment: Need backport (and release note) for REL1_18. WMF needs that since we have a few private wikis. Please note this patch does not refactor anything so we can get included easily in REL1_18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105428]: New comment added, and revision status changed
Bryan changed the status of MediaWiki.r105428 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105428#c27143 Old Status: new New Status: ok Commit summary for MediaWiki.r105428: (bug 32473) [[Special:PasswordReset]] can not be used on private wiki This patch is a quick fix for REL1_18 branch. For later: We should not have hack in Title.php to allow some specific special pages this should be made possible using SpecialPage. Would make code cleaner. Bryan's comment: The nice solution would probably be a new function SpecialPage::isAlwaysReadable(); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104625]: Revision status changed
Bryan changed the status of MediaWiki.r104625 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104625 Old status: new New status: ok Commit summary for MediaWiki.r104625: Merged changes from trunk up to r104623 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104625]: Revision status changed
Bryan changed the status of MediaWiki.r104625 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104625 Old status: ok New status: resolved Commit summary for MediaWiki.r104625: Merged changes from trunk up to r104623 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105432]: Revision status changed
GWicke changed the status of MediaWiki.r105432 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105432 Old status: new New status: deferred Commit summary for MediaWiki.r105432: Convert template argument production to generic inline with syntactic stop. Fix a bug in generic inline production. Nested multi-line templates are now parsed okayish. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105434]: Revision status changed
GWicke changed the status of MediaWiki.r105434 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105434 Old status: new New status: deferred Commit summary for MediaWiki.r105434: Add some documentation to syntax flags ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105418]: New comment added
Reach Out to the Truth posted a comment on MediaWiki.r105418. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105418#c27144 Commit summary for MediaWiki.r105418: Adding the License for Madan font. Upstream just says that it is GPL. So following the license text used by Fedora package maintainers. It is a copy of the text given inside the font. Reach Out to the Truth's comment: According to the [[w:All rights reserved|Wikipedia article]], all rights reserved doesn't do anything that copyright law doesn't do automatically. It's effectively meaningless. I've seen the phrase used in a number of free software projects, myself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki 2.0
On Wed, 07 Dec 2011 05:52:31 -0800, Dmitriy Sintsov ques...@rambler.ru
wrote:
On 07.12.2011 13:33, Dmitriy Sintsov wrote:
* Trevor Parscaltpars...@wikimedia.org [Tue, 6 Dec 2011 17:21:43
-0800]:
The hype of 2.0 aside, is there a guideline for what should
constitute
a
major version number change?
It looks like we are doing something like: Major.Minor.Release
1.18 = Major: 1, Minor: 18, (alpha|beta|etc.)
I'm just curious what people think would constitue a major version.
We've
certainly had major rewrites of systems in the past that didn't seem
to
justify a version bump. Is there anything wrong with having version
1.249?
Is there a practical reason for bumping the version at some point
(like
when the minor version hits tripple digits)?
Also, a rewrite of MediaWiki should for sure be done in Node.js :)
- Trevor
Is Javascript really that good? Some people dislike prototypical
inheritance, it seems that jQuery prefers to use wrappers instead
(that's a kind of suboptimal architecture). Also, Google had some
complains about Javascript flaws (for example primitive types don't
allow high performance available in Java / C#), suggesting to replace it
with something else.. Although having common clientside / serverside
codebase is nice thing, for sure. And there's nothing more widespread
than Javascript at client side. Also, it's object side is strong
(something like Lisp with C-syntax), however it does not have generics,
named parameters etc..
Dmitriy
A small correction: functional side, not object side.
Dmitriy
Generics, named parameters? Why are you picking on things that even php
doesn't have.
If you want names parameters JS is even closer than php. It has a more
concise object syntax which means that foo({asdf: 1}) is barely any longer
than a normal function call to type, compared to the php equivilant which
is foo(array('asdf' = 1)).
And jQuery is jQuery. It uses it's funky syntax for a reason related to
what it does.
Now I AM a JavaScript on the server guy (I have a company web application
that runs with server side JavaScript and I even participated in the
CommonJS pesudo-wg group for awhile) but I'm not so sure about Node.js
being the way forward.
Actually, aiming for something with ES5+harmony/next features might even
be the best. Traceur could add the features client side.
var {Foo, Bar} = asdf;
var [asdf, qwery] = arr;
function foo(bar = 5, ...rest) {}
for ( let key in obj ) {}
(x for ( x of list ) if (x % 2 === 0))
module Foo {
export let bar = 42;
}
var obj = {
[variable]: value,
foo(bar) { return bar+1; }
get baz() { return 5; }
};
let text = qzx$cv;
asdfzx$cvqwerty.match(re`^adsf${text}qwerty`);
foobar.startsWith(foo);
typeof null === null;
--
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki 2.0
On 7 December 2011 02:34, Dan Nessett dness...@yahoo.com wrote: 3. It would help to get it down to 2. I assume my comments apply to many other small wikis that use MW as well. Most operate on a shoe string budget. Tried a caching system? My wiki gets 3000+ visitors a day (I don't know how many Citizendium gets). But my server (costing 49EUR a month) can easily manage that plus several other websites including running some game servers as well. All I am saying is; it may be too easy to blame it on MW alone. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mediawiki 2.0
On Wed, 07 Dec 2011 12:54:22 +1100, Tim Starling wrote: On 07/12/11 12:34, Dan Nessett wrote: On Wed, 07 Dec 2011 12:15:41 +1100, Tim Starling wrote: How many servers do you have? 3. It would help to get it down to 2. I assume my comments apply to many other small wikis that use MW as well. Most operate on a shoe string budget. You should try running MediaWiki on HipHop. See http://www.mediawiki.org/wiki/HipHop It's not possible to pay developers to rewrite MediaWiki for less than what it would cost to buy a server. But maybe getting a particular MW installation to run on HipHop with a reduced feature set would be in the same order of magnitude of cost. -- Tim Starling Are there any production wikis running MW over HipHop? -- -- Dan Nessett ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Fundraising bug triage TODAY 2100UTC (was Fwd: Fundraising -- use your technical skills to help)
Just a reminder this will be happening today at 2100UTC/1pm PST! -- Forwarded message -- From: Mark A. Hershberger mhershber...@wikimedia.org Date: Tue, Dec 6, 2011 at 3:23 PM Subject: Fundraising -- use your technical skills to help To: wikitech-l wikitec...@wikimedia.org, foundation-l foundatio...@lists.wikimedia.org Cc: Arthur Richards aricha...@wikimedia.org What: Fundraising triage When: Wednesday, December 7, 2100UTC Time zone conversion: http://hexm.de/bc Where: #wikimedia-dev on freenode Use http://webchat.freenode.net/?channels=wikimedia-dev if you don't have an IRC client Etherpad: http://etherpad.wikimedia.org/BugTriage-funcom Tomorrow, I'll be holding an IRC meeting on the open fundraising-related issues that Arthur Richards and I identified today as things that could benefit from community involvement. If you are able to contribute any help on these issues -- several of which are targeted to the CentralNotice system -- you will improve the experience of many users of the Wikimedia projects. * https://bugzilla.wikimedia.org/17108 Make Hide Cookies notice independent * https://bugzilla.wikimedia.org/24950 Make CentralNotice option checkboxes sortable * https://bugzilla.wikimedia.org/26026 Add API module for Special:FundraiserStatistics * https://bugzilla.wikimedia.org/26387 Add better key to Fundraiser stats page * https://bugzilla.wikimedia.org/30818 Special:FundraisingStatistics should display selected yea... * https://bugzilla.wikimedia.org/32441 Year filtering on Special:FundraiserStatistics broken * https://bugzilla.wikimedia.org/32536 CentralNotice API Bring your javascript and PHP chops and I'll see you there! Mark. -- Arthur Richards Software Engineer Fundraising/Features/Offline/Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] WikiEditor Preview tab: unparsed wikitext
I have a parser function that is not being rendered properly by the experimental Preview tab in WikiEditor. The function does the following: * It add a custom property foo to the ParserOutput object, with value bar * It hooks OutputPageBeforeHTML to render the value bar When I use the Save Page or Show Preview buttons below the edit box everything works fine. With the experimental Preview tab, though, the value doesn't get rendered. (It is in the ParserOutput object though.) I'm guessing that OutputPageBeforeHTML doesn't get called by the Preview tab. I also tried hooking EditPageGetPreviewText to render the value also, but that doesn't work either with the Preview tab. Any advice appreciated. Should I be using a better/additional hook? Thanks, DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Reason for having php5-common pinned?
Do we have a reason we have php5-common pinned in puppet? (see generic-definitions.pp::145 generic::webserver::php5 ) The reason I ask is that with this, another generic definition (generic::webserver::php5-mysql) breaks due to the dependancy of 5.3.2-2wm1 , while the pinning causes the installation of 5.3.2-1ubuntu4.10 I would change the generic::webserver::php5 definition to remove the pin, but I want to make sure that nothing breaks first. Leslie -- Leslie Carr Wikimedia Foundation AS 14907, 43821 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r105455]: New comment added, and revision status changed
Siebrand changed the status of MediaWiki.r105455 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105455#c27145
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r105455:
work on ui
Siebrand's comment:
* time and date should be separated in running sentences
* {{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
