[MediaWiki-CodeReview] [MediaWiki r108087]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108087 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108087 Old status: new New status: ok Commit summary for MediaWiki.r108087: * (bug 33525) clearTagHooks doesn't clear function hooks. * (bug 33523) Function tag hooks don't appear on Special:Version. Patches by Nikola Kovacs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107646]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107646 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107646 Old status: new New status: ok Commit summary for MediaWiki.r107646: fix for bug 32441, making the year toggles work consistantly for all the charts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107409]: New comment added
Nikerabbit posted a comment on MediaWiki.r107409. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107409#c28966 Commit summary for MediaWiki.r107409: * Removed deprecated features ** Old style preference retrieval has been removed ** Old style group based restrictions have been removed * Removed unused features ** The username synching was never used, as support wasn't added to core for it, so it's been removed * Debug message clean up. Removed redundant messages, clarified other messages * Added wrapper functions for all ldap_* functions used; did this to remove usage of @ldap_* in a cleaner way Nikerabbit's comment: This code hurts my eyes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107811]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107811 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107811 Old status: new New status: ok Commit summary for MediaWiki.r107811: Make mw.jqueryMsg understand gender. Add qunit testcases. Followup r107808 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107282]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107282 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107282 Old status: new New status: ok Commit summary for MediaWiki.r107282: Remove superfluous newlines. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107283]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107283 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107283 Old status: new New status: ok Commit summary for MediaWiki.r107283: Make PythonSingleFFS respect codeMap when reading. Probably no support for writing yet. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103748]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r103748 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103748#c28967 Old Status: new New Status: ok Commit summary for MediaWiki.r103748: Narayam: Lekhani, a new scheme for Odiya with help from Subashish. Santhosh.thottingal's comment: I am marking the revision ok, but if we don't have a clear idea about the transliteration scheme, instead of keeping it in beta forever, better remove. I am not sure if it is complete. If so let us know. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107364]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107364 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107364 Old status: new New status: ok Commit summary for MediaWiki.r107364: Adding workflow state color to Special:MessageGroupStats. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107377]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107377 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107377 Old status: new New status: ok Commit summary for MediaWiki.r107377: loadPagesFromDB() should query DB_MASTER, otherwise old data is presented right after marking/updating a page for translation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107642]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107642 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107642 Old status: new New status: ok Commit summary for MediaWiki.r107642: Follow up to r107367. According to Niklas' request there, changed the parameters to the logging message for group review. $3 is now Special:Translate for the group and the language and $4 is the language. Also removed some unneeded comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107868]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107868 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107868 Old status: new New status: ok Commit summary for MediaWiki.r107868: * Run stylize.php on Babel, cldr, Narayam, Translate and WebFonts. * Remove a few superfluous empty lines. * Remove unneeded messages from TranslateGroupDescriptions.i18n.php. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107912]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107912 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107912 Old status: new New status: ok Commit summary for MediaWiki.r107912: Added a simplified Hebrew layout and moved Gujarati alphabetically. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108023]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108023 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108023 Old status: new New status: ok Commit summary for MediaWiki.r108023: Tweak 'translate-dynagroup-recent-desc'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107808]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107808 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107808 Old status: new New status: ok Commit summary for MediaWiki.r107808: Add gender support. This method is useful only if we have parser that can understand gender at client side. Test cases and mw.jqueryMsg changes in next commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107824]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107824 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107824
Old status: new
New status: ok
Commit summary for MediaWiki.r107824:
Parser can take mw.user too along with male, female for {{gender:$1|..}}
If the parameter passed is mw.user, use the gender from mw.user.options. If
not, use the passed gender.
Update the qunit tests.
Update the documentation.
Followup r107811
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108113]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108113 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108113 Old status: deferred New status: ok Commit summary for MediaWiki.r108113: added bug nr in rel notes and moved some hooks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108114]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108114 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108114#c28968 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r108114: Fixed internationalization of magic words Nikerabbit's comment: Uses spaces instead of tabs. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki
On Thu, Jan 5, 2012 at 1:47 AM, K. Peachey p858sn...@gmail.com wrote: Commons folk doesn't magically delete anything unless there is a reason, nor do they instantly delete in most cases. If peoples uploads are continently getting tagged for deletion, They should look at why they are getting tagged. For one example, recently a fellow wikipedian got a picture he had taken himself deleted because someone else had uploaded it somewhere else, so they didn't believe it was his. I myself have had pictures from US government almost deleted because I only specified which government institution it came from, not what page they could be found (saved because I happened to find them after being notified of my terrible crime). Copyright diligence is good, copyright paranoia is not. -- André Engels, andreeng...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108115]: Revision status changed
Hashar changed the status of MediaWiki.r108115 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108115 Old status: new New status: ok Commit summary for MediaWiki.r108115: Bug 33514 - Make category columns (table cells) equal width Author: Erwin Dokter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108112]: Revision status changed
Hashar changed the status of MediaWiki.r108112 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108112 Old status: new New status: ok Commit summary for MediaWiki.r108112: Fix Bug 33496 - Misleading comment regarding preformatted font in commonElements.css Author: Erwin Dokter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108120]: New comment added, and revision status changed
Raymond changed the status of MediaWiki.r108120 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108120#c28969 Old Status: new New Status: fixme Commit summary for MediaWiki.r108120: Add Special:WebFonts for previewing the fonts and download. i18n card #283 Raymond's comment: Please add an alias file for translation the special page name. Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108122]: New comment added, and revision status changed
Raymond changed the status of MediaWiki.r108122 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108122#c28970
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r108122:
Add the missing i18n file in r108120.
Raymond's comment:
I do not see the need for an extra i18n file. Could it not be integrated into
WebFounts.i18n.php, couldn't it?
Typo in key name: ...sampltext... - ...sampletext...
'webfonts-preview-sampltext' = 'The quick brown fox jumps over the lazy dog',
Please replace Download in the first sentence with
nowiki{{int:webfonts-preview-download}}/nowiki to ensure the translations
are consistent.
'webfonts-preview-installing-fonts-text' = 'You can download a font using the
Download link given above. To install the downloaded font in your computer,
please refer [//mediawiki.org/wiki/Special:MyLanguage/Help:How_to_install_fonts
this documentation]',
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107424]: Revision status changed
Hashar changed the status of MediaWiki.r107424 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107424 Old status: new New status: ok Commit summary for MediaWiki.r107424: Per Reedy, fix for r107386: fix usage of undefined variable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108121]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108121 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108121 Old status: new New status: ok Commit summary for MediaWiki.r108121: Minor refactoring: * remove unused constant CONTRIBUTIONSCORES_EXTPATH * replace CONTRIBUTIONSCORES_PATH constant by more often used $dir * remove superfluous getDescription() * remove use of some unneeded/unused globals * use Html functions instead of raw HTML in some cases. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108121]: New comment added
Nikerabbit posted a comment on MediaWiki.r108121. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108121#c28971 Commit summary for MediaWiki.r108121: Minor refactoring: * remove unused constant CONTRIBUTIONSCORES_EXTPATH * replace CONTRIBUTIONSCORES_PATH constant by more often used $dir * remove superfluous getDescription() * remove use of some unneeded/unused globals * use Html functions instead of raw HTML in some cases. Nikerabbit's comment: It's also possible to do $dir/ContributionScores.alias.php. It's matter of taste. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108126]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108126 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108126 Old status: new New status: ok Commit summary for MediaWiki.r108126: Add additional parameter $altUserName to Linker::userLink to make it possible to override the displayed user name. Renamed $userText to $userName following Nikerabbit's advice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108066]: Revision status changed
Hashar changed the status of MediaWiki.r108066 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108066 Old status: new New status: ok Commit summary for MediaWiki.r108066: re r102301 — apply Krinkle's suggested fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102301]: Revision status changed
Hashar changed the status of MediaWiki.r102301 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102301 Old status: new New status: resolved Commit summary for MediaWiki.r102301: Fix Bug #32047: in table with class=sortable, thead is before caption Apply fomafix's patch for jquery.tablesorter.js (also reported upstream: https://forum.jquery.com/topic/in-table-with-class-sortable-thead-is-before-caption (currently in moderation) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108099]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108099 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108099 Old status: new New status: ok Commit summary for MediaWiki.r108099: Documentation Remove unused variable Add wfProfileOut( __METHOD__ ); before dieUsage() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108055]: Revision status changed
Hashar changed the status of MediaWiki.r108055 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108055 Old status: new New status: ok Commit summary for MediaWiki.r108055: Bug 33494 - Remove redundant CSS from chick/main.css Patch by Erwin Dokter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108108]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108108 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108108 Old status: new New status: ok Commit summary for MediaWiki.r108108: Update deprecated code Add documentation Remove unused globals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108110]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108110 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108110 Old status: new New status: ok Commit summary for MediaWiki.r108110: Update deprecated code Fix some inconsistant returns Remove unused globals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108072]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108072 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108072 Old status: new New status: ok Commit summary for MediaWiki.r108072: Fix r104178 like r108070 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108070]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108070 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108070 Old status: new New status: ok Commit summary for MediaWiki.r108070: r100516 didn't merge into 1.18wmf1 so well in r107970 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108045]: New comment added
Nikerabbit posted a comment on MediaWiki.r108045. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108045#c28972 Commit summary for MediaWiki.r108045: * (bug 29102) Upgrade fails Unknown character set: 'mysql4'. Merges r108044 Nikerabbit's comment: RELEASE-NOTES entry could more descriptive. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107979]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107979 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107979 Old status: new New status: ok Commit summary for MediaWiki.r107979: Merge r107978 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107978]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107978 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107978 Old status: new New status: ok Commit summary for MediaWiki.r107978: Fix undefined call to context()-getLang() Added getLanguage functions to RequestContext also (for ease, hah!) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107970]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107970 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107970 Old status: new New status: resolved Commit summary for MediaWiki.r107970: MFT r100516, r103260, r103315, r103378, r103382, r104862 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107957]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107957 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107957 Old status: new New status: ok Commit summary for MediaWiki.r107957: Merge r107913 (merges r105007 from trunk) and r107924 (merges r106992 from trunk) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107956]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107956 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107956 Old status: new New status: ok Commit summary for MediaWiki.r107956: MFT r104030, r104033, r104146, r104671 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107955]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107955 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107955 Old status: new New status: ok Commit summary for MediaWiki.r107955: Add getLanguage for ease (then we know it exists!) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107577]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107577 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107577 Old status: new New status: ok Commit summary for MediaWiki.r107577: Bug 33252 - WikimediaMaintenance maintenance scripts include Maintenance.php from the wrong place And there always has to be one that's the odd one out... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107340]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107340 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107340 Old status: new New status: ok Commit summary for MediaWiki.r107340: MFT r107337 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107339]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107339 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107339 Old status: new New status: ok Commit summary for MediaWiki.r107339: 5.2 hacks? Pffft - Long Live 5.2.3! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107339]: New comment added
Nikerabbit posted a comment on MediaWiki.r107339. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107339#c28973 Commit summary for MediaWiki.r107339: 5.2 hacks? Pffft - Long Live 5.2.3! Nikerabbit's comment: Weird way to indent a function call. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108122]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108122 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108122 Old status: fixme New status: new Commit summary for MediaWiki.r108122: Add the missing i18n file in r108120. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107575]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107575 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107575 Old status: new New status: ok Commit summary for MediaWiki.r107575: Bug 33252 - WikimediaMaintenance maintenance scripts include Maintenance.php from the wrong place Update all scripts trying to require Maintenance to require WikimediaMaintenance, and change the parent class it's extending from ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108120]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108120 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108120 Old status: fixme New status: new Commit summary for MediaWiki.r108120: Add Special:WebFonts for previewing the fonts and download. i18n card #283 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98702]: Revision status changed
Nikerabbit changed the status of MediaWiki.r98702 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98702 Old status: new New status: ok Commit summary for MediaWiki.r98702: Followup r98563, improvement to javascript per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94465]: Revision status changed
Hashar changed the status of MediaWiki.r94465 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94465 Old status: new New status: resolved Commit summary for MediaWiki.r94465: Add code to the sanitizer to convert presontational attributes that were removed in html5 into inline css. This allows wiki to keep using them in short loose WikiText but still output valid modern markup. Note that there were some attributes excluded. Namely stuff on img and object, and the table cellspacing and cellpading which aren't easily converted into inline css. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96188]: Revision status changed
Hashar changed the status of MediaWiki.r96188 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96188 Old status: new New status: ok Commit summary for MediaWiki.r96188: Expand r96170's support for space separated attributes with support for boolean keys such as array( 'class' = array( 'selected' = true ) ) to match our array( 'checked' = false ) support. As per discussion with Krinkle make sure that in array( 'foo', 'foo' = false, 'foo' ) the 'foo' key is authoritive. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98563]: New comment added
Nikerabbit posted a comment on MediaWiki.r98563. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98563#c28974 Commit summary for MediaWiki.r98563: Followup r98500, conversion of the Javascript to use jQuery fully. It also makes the Javascript work outside of debug=1 (oops) There's a couple of WTF moments in the code, this is really due to some issues with the PHP side of stuff. It really needs some TLC but for right now it works, I'll come back to it before 1.19 and clean it up. Nikerabbit's comment: Don't you want to use .text here and elsewhere: + .html( mw.msg( 'categorytree-collapse-bullet' ) ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108125]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108125 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108125 Old status: new New status: ok Commit summary for MediaWiki.r108125: additional monospaced font-family hacks font-family: monospace, monospace; Is elegant and has my preference :-) font-family: monospace, DOESNOTEXISTREALLY; Really make it obvious follow r108123 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108128]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108128 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108128 Old status: new New status: ok Commit summary for MediaWiki.r108128: stylize.php. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108129]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108129 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108129#c28975 Old Status: new New Status: ok Commit summary for MediaWiki.r108129: Fix typo in r108127. Nikerabbit's comment: Ugly :o ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108127]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108127 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108127#c28976 Old Status: new New Status: resolved Commit summary for MediaWiki.r108127: * format number output of cscore parser function. * add $wgContribScoresUseRealName to allow display of real user names per request[1]. Requires MediaWiki 1.19 alpha r108126. * remove trailing whitespace. [1] https://www.mediawiki.org/wiki/Thread:Extension_talk:Contribution_Scores/Show_real_name_or_e-mail_instead_of_username%3F Nikerabbit's comment: The new variable could use some docs. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108123]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108123 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108123 Old status: new New status: ok Commit summary for MediaWiki.r108123: test rendering font-family for monospaced fonts follow r108112 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108122]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108122 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108122 Old status: new New status: resolved Commit summary for MediaWiki.r108122: Add the missing i18n file in r108120. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100915]: Revision status changed
Hashar changed the status of MediaWiki.r100915 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100915 Old status: new New status: resolved Commit summary for MediaWiki.r100915: * Allow passing in a blacklist into wfIsBadImage() * Added wfIsBadImage() unit tests ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107634]: New comment added
Nikerabbit posted a comment on MediaWiki.r107634. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107634#c28979 Commit summary for MediaWiki.r107634: First commit of new extension - GeoData, that allows to store and query page geographical coordinates. No i18n yet, not committing 2 API modules because they need to adapt to latest changes Nikerabbit's comment: Who wants this and why? How is this extension used? Is it compatible with SMW? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107623]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107623 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107623
Old status: new
New status: ok
Commit summary for MediaWiki.r107623:
(bug 31469) Make sure tracking category messages expand variables like
{{NAMESPACE}} relative to the Title of the currently being parsed page.
Basically wfMsgForContent expands messages with wrong title while doing
linksupdate stuff via job queue. For the broken file tracking category
(r86534),Wikipedia folk want to sort the page into different categories based
on namespace, and for some namespaces not categorize them at all (After all, a
broken file link in a talk namespace is often not a bad thing).
Anyhow, explicitly set the title object for the message using wfMessage.
There's probably deeper issues here in regards to why wfMsg et al is using
wrong title, but this should fix the immediate issue.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108115]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108115 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108115 Old status: ok New status: new Commit summary for MediaWiki.r108115: Bug 33514 - Make category columns (table cells) equal width Author: Erwin Dokter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108006]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108006 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108006 Old status: new New status: ok Commit summary for MediaWiki.r108006: ResourceLoaderTestModules doc: better wording follow r107993 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108124]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108124 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108124#c28980 Old Status: new New Status: ok Commit summary for MediaWiki.r108124: CSS and JS cleanup. Misc JS fixes Santhosh.thottingal's comment: Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108131]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108131 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108131 Old status: new New status: ok Commit summary for MediaWiki.r108131: Add some documentation for settings per CR on r108127. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105522]: Revision status changed
Hashar changed the status of MediaWiki.r105522 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105522 Old status: new New status: ok Commit summary for MediaWiki.r105522: Gender is already needed in addResultToCache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105954]: Revision status changed
Hashar changed the status of MediaWiki.r105954 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105954 Old status: new New status: resolved Commit summary for MediaWiki.r105954: feedback - move messages, etc from uploadwizard to core ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108115]: Revision status changed
Hashar changed the status of MediaWiki.r108115 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108115 Old status: new New status: ok Commit summary for MediaWiki.r108115: Bug 33514 - Make category columns (table cells) equal width Author: Erwin Dokter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108115]: New comment added
Hashar posted a comment on MediaWiki.r108115. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108115#c28981 Commit summary for MediaWiki.r108115: Bug 33514 - Make category columns (table cells) equal width Author: Erwin Dokter Hashar's comment: Nikerabbit, I am not sure why you marked this one new :-D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108115]: New comment added
Nikerabbit posted a comment on MediaWiki.r108115. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108115#c28982 Commit summary for MediaWiki.r108115: Bug 33514 - Make category columns (table cells) equal width Author: Erwin Dokter Nikerabbit's comment: Because I keep tabs open for a while and CR doesn't detect conflicts. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107304]: Revision status changed
Hashar changed the status of MediaWiki.r107304 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107304 Old status: new New status: ok Commit summary for MediaWiki.r107304: Fixed undefined var from r106280 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106664]: New comment added
Hashar posted a comment on MediaWiki.r106664. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106664#c28983 Commit summary for MediaWiki.r106664: Create new extension base MarkAsHelpful. Hashar's comment: You might want to create a homepage at https://www.mediawiki.org/wiki/Extension:MarkAsHelpful :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108120]: Revision status changed
Siebrand changed the status of MediaWiki.r108120 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108120 Old status: new New status: fixme Commit summary for MediaWiki.r108120: Add Special:WebFonts for previewing the fonts and download. i18n card #283 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108120]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108120 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108120 Old status: fixme New status: new Commit summary for MediaWiki.r108120: Add Special:WebFonts for previewing the fonts and download. i18n card #283 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added
Hashar posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28984 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table creation. Hashar's comment: I can not reproduce the issue. I have locally reverted that revision, set up $wgMainCacheType= CACHE_DB; and launched the parser tests. No issue! From my debug log: CACHES: SqlBagOStuff[main] SqlBagOStuff[message] SqlBagOStuff[parser] So I am wondering if this is really needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108132]: Revision status changed
Hashar changed the status of MediaWiki.r108132 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108132 Old status: new New status: ok Commit summary for MediaWiki.r108132: It's not filename but module name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107634]: New comment added
MaxSem posted a comment on MediaWiki.r107634. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107634#c28985 Commit summary for MediaWiki.r107634: First commit of new extension - GeoData, that allows to store and query page geographical coordinates. No i18n yet, not committing 2 API modules because they need to adapt to latest changes MaxSem's comment: This extension is needed by the mobile team that currently relies on third-party tools for geolocation. SMW is a whaladon that is not going to run on our cluster any time soon, unlike this lightweight extension designed with WMF use in mind. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107933]: Revision status changed
Hashar changed the status of MediaWiki.r107933 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107933 Old status: new New status: ok Commit summary for MediaWiki.r107933: Show error message if no score images were generated. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107507]: Revision status changed
Hashar changed the status of MediaWiki.r107507 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107507 Old status: new New status: ok Commit summary for MediaWiki.r107507: Added some comments about unusual language handling behavior ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108031]: Revision status changed
Hashar changed the status of MediaWiki.r108031 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108031 Old status: new New status: ok Commit summary for MediaWiki.r108031: Follow-up r102160: removed arrows from tooltips ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added
Hashar posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c28986 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register Hashar's comment: We could either: * hack the upstream jquery.tooltip javascript to append the tooltip to $(#bodyContent) * Wait for Jquery UI 1.9 which has a clean tooltip: http://wiki.jqueryui.com/Tooltip ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added
Hashar posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c28987 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register Hashar's comment: Anyone know if there will be compatibility issues with popups navigator ? What is the popups navigator? The Cite popup only trigger on the links matching .biblio-cite-link,sup.reference a ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added
Hashar posted a comment on MediaWiki.r107351. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28988 Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at http://stackoverflow.com/questions/5794640/how-to-convert-xcf-to-png-using-gimp-from-the-command-line is probably better. * File::maybeDoTransform() since (at least) r106752 neglects what BitmapHandler::getThumbType() returns, so add support for that. * Add $wgImageMagickIdentifyCommand to avoid writing a parser for XCF metadata. Hashar's comment: Part of The Plan ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108135]: Revision status changed
Siebrand changed the status of MediaWiki.r108135 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108135 Old status: new New status: ok Commit summary for MediaWiki.r108135: Remove SpecialWebFonts.i18n.php, merge the content to WebFonts.i18n.php Followup r108120 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108130]: Revision status changed
Siebrand changed the status of MediaWiki.r108130 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108130 Old status: new New status: ok Commit summary for MediaWiki.r108130: Followup r108120 Add alias file. Fix a typo in message key. Simplify Html:openElement with Html:Element. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107268]: Revision status changed
Siebrand changed the status of MediaWiki.r107268 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107268 Old status: new New status: ok Commit summary for MediaWiki.r107268: Followup r107052 - purge the cache too While at it, fixed a bug in figureMessage, where it would strip the section name from Translations:FooPage/section and not identify message FooPage as valid ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108137]: Revision status changed
Reedy changed the status of MediaWiki.r108137 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108137 Old status: new New status: ok Commit summary for MediaWiki.r108137: Accessor for LinksUpdate's parser output ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108136]: Revision status changed
^demon changed the status of MediaWiki.r108136 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108136 Old status: new New status: ok Commit summary for MediaWiki.r108136: parserTest need to clone user_former_groups table Not sure why it is suddenly needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108033]: Revision status changed
^demon changed the status of MediaWiki.r108033 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108033 Old status: new New status: ok Commit summary for MediaWiki.r108033: mime.types: sort opendocument entries Sorted all application/vnd.oasis.opendocument entries, no other change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108050]: New comment added
^demon posted a comment on MediaWiki.r108050.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108050#c28989
Commit summary for MediaWiki.r108050:
Attempt to avoid a warning I got during input:
$ 7z x -so ../dewikisource-20111012-pages-meta-history.xml.7z | php
maintenance/importDump.php
7-Zip [64] 9.20 Copyright (c) 1999-2010 Igor Pavlov 2010-11-18
p7zip Version 9.20 (locale=en_US.UTF-8,Utf16=on,HugeFiles=on,4 CPUs)
Processing archive: ../dewikisource-20111012-pages-meta-history.xml.7z
Extracting dewikisource-20111012-pages-meta-history.xml
PHP Notice: Undefined index: wgExtensionAliasesFiles in
/home/mah/work/code/mediawiki/mw-
svn/includes/cache/CacheDependency.php on line 386
PHP Stack trace:
PHP 1. {main}()
/home/mah/work/code/mediawiki/mw-svn/maintenance/importDump.php:0
PHP 2. require_once()
/home/mah/work/code/mediawiki/mw-svn/maintenance/importDump.php:287
PHP 3. BackupReader-execute()
/home/mah/work/code/mediawiki/mw-svn/maintenance/doMaintenance.php:105
PHP 4. BackupReader-importFromStdin()
/home/mah/work/code/mediawiki/mw-svn/maintenance/importDump.php:93
PHP 5. BackupReader-importFromHandle()
/home/mah/work/code/mediawiki/mw-svn/maintenance/importDump.php:249
PHP 6. WikiImporter-doImport()
/home/mah/work/code/mediawiki/mw-svn/maintenance/importDump.php:282
PHP 7. WikiImporter-handlePage()
/home/mah/work/code/mediawiki/mw-svn/includes/Import.php:411
PHP 8. WikiImporter-processTitle()
/home/mah/work/code/mediawiki/mw-svn/includes/Import.php:534
PHP 9. Title-userCan()
/home/mah/work/code/mediawiki/mw-svn/includes/Import.php:788
PHP 10. Title-getUserPermissionsErrorsInternal()
/home/mah/work/code/mediawiki/mw-svn/includes/Title.php:1557
PHP 11. Title-checkSpecialsAndNSPermissions()
/home/mah/work/code/mediawiki/mw-svn/includes/Title.php:2118
PHP 12. Title-getNsText()
/home/mah/work/code/mediawiki/mw-svn/includes/Title.php:1728
PHP 13. Language-needsGenderDistinction()
/home/mah/work/code/mediawiki/mw-svn/includes/Title.php:723
PHP 14. LocalisationCache-getItem()
/home/mah/work/code/mediawiki/mw-svn/languages/Language.php:442
PHP 15. LocalisationCache-loadItem()
/home/mah/work/code/mediawiki/mw-svn/includes/LocalisationCache.php:218
PHP 16. LocalisationCache-initLanguage()
/home/mah/work/code/mediawiki/mw-svn/includes/LocalisationCache.php:283
PHP 17. LocalisationCache-isExpired()
/home/mah/work/code/mediawiki/mw-svn/includes/LocalisationCache.php:395
PHP 18. GlobalDependency-isExpired()
/home/mah/work/code/mediawiki/mw-svn/includes/LocalisationCache.php:367
^demon's comment:
Probably ok, but I'm curious why the warning was happening to begin with.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108104]: Revision status changed
^demon changed the status of MediaWiki.r108104 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108104 Old status: new New status: ok Commit summary for MediaWiki.r108104: Followup r105809; Split up the tests with a dataProvider and add a round trip test. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108021]: Revision status changed
^demon changed the status of MediaWiki.r108021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108021 Old status: new New status: ok Commit summary for MediaWiki.r108021: document getImageSize() return format Return array should return the same kind of array that PHP internal method getimagesize() returns. See upstream doc: http://www.php.net/getimagesize ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108017]: Revision status changed
^demon changed the status of MediaWiki.r108017 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108017 Old status: new New status: ok Commit summary for MediaWiki.r108017: enhance size tooltip on changelist follow r104085 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108049]: Revision status changed
^demon changed the status of MediaWiki.r108049 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108049 Old status: new New status: ok Commit summary for MediaWiki.r108049: application/vnd.oasis.opendocument.database [OFFICE] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108009]: Revision status changed
^demon changed the status of MediaWiki.r108009 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108009 Old status: new New status: ok Commit summary for MediaWiki.r108009: Made installer not install on SQLite less than 3.3.7, would prevent stuff like bug 25746. Also, threw MSSQL out of release notes - it can't be installed through the usual means. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107351]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r107351 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107351#c28990 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r107351: * First simple XCF thumbnailing. Convert from ImageMagick has buggy support for XCF, though, so one of the solutions at http://stackoverflow.com/questions/5794640/how-to-convert-xcf-to-png-using-gimp-from-the-command-line is probably better. * File::maybeDoTransform() since (at least) r106752 neglects what BitmapHandler::getThumbType() returns, so add support for that. * Add $wgImageMagickIdentifyCommand to avoid writing a parser for XCF metadata. Hashar's comment: I have implement an header reader in r108141. Thus we are no more using ImageMagick identify. Marking resolved. Removing tags hashar hexmode ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108109]: Revision status changed
^demon changed the status of MediaWiki.r108109 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108109 Old status: new New status: ok Commit summary for MediaWiki.r108109: In FSFile: * Added getMimeType() and extensionFromPath() functions. * A few other minor code and comment cleanups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107994]: Revision status changed
^demon changed the status of MediaWiki.r107994 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107994 Old status: new New status: ok Commit summary for MediaWiki.r107994: Follow-up r107376: disable test by default, causes failures in some configurations ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108005]: Revision status changed
^demon changed the status of MediaWiki.r108005 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108005 Old status: new New status: ok Commit summary for MediaWiki.r108005: Made WebInstaller::showStatusMessage() look uniformly for one and multiple errors/warnings per status ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107992]: Revision status changed
^demon changed the status of MediaWiki.r107992 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107992 Old status: new New status: ok Commit summary for MediaWiki.r107992: Fix for r107945: also partially revert r107842 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
