Re: [Wikitech-l] Instructions for setting up regression tests on local machine?
On Fri, Jan 6, 2012 at 8:06 PM, OQ overlo...@gmail.com wrote: On Fri, Jan 6, 2012 at 12:56 PM, Dan Nessett dness...@yahoo.com wrote: On Thu, 05 Jan 2012 14:03:14 -0600, OQ wrote: uninstall the pear version and do a make install. Didn't work. # make install ./install-phpunit.sh Installing phpunit with pear Channel pear.phpunit.de is already initialized Adding Channel components.ez.no succeeded Discovery of channel components.ez.no succeeded Channel pear.symfony-project.com is already initialized Did not download optional dependencies: pear/Image_GraphViz, pear/Log, symfony/YAML, use --alldeps to download automatically phpunit/PHPUnit can optionally use package pear/Image_GraphViz (version = 1.2.1) phpunit/PHPUnit can optionally use package pear/Log phpunit/PHPUnit can optionally use package symfony/YAML (version = 1.0.2) downloading PHPUnit-3.4.15.tgz ... Starting to download PHPUnit-3.4.15.tgz (255,036 bytes) .done: 255,036 bytes install ok: channel://pear.phpunit.de/PHPUnit-3.4.15 Dunno then, it installed 3.6.3 for me. Hopefully somebody here knows a bit more about pear :) I remember having a similar issue when I first installed phpunit on my Mac. Although I don't know the exact command, I remember having to update some central installer proces by PEAR (channel ?) to the latest version, which still had an old version in it's (local?) database. Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
Hashar posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29163 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) Hashar's comment: So how do we run a single parser test ? Or a set of tests using --filter? I can understand the need to avoid duplicate code, but that change sounds like a regression to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108367]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r108367 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108367#c29164 Old Status: fixme New Status: reverted Commit summary for MediaWiki.r108367: Fix the regression pointed out by Robin in r105855. Hashar's comment: Reverted by r108389. Please submit parsertests update in the same commit so we avoid breaking the tests :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108333]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108333 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108333 Old status: new New status: resolved Commit summary for MediaWiki.r108333: Automatic creation of workflow states. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108386]: New comment added
Nikerabbit posted a comment on MediaWiki.r108386. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108386#c29165 Commit summary for MediaWiki.r108386: * Avoid double parsing of the description * Use FuzzyBot to create the pages, isntead of a random user * Read the page contents for the definition if the page exists * Add the configuration global for dependency for message group cache Nikerabbit's comment: Was followup to r108333. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108191]: Revision status changed
Krinkle changed the status of MediaWiki.r108191 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108191 Old status: new New status: ok Commit summary for MediaWiki.r108191: Fix a race condition in classic edit toolbar setup mediawiki.action.edit used to call mw.toolbar.init on its own during DOMReady -- this required that the module already be loaded *before* DOMReady, *and* that it be fully loaded before the immedate-execution code that sets up the default toolbar items (output from EditPage.php). This failed since we've gone fully async in the bottom-loading items, and could result in failed calls to mw.toolbar.addButton. Wrapped those immediate calls in a mediawiki.loader.using call to ensure they're run after the module is loaded, and moved the mw.toolbar.init call into that section so we guarantee it gets run first. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108389]: Revision status changed
MaxSem changed the status of MediaWiki.r108389 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108389 Old status: new New status: ok Commit summary for MediaWiki.r108389: revert r108367 : breaks tests When doing a change that break tests, update the tests in the same commit. That makes the change more obvious and let us merge in another branch easily. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108124]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r108124. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108124#c29166 Commit summary for MediaWiki.r108124: CSS and JS cleanup. Misc JS fixes Santhosh.thottingal's comment: 'fontconfig.ttf' should not be in quotes. Fixed in r108390 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108390]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108390 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108390 Old status: new New status: ok Commit summary for MediaWiki.r108390: Fix the download link of font. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108390]: New comment added
Nikerabbit posted a comment on MediaWiki.r108390. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108390#c29167 Commit summary for MediaWiki.r108390: Fix the download link of font. Nikerabbit's comment: Looks like I broke this accidentally. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Files with unknown copyright status on MediaWiki wiki
Le Wed, 04 Jan 2012 11:58:55 +0100, Roan Kattouw roan.katt...@gmail.com a écrit: In your post, you ask whether the employee owns the copyright on their own work, or whether WMF does. I don't know this for sure, because it's not explicitly mentioned in my contract, but I believe it's owned by the employee/contractor. All the WMF-written code I've seen in the past few years claims to be copyrighted by the author, and the fact that my contract requires me to license my work in a certain way seems to imply I own the copyright on that work, otherwise I wouldn't even have the power to license it. That is how I understand it. My contract enforce me to publish all my work as a contractor under a free license. I am assuming the code is still my intellectual property though. For WMF employees, I am sure the copyright belong to the WMF. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
Aaron Schulz posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29168 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) Aaron Schulz's comment: If anyone needs that then it be added to NewParserTests rather than a duplicated test file (which was also broken by leaking globals)? This file was particularly annoying with FileBackend. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108393]: Revision status changed
Raymond changed the status of MediaWiki.r108393 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108393 Old status: new New status: ok Commit summary for MediaWiki.r108393: Some more message tweaks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108385]: Revision status changed
Raymond changed the status of MediaWiki.r108385 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108385 Old status: new New status: ok Commit summary for MediaWiki.r108385: Add quotes to Download reference in 'webfonts-preview-installing-fonts-text'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108387]: Revision status changed
Raymond changed the status of MediaWiki.r108387 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108387 Old status: new New status: ok Commit summary for MediaWiki.r108387: Update punctuation for 'webfonts-preview-installing-fonts-text'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108388]: Revision status changed
Raymond changed the status of MediaWiki.r108388 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108388 Old status: new New status: ok Commit summary for MediaWiki.r108388: 3rd fix after group review... Thanks guys :). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108394]: Revision status changed
Raymond changed the status of MediaWiki.r108394 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108394 Old status: new New status: ok Commit summary for MediaWiki.r108394: Set $wgSpecialPageGroups for WebFonts. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108374]: Revision status changed
Hashar changed the status of MediaWiki.r108374 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108374 Old status: new New status: ok Commit summary for MediaWiki.r108374: Fixup documentation Swap require for require_once Wrap long line ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105855]: Revision status changed
Siebrand changed the status of MediaWiki.r105855 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105855 Old status: new New status: fixme Commit summary for MediaWiki.r105855: Replaced the core message 'sectionlink' with getArrow, which is cleaner and does the right thing in mixed RTL/LTR environment. Removed the message from the messages files, because it doesn't seem to be used elsewhere. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108365]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r108365 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108365 Old status: new New status: ok Commit summary for MediaWiki.r108365: * Use WikiPage instead of Article to call doEdit() * Pass the User doing the edit to doEdit() * Check for invalid title before fecthing content and doing the edit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108395]: Revision status changed
Raymond changed the status of MediaWiki.r108395 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108395 Old status: new New status: ok Commit summary for MediaWiki.r108395: Remove unnecessary break statement after return statement. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106780]: New comment added
Hashar posted a comment on MediaWiki.r106780. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106780#c29169 Commit summary for MediaWiki.r106780: Fix for bug 33270: default to 'default' search profile Had this fixed in one of my wikies but not committed Hashar's comment: I have added a test case with r108400 albeit commented out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107975]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r107975 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107975#c29170 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r107975: MFT r105341, t105853, r106780 Hashar's comment: This cause in production bug 33583 - Search namespaces from [[Special:Preferences]] are ignored Confirmed on mediawiki.org * set your namespace searching option to (Main) * in the top right input box search for foobar * Search page show pages from Manual and Extension namespaces. This is caused by the merge of r106780 (currently marked as fixme) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
^demon posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29171 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ^demon's comment: There's still the --regex option too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108404]: Revision status changed
^demon changed the status of MediaWiki.r108404 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108404 Old status: new New status: ok Commit summary for MediaWiki.r108404: tip to run parser tests Follow r108358 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108404]: New comment added
^demon posted a comment on MediaWiki.r108404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108404#c29172 Commit summary for MediaWiki.r108404: tip to run parser tests Follow r108358 ^demon's comment: eol-style. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108404]: New comment added
Hashar posted a comment on MediaWiki.r108404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108404#c29173 Commit summary for MediaWiki.r108404: tip to run parser tests Follow r108358 Hashar's comment: fix the pre commit hook? :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108409]: Revision status changed
^demon changed the status of MediaWiki.r108409 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108409 Old status: new New status: ok Commit summary for MediaWiki.r108409: eolstyle follow r108404 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108408]: New comment added
^demon posted a comment on MediaWiki.r108408. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108408#c29174 Commit summary for MediaWiki.r108408: filerepo: always use realpath() The suffix to strip was determined using realpath() but applied on the given path. This could lead to errors when the path is made of a symbolic link or use consecutives slashes. Example on Mac OS: $ php -a php print realpath( '/private///tmp' ); /private/tmp php print realpath( '///tmp///' ); /private/tmp php $ Fix FileBackendTest::testGetFileList test which failed with: 1) FileBackendTest::testGetFileList Correct file listing (FSFileBackend). Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( -0 = 'subdir1/test1.txt' -1 = 'subdir1/test2.txt' -2 = 'subdir2/subdir/sub/120-px-file.txt' -3 = 'subdir2/subdir/sub/test0.txt' -4 = 'subdir2/subdir/test1.txt' -5 = 'subdir2/subdir/test2.txt' -6 = 'subdir2/subdir/test3.txt' -7 = 'subdir2/subdir/test4.txt' -8 = 'subdir2/subdir/test5.txt' -9 = 'subdir2/test3.txt' -10 = 'subdir2/test4.txt' -11 = 'test1.txt' -12 = 'test2.txt' -13 = 'test3.txt' +0 = '/subdir/sub/120-px-file.txt' +1 = '/subdir/sub/test0.txt' +2 = '/subdir/test1.txt' +3 = '/subdir/test2.txt' +4 = '/subdir/test3.txt' +5 = '/subdir/test4.txt' +6 = '/subdir/test5.txt' +7 = '/test1.txt' +8 = '/test2.txt' +9 = '/test3.txt' +10 = '/test4.txt' +11 = 'xt' +12 = 'xt' +13 = 'xt' ) ^demon's comment: Thank you! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108400]: New comment added, and revision status changed
^demon changed the status of MediaWiki.r108400 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108400#c29175 Old Status: new New Status: ok Commit summary for MediaWiki.r108400: test skeleton for Special:Search Only two tests for now. A third one was written for r106780 / bug 33583 but is disabled to avoid breaking Jenkins. ^demon's comment: Indentation is funky in the body for provideSearchOptionsTests(). Otherwise ok ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108406]: Revision status changed
Hashar changed the status of MediaWiki.r108406 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108406 Old status: new New status: ok Commit summary for MediaWiki.r108406: Remove no-op codepath ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108412]: Revision status changed
^demon changed the status of MediaWiki.r108412 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108412 Old status: new New status: ok Commit summary for MediaWiki.r108412: Add a new methodExists method to MWInit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108397]: Revision status changed
^demon changed the status of MediaWiki.r108397 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108397 Old status: new New status: ok Commit summary for MediaWiki.r108397: FauxRequest now has empty data per default ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108341]: Revision status changed
^demon changed the status of MediaWiki.r108341 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108341 Old status: new New status: reverted Commit summary for MediaWiki.r108341: Remove action=history from submit on HistoryAction * Not needed, and not used. Is internally converted to view as much as possible. * Fixes bug 33587 * See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6 * Other diff links from MediaWiki don't do this either ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108370]: Revision status changed
^demon changed the status of MediaWiki.r108370 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108370 Old status: new New status: ok Commit summary for MediaWiki.r108370: [HistoryAction] Revert r108341 as this breaks revision delete. This construction never looked cool, but looks like this fix is not the right way, so reverting it. This form is used for two purposes: -- Submitting diff/oldid to (implied) action=view -- Submitting ids-array to action=revisiondelete That makes it complicated. Also for IE6/IE7 compatibility, there is no way to do this from the HTML itself (i.e. using input type=submit name=action value=revisiondelete would work but leaves no option to have a custom i18n label. and button type=submit name=action value=revisiondeleteI18N LABEL/button works but IE7 submits I18N LABEL as value for action instead of revision delete. Will re-fix bug 33587 in a few minutes with a progressive-enhancement solution from the front-end instead. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108377]: Revision status changed
^demon changed the status of MediaWiki.r108377 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108377 Old status: new New status: ok Commit summary for MediaWiki.r108377: * r107986: Added readOnly checks to prepare(), secure(), and clean() in FileBackendBase. * Added some prepare()/clean() tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108411]: Revision status changed
^demon changed the status of MediaWiki.r108411 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108411 Old status: new New status: ok Commit summary for MediaWiki.r108411: Tweak messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108410]: Revision status changed
^demon changed the status of MediaWiki.r108410 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108410 Old status: new New status: ok Commit summary for MediaWiki.r108410: revert back to 1.2.4 (not working with resourceLoader) but keep removal of legacy comment format ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108407]: Revision status changed
^demon changed the status of MediaWiki.r108407 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108407 Old status: new New status: ok Commit summary for MediaWiki.r108407: js fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108402]: Revision status changed
^demon changed the status of MediaWiki.r108402 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108402 Old status: new New status: ok Commit summary for MediaWiki.r108402: Consistency updates. Per: https://translatewiki.net/w/i.php?title=Thread:Support/Inconsistencies_in_wikilovelqt_method=thread_history ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108401]: Revision status changed
^demon changed the status of MediaWiki.r108401 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108401 Old status: new New status: ok Commit summary for MediaWiki.r108401: work on course and term pagers ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108392]: Revision status changed
^demon changed the status of MediaWiki.r108392 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108392 Old status: new New status: ok Commit summary for MediaWiki.r108392: rename the font to correct the file extension in correct case. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108386]: Revision status changed
^demon changed the status of MediaWiki.r108386 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108386 Old status: new New status: ok Commit summary for MediaWiki.r108386: * Avoid double parsing of the description * Use FuzzyBot to create the pages, isntead of a random user * Read the page contents for the definition if the page exists * Add the configuration global for dependency for message group cache ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108351]: Revision status changed
^demon changed the status of MediaWiki.r108351 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108351 Old status: new New status: ok Commit summary for MediaWiki.r108351: Followup r108350, remove remaining configuration option You'd think after an hour of reverting something, you'd catch everything. Nope, not even the most obvious. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108350]: Revision status changed
^demon changed the status of MediaWiki.r108350 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108350 Old status: new New status: ok Commit summary for MediaWiki.r108350: Reverting inline commenting from CodeReview This change is still very buggy and has not recieved any love since initial commit. From the beginning it was an expertimental feature. Instead of letting this sit in trunk forever, I'm just going to revert it. If you'd like to bring it back, finish it completely or make a branch. ping r95429, r95435, r95680, r95680, r96173, r99030, r99034, r107068, r107069, r107074 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108363]: New comment added
Hashar posted a comment on MediaWiki.r108363. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108363#c29176 Commit summary for MediaWiki.r108363: * bug 33571: fix yottabits/s in Language::formatBitrate Problem was caused by inexact floating-point comparisons with values returned from log10(); worked around by simply duplicating the very similar code in the function immediately below, which does the same thing with 1024 instead of 1000 unit sizes, uses only simple division, and passes the test cases. Hashar's comment: What should '99' gives in kbps ? * 999kbps * 999,999kbps * 1,000kbps I find the later acceptable. Thanks brion for the fix! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108366]: Revision status changed
Hashar changed the status of MediaWiki.r108366 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108366 Old status: new New status: ok Commit summary for MediaWiki.r108366: Fix str_replace parameter order fail from r108364 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108364]: Revision status changed
Hashar changed the status of MediaWiki.r108364 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108364 Old status: new New status: resolved Commit summary for MediaWiki.r108364: Followup r108363 for bug 33571 Refactor out duplicate code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108349]: Revision status changed
^demon changed the status of MediaWiki.r108349 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108349 Old status: new New status: ok Commit summary for MediaWiki.r108349: Add resource loader dependency for mediawiki.util ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108041]: Revision status changed
^demon changed the status of MediaWiki.r108041 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108041 Old status: new New status: ok Commit summary for MediaWiki.r108041: Turning off debug by default -- local versions and prototype will need to add = true; to LocalSettings.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107799]: Revision status changed
^demon changed the status of MediaWiki.r107799 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107799 Old status: new New status: ok Commit summary for MediaWiki.r107799: Followup r107797, too much context source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100933]: Revision status changed
^demon changed the status of MediaWiki.r100933 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933 Old status: new New status: ok Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table creation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105833]: Revision status changed
^demon changed the status of MediaWiki.r105833 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105833 Old status: new New status: resolved Commit summary for MediaWiki.r105833: Attempt to fix tests broken by r105828 Test wanted in a specific order, now just look up wanted array key from title row Untested as my phpunit tests seem to be b0rked locally :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107986]: Revision status changed
^demon changed the status of MediaWiki.r107986 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107986 Old status: new New status: resolved Commit summary for MediaWiki.r107986: * Added FileBackendBase::getFileContents() function with a default FileBackend version. * Added read-only mode to FileBackendBase config. * Moved FileBackendBase::getFileTimestamp() up slightly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108376]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r108376 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108376#c29177 Old Status: new New Status: ok Commit summary for MediaWiki.r108376: Fix double-escaping in 108312 Hashar's comment: I think the htmlspecialchars() is applied by the skin. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108357]: Revision status changed
Hashar changed the status of MediaWiki.r108357 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108357 Old status: new New status: ok Commit summary for MediaWiki.r108357: Another @group Broken ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108335]: Revision status changed
Hashar changed the status of MediaWiki.r108335 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108335 Old status: new New status: ok Commit summary for MediaWiki.r108335: Profile all returns (r107319 follow-up) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108326]: Revision status changed
Hashar changed the status of MediaWiki.r108326 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108326 Old status: new New status: ok Commit summary for MediaWiki.r108326: Simplify the check to make it more understandable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108414]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r108414 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108414 Old status: new New status: ok Commit summary for MediaWiki.r108414: method documentation for r108364 The function are badly named and could use something better :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108415]: New comment added
Siebrand posted a comment on MediaWiki.r108415. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108415#c29178 Commit summary for MediaWiki.r108415: Remove API error message duplication from Translate and UploadWizard into core. Make necessary changes in loader and JavaScript for Translate and UploadWizard. Siebrand's comment: Core parts need to be merged to 1.18wmf1 to allow UploadWizard and Translate to remain working for Wikimedia. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108350]: New comment added
Hashar posted a comment on MediaWiki.r108350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108350#c29179 Commit summary for MediaWiki.r108350: Reverting inline commenting from CodeReview This change is still very buggy and has not recieved any love since initial commit. From the beginning it was an expertimental feature. Instead of letting this sit in trunk forever, I'm just going to revert it. If you'd like to bring it back, finish it completely or make a branch. ping r95429, r95435, r95680, r95680, r96173, r99030, r99034, r107068, r107069, r107074 Hashar's comment: Now we need git migration to be done so we can install gerrit /gitorious :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105919]: New comment added
Hashar posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29180
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Hashar's comment:
The function documentations need an update.
What is the points of query2 ? fixUrlQueryArgs() adds yet another layer of
stuff that is prone to break and make the framework harder for little benefits.
Just use one $query argument that should either be a string or an array. That
would make things wayyy easier to maintain in the long term.
FakeTitle methods should be updated to reflect Title changes.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105919]: New comment added
Dantman posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29181
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Dantman's comment:
Docs were already added in a followup.
The point of query2 was for patterns such as code$title-getLocalURL( $query,
array( 'variant' = 'zh-tw' ) );/code.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108420]: New comment added
^demon posted a comment on MediaWiki.r108420. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420#c29182 Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ^demon's comment: Forgot to press save. Commit summary should've been: Break wfBCP47, wfBaseName and wfTimestamp tests to their own files. Rewrite wfTimestamp tests to use data providers like it should. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108420]: New comment added
Hashar posted a comment on MediaWiki.r108420. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420#c29183 Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) Hashar's comment: You broke file history :( Need to copy the Globafunctions.php file three time and then clean them up :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108420]: Revision status changed
Hashar changed the status of MediaWiki.r108420 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420 Old status: new New status: fixme Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108420]: New comment added
^demon posted a comment on MediaWiki.r108420. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420#c29184 Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ^demon's comment: There is no meaningful history here to copy. I rewrote everything so annotations would be useless. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107118]: Revision status changed
^demon changed the status of MediaWiki.r107118 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107118 Old status: new New status: ok Commit summary for MediaWiki.r107118: (bug 33276) .deb must create system user * Now manage system user and group (close bug 33276) * New package dependency: adduser Also added a missing space in previous changelog entry Bump testswarm to 0.1.0-5 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101138]: Revision status changed
Hashar changed the status of MediaWiki.r101138 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101138 Old status: new New status: ok Commit summary for MediaWiki.r101138: An alternative to using DOMDocument for normalizing when using Preprocessor_Hash. Follow-up r99909. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108420]: Revision status changed
^demon changed the status of MediaWiki.r108420 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420 Old status: fixme New status: new Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106782]: Revision status changed
Catrope changed the status of MediaWiki.r106782 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782 Old status: new New status: ok Commit summary for MediaWiki.r106782: Resourceloader-ify CSS/JS from CentralAuth Kill $wgCentralAuthStyleVersion as now un-needed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] New patches in Bugzilla from the last week
Following are a list of still-open bugs that have gotten new patches in the past week. I need committers to these over and either provide feedback if the patch needs improvement or commit them with a reference to the bug and the person who supplied the patch. The commit message should look something like this: Fixes Bug 7 - Explain the wiki syntax in detailed EBNF Author: Niklaus Wirth Niklas Wirth writes: I decided you to show you how it is done. Your help in getting code donations from Bugzilla integrated into MediaWiki is appreciated. The Patches: https://bugzilla.wikimedia.org/2700 Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, pipe trick, subst, signatures) https://bugzilla.wikimedia.org/10574 Export pages should allow to export all pages https://bugzilla.wikimedia.org/30332 API spamblocklist error should provide *all* blocked URLs, not just one https://bugzilla.wikimedia.org/32626 Backlinks generated by references/ shouldn't be visible in printed version of pages https://bugzilla.wikimedia.org/33537 RFE: Hook to change Enotif recipient list https://bugzilla.wikimedia.org/33546 Serbian (sr-ec and sr-el) should support GRAMMAR parser function https://bugzilla.wikimedia.org/33582 Make it possible to automatically add pages to watchlist when adding a new section https://bugzilla.wikimedia.org/33595 mwdocgen.php: Add option to not create graphs https://bugzilla.wikimedia.org/33606 SF_RunQuery.php: Argument 3 passed to Parser::parse() must be an instance of ParserOptions, null given Thanks! Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108420]: Revision status changed
^demon changed the status of MediaWiki.r108420 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108420 Old status: new New status: reverted Commit summary for MediaWiki.r108420: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108427]: Revision status changed
^demon changed the status of MediaWiki.r108427 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108427 Old status: new New status: ok Commit summary for MediaWiki.r108427: revert r108420, will split with history ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
MaxSem posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29185 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) MaxSem's comment: Grr, parserTests.php ran much faster. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106813]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r106813 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106813#c29186 Old Status: new New Status: ok Commit summary for MediaWiki.r106813: Refactored batchAntiSpoof.php to subclass Maintenance For part of bug 28747 Catrope's comment: pre + $result = $dbw-select( 'user', 'user_name', null, __FUNCTION__ ); /pre Shouldn't you use __METHOD__ ? Fine otherwise, marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108428]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r108428 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108428#c29187 Old Status: ok New Status: new Commit summary for MediaWiki.r108428: Break wfBCP47, wfBaseName and wfTimestamp tests They are now in their own files. Rewrite wfTimestamp tests to use data providers like it should. Originally commited without history by ^demon as r108420 Hashar's comment: Reviewed code meanwhile Looks fine to me. Thanks chad! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108418]: Revision status changed
Hashar changed the status of MediaWiki.r108418 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108418 Old status: new New status: ok Commit summary for MediaWiki.r108418: file name - filename for consistency. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108417]: Revision status changed
^demon changed the status of MediaWiki.r108417 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108417 Old status: new New status: ok Commit summary for MediaWiki.r108417: reindent SpecialSearchTest.php (follow r198400) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108428]: Revision status changed
^demon changed the status of MediaWiki.r108428 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108428 Old status: new New status: ok Commit summary for MediaWiki.r108428: Break wfBCP47, wfBaseName and wfTimestamp tests They are now in their own files. Rewrite wfTimestamp tests to use data providers like it should. Originally commited without history by ^demon as r108420 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107322]: Revision status changed
Catrope changed the status of MediaWiki.r107322 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107322 Old status: new New status: ok Commit summary for MediaWiki.r107322: Kill some = 1.15 back compat Deletion of: /** * For backwards compatibility with MediaWiki 1.15 and earlier. */ $aliases = $specialPageAliases; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108396]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108396 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108396 Old status: new New status: ok Commit summary for MediaWiki.r108396: Latest version of CLDR got 6 rules for Welsh(cy). So removing fixme. http://unicode.org/repos/cldr-tmp/trunk/diff/supplemental/language_plural_rules.html#cy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107395]: Revision status changed
Catrope changed the status of MediaWiki.r107395 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107395 Old status: new New status: ok Commit summary for MediaWiki.r107395: Removed $updater === null code Add create user code from install.php Delete install.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108397]: New comment added
Nikerabbit posted a comment on MediaWiki.r108397. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108397#c29188 Commit summary for MediaWiki.r108397: FauxRequest now has empty data per default Nikerabbit's comment: I can see that, but why? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107938]: Revision status changed
Catrope changed the status of MediaWiki.r107938 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107938 Old status: new New status: ok Commit summary for MediaWiki.r107938: MFT r96774, r98690, r99840 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108273]: Revision status changed
Catrope changed the status of MediaWiki.r108273 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108273 Old status: new New status: ok Commit summary for MediaWiki.r108273: Add comments about libraries that are in 1.19, so can be removed from UW when using 1.19 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108414]: New comment added
Nikerabbit posted a comment on MediaWiki.r108414. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108414#c29189 Commit summary for MediaWiki.r108414: method documentation for r108364 The function are badly named and could use something better :D Nikerabbit's comment: The base is not the only difference, they include units too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
OverlordQ posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29190 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) OverlordQ's comment: Also, saying 'if you want to track when something broke, do it yourself' is a cop out when parserTests.php handled that for you nicely. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108413]: New comment added
Nikerabbit posted a comment on MediaWiki.r108413. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108413#c29191 Commit summary for MediaWiki.r108413: test format bitrate with '999' Nikerabbit's comment: isn't the comment wrong? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108358]: New comment added
^demon posted a comment on MediaWiki.r108358. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108358#c29192 Commit summary for MediaWiki.r108358: * Drop old parserTests.php way of running parser tests. You can run parser tests via --group Parser or specifying the includes/parser/MediaWikiParserTest.php test case * Drop now unused various test recorder options -- phpunit outputs its data in lots of machine-readable formats, use those if you need to work with test data * There's still a lot of duplication between NewParserTest::setUp() and MediaWikiTestCase, but hey one step at a time ;-) * All tests pass for me (make phpunit make parser) ^demon's comment: This is something we could add to our phpunit support I think. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108425]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108425 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108425#c29193 Old Status: new New Status: fixme Commit summary for MediaWiki.r108425: This extension makes sure PHPAzure library is properly included. Initial commit Nikerabbit's comment: Encoding wrong in i18n file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98499]: Revision status changed
Catrope changed the status of MediaWiki.r98499 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98499 Old status: new New status: ok Commit summary for MediaWiki.r98499: Followup r95572, replace insertAtCaret with textSelection per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108436]: Revision status changed
Catrope changed the status of MediaWiki.r108436 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108436 Old status: new New status: ok Commit summary for MediaWiki.r108436: Roan says we must invalidate user caches too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98500]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r98500 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98500#c29194 Old Status: new New Status: fixme Commit summary for MediaWiki.r98500: Basic ResourceLoader conversion, jQuery conversion and API use will come soon Catrope's comment: pre + $outputPage-addModules( 'ext.categoryTree' ); /pre This will add a flash of unstyled content, unless the getTag() function also calls code$parser-addModuleStyles()/code OK otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98563]: New comment added
Catrope posted a comment on MediaWiki.r98563. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98563#c29195 Commit summary for MediaWiki.r98563: Followup r98500, conversion of the Javascript to use jQuery fully. It also makes the Javascript work outside of debug=1 (oops) There's a couple of WTF moments in the code, this is really due to some issues with the PHP side of stuff. It really needs some TLC but for right now it works, I'll come back to it before 1.19 and clean it up. Catrope's comment: Did you ever come back before 1.19 and clean it up like you promised in the commit message? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108440]: Revision status changed
^demon changed the status of MediaWiki.r108440 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108440 Old status: new New status: ok Commit summary for MediaWiki.r108440: Add version. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108433]: Revision status changed
^demon changed the status of MediaWiki.r108433 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108433 Old status: new New status: ok Commit summary for MediaWiki.r108433: MFT r95088 r95203 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108432]: Revision status changed
^demon changed the status of MediaWiki.r108432 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108432 Old status: new New status: ok Commit summary for MediaWiki.r108432: Backport compatible updates from trunk. Among others: MFT r107067, r108415, r108418 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108415]: Revision status changed
^demon changed the status of MediaWiki.r108415 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108415 Old status: new New status: ok Commit summary for MediaWiki.r108415: Remove API error message duplication from Translate and UploadWizard into core. Make necessary changes in loader and JavaScript for Translate and UploadWizard. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108321]: Revision status changed
^demon changed the status of MediaWiki.r108321 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108321 Old status: new New status: ok Commit summary for MediaWiki.r108321: * Use WikiPage instead of Article * Use getRedirectTarget() instead of followRedirect(); the latter may return a string, which is not wanted here * No need to call updateRedirectOn(); getRedirectTarget() already populates the redirect table if needed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
