Re: [Wikitech-l] How to get the article object inside a function called by hook LinkEnd
* Thomas Gries m...@tgries.de [Sun, 11 Mar 2012 22:38:10 +0100]:
Can someone help me, please:
I need the $article object (the article page, where the LinkEnd hook
is
called) inside
a function called by hook LinkEnd.
- because I want to modifiy some links in the hooked function,
but only on articles where the raw text contains some strings
in E:WikiArticleFeeds .
function onLinkEnd( $skin, Title $target, array $options, $text, array
$attribs, $ret ) {
$article = new Article( $target, 0 );
}
Or, you need to get exactly $wgArticle but without declaring it as
global? Then I don't know how.
Dmitriy
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] svn: Unrecognised line ending style
In case anyone is getting this error trying to update a /trunk/extensions checkout: svn: Unrecognised line ending style The magic incantation to make it work again is: rm -rf extensions/SideBarMenu See r113253 and r113362. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113484]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113484 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113484 Old status: new New status: ok Commit summary for MediaWiki.r113484: Changing the font for Ahirani to Lohit Marathi - more suitable, if i understand correctly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113561]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113561 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113561 Old status: new New status: ok Commit summary for MediaWiki.r113561: Follow up to r113559, commenting out Hapax Berber until the license is clarified. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113559]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113559 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113559 Old status: new New status: ok Commit summary for MediaWiki.r113559: Deleting Hapax Berbere font until license is clarified :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How to get the article object inside a function called by hook LinkEnd
Am 12.03.2012 07:09, schrieb Dmitriy Sintsov:
* Thomas Gries m...@tgries.de [Sun, 11 Mar 2012 22:38:10 +0100]:
Can someone help me, please:
I need the $article object (the article page, where the LinkEnd hook
is
called) inside
a function called by hook LinkEnd.
- because I want to modifiy some links in the hooked function,
but only on articles where the raw text contains some strings
in E:WikiArticleFeeds .
function onLinkEnd( $skin, Title $target, array $options, $text,
array $attribs, $ret ) {
$article = new Article( $target, 0 );
}
Or, you need to get exactly $wgArticle but without declaring it as
global? Then I don't know how.
Dmitriy
Dmitriy,
the second argument ( $target ) is the link target (article object)
which is/has been processed by the linker,
not the article, on which this link was processed. This is, what I need.
It appears. that the whole Linker.php module does not refer to that,
because it is usually irrelevant
for forming links.
signature.asc
Description: OpenPGP digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113597]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113597 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113597 Old status: new New status: ok Commit summary for MediaWiki.r113597: Fix omission in r113596: --skip-en. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113596]: New comment added
Nikerabbit posted a comment on MediaWiki.r113596. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113596#c32078 Commit summary for MediaWiki.r113596: Update/add some documentation. Nikerabbit's comment: Should use ''group'' with wildcards instead of ''groupprefix''. $EXPORTPATH sometimes has trailing / and sometimes doesn't. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113603]: Revision status changed
Raymond changed the status of MediaWiki.r113603 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113603 Old status: new New status: ok Commit summary for MediaWiki.r113603: Update check blacklist. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113606]: Revision status changed
Raymond changed the status of MediaWiki.r113606 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113606 Old status: new New status: ok Commit summary for MediaWiki.r113606: rebuildLanguage.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113611]: Revision status changed
Raymond changed the status of MediaWiki.r113611 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113611 Old status: new New status: ok Commit summary for MediaWiki.r113611: Revert r113610, it appears it's impossible to fix vector in a sane way. If we try to fix it without images then the white in the version with images that's supposed to be there disappears. And that can't be fixed because that part of vector uses a variable em height disabling the ability to fix the issue by editing the uploaded image. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How to get the article object inside a function called by hook LinkEnd
* Thomas Gries m...@tgries.de [Mon, 12 Mar 2012 07:57:05 +0100]: Dmitriy, the second argument ( $target ) is the link target (article object) which is/has been processed by the linker, not the article, on which this link was processed. This is, what I need. It appears. that the whole Linker.php module does not refer to that, because it is usually irrelevant for forming links. You may also hook to: http://www.mediawiki.org/wiki/Manual:Hooks/BeforeInitialize It has the context. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113596]: New comment added
Siebrand posted a comment on MediaWiki.r113596. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113596#c32079 Commit summary for MediaWiki.r113596: Update/add some documentation. Siebrand's comment: It needs a trailing slash if ppgettext is used I found out. Don't know what you mean with group prefix vs. group. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113594]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r113594 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113594#c32080 Old Status: new New Status: fixme Commit summary for MediaWiki.r113594: Add definitionFile to work with export.php's ppgettext. Nikerabbit's comment: ppgettext should be fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113596]: New comment added
Nikerabbit posted a comment on MediaWiki.r113596. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113596#c32081 Commit summary for MediaWiki.r113596: Update/add some documentation. Nikerabbit's comment: The command line parameter should be --group. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113593]: Revision status changed
MaxSem changed the status of MediaWiki.r113593 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113593 Old status: new New status: ok Commit summary for MediaWiki.r113593: More of r113580 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113580]: Revision status changed
MaxSem changed the status of MediaWiki.r113580 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113580 Old status: new New status: ok Commit summary for MediaWiki.r113580: Normalise casing of getArticleID used in core ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] History entry without content change?
Hello all, I was wondering if there's a clean way within the Wiki codebase to generate a history entry for an article without actually modifying the content. Essentially, from within an extension, I'd like to treat the history as a logfile for specific events related to the article that don't actually modify the article. Thanks, Rob. -- E-Mail Disclaimer: Information contained in this message and any attached documents is considered confidential and legally protected. This message is intended solely for the addressee(s). Disclosure, copying, and distribution are prohibited unless authorized. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] We need to use git-review - need help packaging for Win/Mac (Gerrit)
Sumana Harihareswara wrote: snip And can any of you help make native packages for git-review that work on Mac and Windows?[1] snip [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=35145 I have no idea who started spreading that git-review could not be installed on Mac OS X. It is already packaged as a python package. The magic commands are: sudo easy_install pip sudo pip install git-review pip is python package manager which is installed with Mac OS X. I am amending bug 35145. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] We need to use git-review - need help packaging for Win/Mac (Gerrit)
It should be noted that pip is no longer included with Mac OS X (tested on basic Lion and Mountain Lion installations). However, installing git-review for Mac is still relatively easy to do: https://www.mediawiki.org/wiki/Git/Workflow#Mac_OS_X_via_Terminal Perhaps people were referring to a different conversation about no Mac GUIs supporting git-review? Which as far as I know is still true. I'm still not clear on that whole topic - the wikipage for the GUIs doesn't seem to mention git-review.. -greg aka varnent On Mar 12, 2012, at 5:10 AM, Antoine Musso hashar+...@free.fr wrote: Sumana Harihareswara wrote: snip And can any of you help make native packages for git-review that work on Mac and Windows?[1] snip [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=35145 I have no idea who started spreading that git-review could not be installed on Mac OS X. It is already packaged as a python package. The magic commands are: sudo easy_install pip sudo pip install git-review pip is python package manager which is installed with Mac OS X. I am amending bug 35145. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] History entry without content change?
On 12.03.2012, 12:44 Robert wrote: Hello all, I was wondering if there's a clean way within the Wiki codebase to generate a history entry for an article without actually modifying the content. Essentially, from within an extension, I'd like to treat the history as a logfile for specific events related to the article that don't actually modify the article. Thanks, Rob. See Revision::newNullRevision() -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113613]: New comment added
Nikerabbit posted a comment on MediaWiki.r113613. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113613#c32082 Commit summary for MediaWiki.r113613: Fix Bug 33032 : Message missing from i18n Patch by Grunny, with some plural support related changes. Nikerabbit's comment: I think that it should be pre .prepend( $( 'label' ).text( mw.msg( 'vector-footercleanup-transclusion', transclusionCount ) ) ); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] 403: User account expired toolserver.org/~soxred93
Hi, I use to use some of the tools of the user soxred93. but for last few days it shows that the user account has been expired. Is there any way to up those tools? thanks nasir -- *Nasir Khan Saikat http://profiles.google.com/nasir8891* ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] History entry without content change?
On 12-03-12 05:25 AM, Max Semenik wrote: On 12.03.2012, 12:44 Robert wrote: Hello all, I was wondering if there's a clean way within the Wiki codebase to generate a history entry for an article without actually modifying the content. Essentially, from within an extension, I'd like to treat the history as a logfile for specific events related to the article that don't actually modify the article. See Revision::newNullRevision() Perfect, thank you! Cheers, Rob. -- E-Mail Disclaimer: Information contained in this message and any attached documents is considered confidential and legally protected. This message is intended solely for the addressee(s). Disclosure, copying, and distribution are prohibited unless authorized. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
It's true, most of the tools were overtaken by another user, can you tell us which tools are still broken? I myself would prefer to move all these tools to wikimedia labs, as soon as it's possible, which would allow us to manage them together without separating it tool per user (eg no ~soxred/files but toolname/files) where all tools would have own git repository and devs could just update them together and push to production. Thanks On Mon, Mar 12, 2012 at 3:33 PM, Nasir Khan nasir8...@gmail.com wrote: Hi, I use to use some of the tools of the user soxred93. but for last few days it shows that the user account has been expired. Is there any way to up those tools? thanks nasir -- *Nasir Khan Saikat http://profiles.google.com/nasir8891* ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
Tparis has the full source code of those tools, and looks like he has already brought them up on his own account. See https://toolserver.org/~tparis. I am not sure if he has everything up. On Mon, Mar 12, 2012 at 10:33 PM, Nasir Khan nasir8...@gmail.com wrote: Hi, I use to use some of the tools of the user soxred93. but for last few days it shows that the user account has been expired. Is there any way to up those tools? thanks nasir -- *Nasir Khan Saikat http://profiles.google.com/nasir8891* ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Regards, Hydriz We've created the greatest collection of shared knowledge in history. Help protect Wikipedia. Donate now: http://donate.wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
On Mon, Mar 12, 2012 at 9:33 AM, Nasir Khan nasir8...@gmail.com wrote: Hi, I use to use some of the tools of the user soxred93. but for last few days it shows that the user account has been expired. Is there any way to up those tools? Hope the source is somewhere, and depending on the licenses attached to the account ask the roots if it'd be possible to move to an active account. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
On Mon, Mar 12, 2012 at 10:49, Petr Bena benap...@gmail.com wrote: It's true, most of the tools were overtaken by another user, can you tell us which tools are still broken? I myself would prefer to move all these tools to wikimedia labs, as soon as it's possible, which would allow us to manage them together without separating it tool per user (eg no ~soxred/files but toolname/files) where all tools would have own git repository and devs could just update them together and push to production. fwiw, the same thing has been possible on the toolserver for quite a while now: Multi-maintainer projects (MMP) maybe they're aren't used enough when making a tool but (I think) you can't blame the roots for that and (I guess/hope) making new MMPs is a relatively cheap/easy process. -Jeremy (Also, this whole thread belongs on toolserver-l I think?) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
these two tools are unavailable http://toolserver.org/~soxred93/pages http://toolserver.org/~soxred93/pcount thanks, these tools are available to https://toolserver.org/~tparis , And it is preferable to move all the tools to the labs. https://toolserver.org/%7Etparis On Mon, Mar 12, 2012 at 8:52 PM, OQ overlo...@gmail.com wrote: On Mon, Mar 12, 2012 at 9:33 AM, Nasir Khan nasir8...@gmail.com wrote: Hi, I use to use some of the tools of the user soxred93. but for last few days it shows that the user account has been expired. Is there any way to up those tools? Hope the source is somewhere, and depending on the licenses attached to the account ask the roots if it'd be possible to move to an active account. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- *Nasir Khan Saikat http://profiles.google.com/nasir8891* ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Ajax event firing for username validation in Extension: SignupAPI
Hi, In SignupAPI extension, should I fire the Ajax user validation (username available not illegal checking) 'onchange' / 'onkeyup' ? 1) 'onchange' would cause less Ajax calls but will give result only when the user has pressed tab or clicks to the next field 2) 'onkeyup' would cause a lot of Ajax calls but would give result as when the user types so that he can correct the input if needed rather than going to the next field then finding that he just gave some invalid input in the previous field What would be better from a UX + Performance point of view? Is there any other JavaScript event I should be looking at? Thanks Akshay ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113613]: New comment added
Kghbln posted a comment on MediaWiki.r113613. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113613#c32083 Commit summary for MediaWiki.r113613: Fix Bug 33032 : Message missing from i18n Patch by Grunny, with some plural support related changes. Kghbln's comment: I do not know if there is a convention for it but so far I have only seen PLURAL instead plural, though I am sure the latter works too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
On 12 March 2012 15:49, Hydriz Wikipedia ad...@alphacorp.tk wrote:
Tparis has the full source code of those tools, and looks like he has
already brought them up on his own account. See
https://toolserver.org/~tparis.
Could we (in general) *please* not do this? If someones tools are important
enough to be taken over by someone else, they are most certainly important
enough for a multi-maintainer project. In {one month, one year, five
years}, Tparis' account will also expire and we will have the same problem
all over again.
Best,
Merlijn
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] 403: User account expired toolserver.org/~soxred93
On 12/03/12 15:49, Petr Bena wrote: It's true, most of the tools were overtaken by another user, can you tell us which tools are still broken? I myself would prefer to move all these tools to wikimedia labs, as soon as it's possible, which would allow us to manage them together without separating it tool per user (eg no ~soxred/files but toolname/files) where all tools would have own git repository and devs could just update them together and push to production. Thanks You would first need to have a db copy on labs. Yes, the code is available. And restoring their access is as simple as having soxred request their account to be reactivated. There are some holes in that code, though. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
Platonides platoni...@gmail.com wrote: The fundamental change is something else to me: you lose feeling of linearity. I like hg because it still tries to give me a cosy nice local version numbers (great to switch from SVN, you can even have your old SVN commit numbers to stay after migration). But when I look at the gerrit interface (not gerrit's fault) I have no idea what was done before, what was done after, what's the history. Yes, git is so poewerful, that gets fragile in itself. I end up with several clones and no idea about where they differ. Isn't there a way to compare them? Yeah, I have the same problem very often. Many times got confused enough to save diffs and rm -rf the working directory. Git is a mess to integrate with - it's almost impossible to have some API. And you can't have hg rollback - my favorite feature of Mercurial (no need to commit --amend or something). Looking at this again: https://gerrit.wikimedia.org/r/#change,2916 I have 28f176ca9ca3767bfa9f0ec219f5fa0c299c5761 and 87f491132487313144e531354578ea2fbd3b42b4 here (those are commits, fine) and Ifb002160485030496c7d3f2abc4991484b533648 Additionally there is this c64fd4488d2ea24e120acb15db413377494dd3b3 (Patch Set 1) referring me to (gitweb) which is calls it commit. Ah, and there is 1101a1b3fe7f4d1c29321157fc1ef9b9f3fb6ff0 as well. Ouch and there is this refs/changes/16/2916/1 -- the good think I can actually click on it in gitweb! ? That's not a link. Go to to the gitweb screen https://gerrit.wikimedia.org/r/gitweb?p=test/mediawiki/extensions/examples.git;a=log;h=87f491132487313144e531354578ea2fbd3b42b4 and you will see little pink patches (tags) like https://gerrit.wikimedia.org/r/gitweb?p=test/mediawiki/extensions/examples.git;a=log;h=refs/changes/14/2914/1 those refs/changes/14/2914/1 are gerrit pointers to commits. (http://book.git-scm.com/7_git_references.html calls them Git references) I see also some people want to get rid of them at times: http://www.mailinglistarchive.com/html/repo-disc...@googlegroups.com/2010-05/msg00014.html Unfortunately, I don't see them in my local repository. Why? How can you clone them? All this makes MFT r111795, r111881, r111920, r112573, r112995, r113169 looks pale in comparison. And I can actually click a link in [[Special:Code]], and go back and forth on followups, neat! I proposed several times to bump git change numbers, so new ones don't conflict with svn ones. Ie. the number alone would allow you to point to gerrit or CodeReview, keeping a bit of consistency between models. Even the urls kind of match https://gerrit.wikimedia.org/r/123 for r123 Who cares about that? That r stands there for being a review system. I was told that zero effort was going to be made for that (they were unsure about the consequences of bumping the auto_increment, although there's little I can do about that) and to just talk about change 1234 not r1234. It's obvious that c3000 comes after r115000, isn't it? ;) It looks like that Gerrit precedessor, Rietveld works with SVN (yes!) and has a much nicer interface: http://codereview.appspot.com/5727045/#ps1 it uses Issues as bases for development (I think this is gerrit's change). Maybe we should use that instead (yes, I know, google app engine and stuff...) I really think that tighter integration with bugtracker (so bug attachments end up in vcs review queue and commit comments can be seen as quasi-bugs) would be much more beneficial to users. I will try to see how it would have worked with systems like fossil for example and report back. Indeed, that'd be an important feature. And I think now you have englightened me. Maybe our workflow should probably be completely 'change' based and not 'commit' based. Our [[Git/Workflow]] page does not say much about changesets. Actually working on a changeset mini-branch (git fetch origin refs/changes/16/2916/1 git checkout FETCH_HEAD) and then git add ... git commit -m ... git push origin HEAD:refs/changes/2916 would be a nice workflow; we probably wouldn't (or shouldn't) do rebasing then since theoretically many people can work on a changeset at the same time. (I can't check how it works since my git push fails again on [remote rejected] HEAD - refs/for/master (prohibited by Gerrit)) If refs/changes/2916 would work also for fetch (now you need refs/changes/xx/2916/n it could be very interesting. If only I could somehow fetch all tags refs/changes/* to my local git repository - anybody knows how do this? It also seems impossible to do code reviews offline, since we need to ssh -p 29418 gerrit.wikimedia.org host gerrit review options It seems that we can use revision numbers sometimes: ssh -p 29418 gerrit.wikimedia.org gerrit query 2714 but to work on review witch patchsets we need to be more specific: ssh gerrit.wikimedia.org gerrit review eff577ea766db8dcb3952baf99ba8053fac0da8c --restore So I think 'having stuff
[Wikitech-l] Revisions in git outside of query or 'ssh ... gerrit query'
I have a following stuff in git log (from ssh://sa...@gerrit.wikimedia.org:29418/test/mediawiki/extensions/examples): commit 28f176ca9ca3767bfa9f0ec219f5fa0c299c5761 Merge: e2513b6 5c50ad6 Author: Demon ch...@wikimedia.org Date: Fri Mar 2 13:15:54 2012 + Merge Slight doc change as Git test commit 5c50ad62ebdee790735a29338aaec7bd9ad2c366 Author: jarry1250 jarry1...@gmail.com Date: Thu Mar 1 21:03:19 2012 + Slight doc change as Git test Change-Id: I2b646e25ece2a0e16f960628e256828a2e020324 commit e2513b6edecf491e5dde1baa999627f9012386eb Author: cmcmahon cmcma...@wikimedia.org Date: Wed Feb 29 14:03:41 2012 -0700 set up new laptop Change-Id: I6d99a2c2dcc4a78ac2f8359c6aadbec52dc58dd6 It seems that ^demon is allowed to commit without a Change-Id Fine. I'd like to fetch the patches related to jarry1250 commit: $ ssh -p 29418 sa...@gerrit.wikimedia.org gerrit query 5c50ad62ebdee790735a29338aaec7bd9ad2c366 --patch-sets change I2b646e25ece2a0e16f960628e256828a2e020324 project: test/mediawiki/extensions/examples branch: master id: I2b646e25ece2a0e16f960628e256828a2e020324 number: 2913 subject: Slight doc change as Git test owner: name: Jarry1250 email: jarry1...@gmail.com url: https://gerrit.wikimedia.org/r/2913 lastUpdated: 2012-03-02 13:15:54 UTC sortKey: 001b6f1b0b61 open: false status: MERGED patchSets: number: 1 revision: 5c50ad62ebdee790735a29338aaec7bd9ad2c366 ref: refs/changes/13/2913/1 uploader: name: Jarry1250 email: jarry1...@gmail.com type: stats rowCount: 1 runTimeMilliseconds: 511 so I can now $ git fetch ssh://sa...@gerrit.wikimedia.org:29418/test/mediawiki/extensions/examples refs/changes/13/2913/1 From ssh://gerrit.wikimedia.org:29418/test/mediawiki/extensions/examples * branchrefs/changes/13/2913/1 - FETCH_HEAD $ git checkout -b r2913 FETCH_HEAD Switched to a new branch 'r2913 Now let's try the same with ^demon's commit: $ ssh -p 29418 sa...@gerrit.wikimedia.org gerrit query 28f176ca9ca3767bfa9f0ec219f5fa0c299c5761 --patch-sets type: stats rowCount: 0 runTimeMilliseconds: 429 It's just not there... Same with another one: $ ssh -p 29418 sa...@gerrit.wikimedia.org gerrit query 17f028f7d0b73b777cc2a06d99b3538d2c95db09 --patch-sets type: stats rowCount: 0 runTimeMilliseconds: 429 Even if I listen all abandoned changes in the project: $ ssh -p 29418 sa...@gerrit.wikimedia.org gerrit query status:abandoned project:test/mediawiki/extensions/examples --patch-sets r1 They are not there: $ grep 28f176ca9ca3767bfa9f0ec219f5fa0c299c5761 r1 $ grep 17f028f7d0b73b777cc2a06d99b3538d2c95db09 r1 Seems like they are totally outside of gerrit. Pretty lame for a gated trunk! //Saper ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] History entry without content change?
Robert Cummings rob...@interjinn.com wrote: On 12-03-12 05:25 AM, Max Semenik wrote: On 12.03.2012, 12:44 Robert wrote: Hello all, I was wondering if there's a clean way within the Wiki codebase to generate a history entry for an article without actually modifying the content. Essentially, from within an extension, I'd like to treat the history as a logfile for specific events related to the article that don't actually modify the article. See Revision::newNullRevision() Perfect, thank you! or maybe you can do something like $logEntry = new ManualLogEntry( 'something', 'somethingmaybeese' ); $logEntry-setPerformer( $user ); $logEntry-setTarget( $this-mTitle ); $logEntry-setComment( $reason ); $logid = $logEntry-insert(); $logEntry-publish( $logid ); (from WikiPage.php line 2990) //Saper ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ajax event firing for username validation in Extension: SignupAPI
Akshay Agarwal schrieb: Hi, In SignupAPI extension, should I fire the Ajax user validation (username available not illegal checking) 'onchange' / 'onkeyup' ? The illegal character logic could be implemented in JS. Or at least a part of it, and an ajax request only onchange. For example don't forget to send no request for an empty input form. 1) 'onchange' would cause less Ajax calls but will give result only when the user has pressed tab or clicks to the next field 2) 'onkeyup' would cause a lot of Ajax calls but would give result as when the user types so that he can correct the input if needed rather than going to the next field then finding that he just gave some invalid input in the previous field You may use the combination of onkeyup with a timeout of about 200ms. That will reduce lots of ajax calls, it's no live search but a validation. What would be better from a UX + Performance point of view? Is there any other JavaScript event I should be looking at? Watch for the events paste, change, input, mouseup and keyup, that should get all. Bergi ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ajax event firing for username validation in Extension: SignupAPI
Akshay Agarwal schrieb: Hi, In SignupAPI extension, should I fire the Ajax user validation (username available not illegal checking) 'onchange' / 'onkeyup' ? The illegal character logic could be implemented in JS. Or at least a part of it, and an ajax request only onchange. For example don't forget to send no request for an empty input form. 1) 'onchange' would cause less Ajax calls but will give result only when the user has pressed tab or clicks to the next field 2) 'onkeyup' would cause a lot of Ajax calls but would give result as when the user types so that he can correct the input if needed rather than going to the next field then finding that he just gave some invalid input in the previous field You may use the combination of onkeyup with a timeout of about 200ms. That will reduce lots of ajax calls, it's no live search but a validation. What would be better from a UX + Performance point of view? Is there any other JavaScript event I should be looking at? Watch for the events paste, change, input, mouseup and keyup, that should get all. Bergi ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113630]: Revision status changed
MaxSem changed the status of MediaWiki.r113630 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113630 Old status: new New status: ok Commit summary for MediaWiki.r113630: Add a getValue method... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113632]: Revision status changed
MaxSem changed the status of MediaWiki.r113632 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113632 Old status: new New status: ok Commit summary for MediaWiki.r113632: Whitespace cleanup ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113617]: Revision status changed
Catrope changed the status of MediaWiki.r113617 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113617 Old status: new New status: ok Commit summary for MediaWiki.r113617: fix for bug 34696 - mw.loader.using shouldnt call callback more than once ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113635]: New comment added
Reedy posted a comment on MediaWiki.r113635. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113635#c32084 Commit summary for MediaWiki.r113635: 1.19wmf1 MFT rc112423 rc113599 ? rc113600 rc113606 Reedy's comment: MFT rc112423 rc113599 ? rc113600 rc113606 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113635]: New comment added
Reedy posted a comment on MediaWiki.r113635. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113635#c32085 Commit summary for MediaWiki.r113635: 1.19wmf1 MFT rc112423 rc113599 ? rc113600 rc113606 Reedy's comment: What's rc? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113635]: New comment added
Nikerabbit posted a comment on MediaWiki.r113635. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113635#c32086 Commit summary for MediaWiki.r113635: 1.19wmf1 MFT rc112423 rc113599 ? rc113600 rc113606 Nikerabbit's comment: Just a mistake. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113641]: New comment added
Wikinaut posted a comment on MediaWiki.r113641. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113641#c32087 Commit summary for MediaWiki.r113641: changing the default to nobody can vote. changing the English text to the more polite 'You are not entitled to vote' Wikinaut's comment: see typo correction in r113643 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113643]: Revision status changed
Amire80 changed the status of MediaWiki.r113643 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113643 Old status: new New status: ok Commit summary for MediaWiki.r113643: typo corr ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113641]: Revision status changed
Amire80 changed the status of MediaWiki.r113641 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113641 Old status: new New status: resolved Commit summary for MediaWiki.r113641: changing the default to nobody can vote. changing the English text to the more polite 'You are not entitled to vote' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Krinkle posted a comment on MediaWiki.r113644.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32088
Commit summary for MediaWiki.r113644:
add locale global for handling languages and message function
for the benefit of the phonegap app
Krinkle's comment:
pre
var title = {$this-data['htmlTitle']};
var scriptPath =
{$this-data['wgScriptPath']};
- var showText = {$buttonShowText};
- var hideText = {$buttonHideText};
+ var locale = {
+ expand-section: {$buttonShowText},
+ collapse-section: {$buttonHideText}
+ };
/script
/pre
These generic (global!) variables are becoming an issue. More then just a
maintainability problem but a practical one as well. The browser has many
default variables in the global 'window' object by default. One of the things
many browsers put as alias into the window object are unique DOM element IDs.
So if any wiki or skin content would have codenowikispan id=locale ..
/span/nowiki/code or codenowikispan id=title ..
/span/nowiki/code, then this code is broken (some browsers allow
overriding of those properties, some don't).
Code like this is asking to get broken.
My advice would be to either drop all front-end development temporarily and
port to ResourceLoader asap, or spend more time on this.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: Revision status changed
Krinkle changed the status of MediaWiki.r113644 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644 Old status: new New status: fixme Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
MaxSem posted a comment on MediaWiki.r113644. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32089 Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app MaxSem's comment: Mobile RL looks problematic for compatibility (many mobile browsers support JS, but choke on its amount in jQuery) and traffic reasons. Any ideas? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113586]: Revision status changed
Catrope changed the status of MediaWiki.r113586 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113586 Old status: new New status: deferred Commit summary for MediaWiki.r113586: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GSOC project Improve our Android application
On Tue, Mar 6, 2012 at 4:36 AM, Yeshow Lao yesh...@gmail.com wrote: Thank you very much, Yuni and Marcin. Your advice is very helpful. I'm excited, and will consume the information and hope to set up the build environment on my PC and study the source code ASAP. Yeshow, did you manage to build our app? If so come by to #wikimedia-mobile (freenode) and we can guide you along to some bugs that need tending to. --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113619]: Revision status changed
Saper changed the status of MediaWiki.r113619 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113619 Old status: new New status: resolved Commit summary for MediaWiki.r113619: Set the user_touched field directly when adding a new user to the database so that the field is correct when someone does not call saveSettings() after addToDatabase() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113619]: New comment added
Saper posted a comment on MediaWiki.r113619. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113619#c32090 Commit summary for MediaWiki.r113619: Set the user_touched field directly when adding a new user to the database so that the field is correct when someone does not call saveSettings() after addToDatabase() Saper's comment: Broke build in https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3209/console, fixed in r113649 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Jdlrobson posted a comment on MediaWiki.r113644. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32091 Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app Jdlrobson's comment: What are people's thoughts on this - http://jonrobson.me.uk/tmp/r113644.diff - as a possible solution using data attributes [1] Note some mobiles do not support JSON which would be the other way to pass data from the php code to the javascript. [1] http://www.w3.org/TR/html5/elements.html#embedding-custom-non-visible-data-with-the-data-attributes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113649]: Revision status changed
Saper changed the status of MediaWiki.r113649 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113649 Old status: new New status: reverted Commit summary for MediaWiki.r113649: Fix r113619: Convert timestamp to the backend database value ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113619]: New comment added, and revision status changed
Saper changed the status of MediaWiki.r113619 to reverted and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113619#c32092 Old Status: resolved New Status: reverted Commit summary for MediaWiki.r113619: Set the user_touched field directly when adding a new user to the database so that the field is correct when someone does not call saveSettings() after addToDatabase() Saper's comment: More unit tests failing: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Re-introducing UNCONFIRMED state to bugzilla
Keep in mind that MediaWiki isn't the only software that we write. We already have a healthy beta group of Android and iOS testers. Perhaps some of them might want to be part of a bug squad team. --tomasz On Fri, Mar 9, 2012 at 5:16 PM, Mark A. Hershberger m...@wikimedia.org wrote: I set up Bugzilla today so that, by default, bugs would be in the UNCONFIRMED state. Next week, I plan to begin recruiting volunteers for the Bug Squad, who will help me to verify bugs by testing them against the Beta cluster. The plan is that the Bug Squad will be able to verify these bugs and change them to the NEW state. The Bug Squad idea comes from KDE's Bug Squad (http://techbase.kde.org/Contribute/Bugsquad) and I've begun talking with them. If you have an interest in helping out with or participating in the Bug Squad, please contact me. -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113626]: Revision status changed
Catrope changed the status of MediaWiki.r113626 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113626 Old status: new New status: ok Commit summary for MediaWiki.r113626: bug 35106 - really two issues here - fix for part one - the api wants the param additional not info ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113628]: Revision status changed
Catrope changed the status of MediaWiki.r113628 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113628 Old status: new New status: ok Commit summary for MediaWiki.r113628: bug 35106 - fix for part two - had to implement our own trackActionURL which is identical to the one in the clicktracking extension but adds the additional parameter with the page title information (really trackActionURL in the clicktracking extension should take an optional additional parameter - but writing our own fixes things for now) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112983]: Revision status changed
SPQRobin changed the status of MediaWiki.r112983 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112983 Old status: fixme New status: reverted Commit summary for MediaWiki.r112983: Add Hapax Berbère font: http://hapax.qc.ca/pdf/Hapax%20Berbere.pdf (it doesn't explicitly mention a license name, but it's free of copyright). Map it to several Berber languages that have a test wiki on Incubator. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Krinkle posted a comment on MediaWiki.r113644.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32093
Commit summary for MediaWiki.r113644:
add locale global for handling languages and message function
for the benefit of the phonegap app
Krinkle's comment:
JSON parsing from a string is indeed a modern API that isn't reliably available
in a cross-browser environment. However it doesn't make sense to pass a JSON
string to a browser. Browsers have javascript engines and JSON (JavaScript
Object Notation) as a literal rather than a string is (naturally) supported in
all javascript engines (even old ones (IE6..) and/or handicapped mobile
javascript engines, its in the fundamentals of the language, it's even used in
the return value visible in the diff above).
Outputting code'var mwMobileFrontendData = ' . FormatJSON::encode(
$frontendData ) . ';'/code will be fine. Where code$frontendData/code
would be something like:
pre
$frotendData = array(
'messages' = array(
'expand-section' = ..,
),
'config' = array(
'pageTitle' = ..
, 'scriptPath' = ..,
),
);
/pre
Then from a javascript file you'd have something like:
pre
( function ( mfData ) {
var mf = {
msg: function (key) {
return mfData.messages[key];
}
};
window.mwMobileFrontend = mf;
}( mwMobileFrontendData ) );
/pre
Just a short example :)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113650]: New comment added
IAlex posted a comment on MediaWiki.r113650. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113650#c32094 Commit summary for MediaWiki.r113650: Revert r113619, r113649: Breaks unit tests https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console Maybe a new property with unpredictable value breaks some tests. Need to investigate. IAlex's comment: Unit tests are working correctly on my local machine with PostgreSQL as DB backend (and before applying this revision)... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Extension:GoogleMaps changed in r113648
Hey, Info: I changed Extension:GoogleMaps Do note that the Maps extension [0] can do most of what this extension can do, and a whole lot more. Might make more sense for you to improve that one (and yes, I'm biased :) https://www.mediawiki.org/wiki/Extension:Maps Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Krinkle posted a comment on MediaWiki.r113644. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32095 Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app Krinkle's comment: There's no need for work-around via DOM attributes. JavaScript objects work just fine and much easier and faster to manipulate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Extension:GoogleMaps changed in r113648
Am 12.03.2012 22:09, schrieb Jeroen De Dauw:
Hey,
Info: I changed Extension:GoogleMaps
Do note that the Maps extension [0] can do most of what this extension can
do, and a whole lot more. Might make more sense for you to improve that one
(and yes, I'm biased :)
https://www.mediawiki.org/wiki/Extension:Maps
thanks for info, I did not know of this one - used GoogleMaps since
decades ;-)
I changed the download link in the Extension info box
download = {{WikimediaDownload|Maps}}
signature.asc
Description: OpenPGP digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113650]: New comment added
IAlex posted a comment on MediaWiki.r113650. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113650#c32096 Commit summary for MediaWiki.r113650: Revert r113619, r113649: Breaks unit tests https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console Maybe a new property with unpredictable value breaks some tests. Need to investigate. IAlex's comment: Sorry, I had the change I wanted to commit in my working directory when testing that. Reapplied in r113668 with that change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure
Over the last couple of weeks, I've taken a few steps to remove some of the WMF-specific bits of the MobileFrontend code base: https://bugzilla.wikimedia.org/show_bug.cgi?id=34144 https://bugzilla.wikimedia.org/show_bug.cgi?id=34145 Also, now if you view an article with useformat=mobile in the URL's query string, MobileFrontend will keep the mobile view enabled as you browse page to page until you explicitly exit the mobile view. While MobileFrontend has now been generalized enough to be used beyond the WMF cluster, there are still quit a few things that could be done to improve the ease of out-of-the-box usage. For instance, adding configurable WURFL support (which I believe should be fairly straightforward - this is out of date but the same idea should still work: http://lists.wikimedia.org/pipermail/wikitech-l/2012-January/057478.html) or making it possible to use path-based modifiers to signify mobile view (eg http://mywiki.com/wiki/Article - http://mywiki.com/wiki/m/Article - https://bugzilla.wikimedia.org/show_bug.cgi?id=35178). It would be great if anyone can help test/provide feedback for the changes that have been made, and especially if anyone wants to help add the features mentioned above! -- Arthur Richards Software Engineer, Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Extension:GoogleMaps changed in r113648
On Tue, Mar 13, 2012 at 7:16 AM, Thomas Gries m...@tgries.de wrote:
I changed the download link in the Extension info box
download = {{WikimediaDownload|Maps}}
Do not go and randomly change extension download links to others (even
if they match functionality), Go back and revert that.
If a user wants to download E:Google Maps, they want E:Google Maps not E:Maps.
But do feel free to put a pointer in the page if there is a better
extension to handle the tasks (feel free to use Template:Obsolete
extension)
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113650]: Revision status changed
Hashar changed the status of MediaWiki.r113650 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113650 Old status: new New status: ok Commit summary for MediaWiki.r113650: Revert r113619, r113649: Breaks unit tests https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console Maybe a new property with unpredictable value breaks some tests. Need to investigate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113477]: Revision status changed
Hashar changed the status of MediaWiki.r113477 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113477 Old status: new New status: ok Commit summary for MediaWiki.r113477: r113416: added missing parameter to message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113416]: Revision status changed
Hashar changed the status of MediaWiki.r113416 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113416 Old status: new New status: resolved Commit summary for MediaWiki.r113416: Added backend-fail-maxsize failure message and use it instead of the vague could not store type message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113677]: Revision status changed
Pgehres (WMF) changed the status of MediaWiki.r113677 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113677 Old status: new New status: ok Commit summary for MediaWiki.r113677: More logging so we can tell exactly what scores our various fraud filters are adding to the final fraud score of any transaction. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113416]: New comment added
Nikerabbit posted a comment on MediaWiki.r113416. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113416#c32097 Commit summary for MediaWiki.r113416: Added backend-fail-maxsize failure message and use it instead of the vague could not store type message. Nikerabbit's comment: Hashar: where's the message documentation? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113686]: New comment added
Siebrand posted a comment on MediaWiki.r113686.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113686#c32098
Commit summary for MediaWiki.r113686:
added method for votersto revoke their vote.
Siebrand's comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113644]: New comment added
Jdlrobson posted a comment on MediaWiki.r113644. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644#c32099 Commit summary for MediaWiki.r113644: add locale global for handling languages and message function for the benefit of the phonegap app Jdlrobson's comment: See follow up in r113695 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86513]: New comment added
Saper posted a comment on MediaWiki.r86513. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86513#c32100 Commit summary for MediaWiki.r86513: Follow-up r86482: * Declare PasswordReset obsolete per release of MediaWiki 1.18 * Remove support from Translate extension. Saper's comment: This extension has two features not present in core: * ability to kill the password, thus preventing login * list of all disabled accounts * set new password by another user (i.e. sysop) - new password can be entered into the form ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113686]: New comment added
Wikinaut posted a comment on MediaWiki.r113686. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113686#c32101 Commit summary for MediaWiki.r113686: added method for votersto revoke their vote. Wikinaut's comment: added in r113697 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113699]: New comment added, and revision status changed
Wikinaut changed the status of MediaWiki.r113699 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113699#c32102 Old Status: new New Status: fixme Commit summary for MediaWiki.r113699: follow up r113648 . ad-hoc fix to avoid PHP warnings due to change in message text handling. Wikinaut's comment: must be marked as fixme ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Bug Squad -- Activate
As promised (and with a lot of help from Greg Varnum), I set up the Bug Squad WikiProject: https://www.mediawiki.org/wiki/Project:WikiProject_Bug_Squad As of this writing, we still need to get some graphics up, but it is a start and has the beginnings of a plan of action. You can sign up now! I like Tomasz's idea of having mobile-focused bug squad activities. I'd like to get input on how to do this. Because I think it will work best with a low barrier to entry (an area where the KDE bug squad runs into problems), and because the mobile team is running on top of PhoneGap (http://phonegap.com/), I wonder if we couldn't set up a labs instance of the PhoneGap interface. Tomasz, if we are able to do that, would that allow Bug Squad members to find some bugs without starting up an emulator? -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Re-introducing UNCONFIRMED state to bugzilla
Tomasz Finc tf...@wikimedia.org writes: Keep in mind that MediaWiki isn't the only software that we write. We already have a healthy beta group of Android and iOS testers. Perhaps some of them might want to be part of a bug squad team. I like the idea... Could you reply to my email titled Bug Squad -- Activate?? Mark. -- Mark A. Hershberger Bugmeister Wikimedia Foundation m...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99942]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r99942 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99942 Old status: new New status: resolved Commit summary for MediaWiki.r99942: * Do magic word parsing after parameter replacement in MediaWiki:Enotif_body and MediaWiki:Enotif_subject * Fix link to Special:EmailUser in case $wgEnotifUseRealName was true and the user defined a real name, link was pointing to Special:EmailUser/Real_Name instead of Special:EmailUser/User_Name * Simplified the code of EmailNotification::composeCommonMailtext() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113636]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113636 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113636 Old status: new New status: ok Commit summary for MediaWiki.r113636: Make SpecialAggregateGroups unlisted for now ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113631]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r113631. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113631#c32103 Commit summary for MediaWiki.r113631: Committing my unfinished cleanups - should still be fully functional. Major issue was the duplicated id parameters on different elements. Moved them to data-attributes. Aggregate group id is now stored only in the wrapper div. Subgroup ids are either in the remove button span or in the selector as value. Santhosh.thottingal's comment: wonderful, Niklas! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113708]: New comment added
Krinkle posted a comment on MediaWiki.r113708. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113708#c32104 Commit summary for MediaWiki.r113708: More cleanup of js, whitespaces. ping r113631 Krinkle's comment: pre - .text( $target.parent( 'a' ).text() ) + .text( $target.siblings( 'a' ).text() ) /pre This non-trivial change wasn't described in the commit-msg, was this committed intentional? If so, please explain what bug it is supposed to fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113708]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r113708. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113708#c32105 Commit summary for MediaWiki.r113708: More cleanup of js, whitespaces. ping r113631 Santhosh.thottingal's comment: the $target here is span, which does not have a parent 'a', but it is sibling of span. Fixes broken dissociate button in r113631. Sorry to add that in commit message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
