[Wikitech-l] planned Phabricator upgrade tomorrow

2019-05-21 Thread Daniel Zahn
Tomorrow we have planned a major upgrade of the Phabricator prod server.

Starting from around 00:00 UTC (after Evening SWAT) we want to switch from
phab1001 to phab1003 as the production server.

This will involve:

- switching from jessie to stretch
- switching from mod_php to php-fpm
- switching from PHP 5 to PHP 7.2
- upgrading apache from 2.4.10 to 2.4.25

We are also hoping it will finally fix the httpd memory leaks we have been
seeing on the current server for a long time and which require periodic
service restarts.

In case we run into any unexpected issue we will simply fall back to
phab1001
and keep running as before.

https://phabricator.wikimedia.org/T221389
https://phabricator.wikimedia.org/T182832
https://phabricator.wikimedia.org/T190568
https://phabricator.wikimedia.org/T151070

Cheers,

Daniel and Mukunda

-- 
Daniel Zahn 
Operations Engineer
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] "Patch-For-Review" tag in phabricator

2019-05-21 Thread Amir Sarabadani
Hey,
It's already stopped and running them on open tasks only for now sounds
like a good idea.

Let me do that.

On Tue, May 21, 2019 at 11:51 PM Antoine Musso  wrote:

> On 21/05/2019 23:40, Amir Sarabadani wrote:
> > Hey,
> > You probably know about the tag, it has been added automatically to
> > phabricator tickets when someone makes a patch to gerrit and mentions the
> > pabricator ticket (For example [0]). The problem is when the patch gets
> > merged the tag doesn't get removed automatically because there might be
> > other outstanding patches, etc.
> >
> > Now, lots of time of our developers is being spent on removing those tags
> > when they don't apply which is tedious and with lots of tasks incorrectly
> > having the tag, the tag itself is useless. So I wrote a bot to clean
> those
> > tags.
> >
> > In order to make sure I don't remove anything by mistake, the bot doesn't
> > touch the ticket if any of these conditions apply:
> > * If the tag is added by someone else than the gerrit bot
> > * If there's a link to github.com anywhere
> > * If there are still patches that are not merged (ta-duh)
> > * If gerritbot in any way acts out of ordinary (for example, comments
> twice
> > for adding one patch)
> >
> > It's going to spam your inbox. Sorry:(  I'm working on it to find a less
> > spammy way and will definitely run it with slow pace.
> >
> > [0]:https://phabricator.wikimedia.org/T155878#5190647
>
> Hello,
>
> I appreciate your initiative to cleanup Phabricator but in this case I
> do not see a point of removing #patch-for-review on tasks that are
> marked as resolved and are months, if not years old.
>
> Can you please stop this bot because it is flooding my email inbox. Or
> at least exclude tasks marked as resolved!
>
> Thank you!
>
> --
> Antoine "hashar" Musso
>
>

-- 
Amir (he/him)
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] "Patch-For-Review" tag in phabricator

2019-05-21 Thread Antoine Musso

On 21/05/2019 23:40, Amir Sarabadani wrote:

Hey,
You probably know about the tag, it has been added automatically to
phabricator tickets when someone makes a patch to gerrit and mentions the
pabricator ticket (For example [0]). The problem is when the patch gets
merged the tag doesn't get removed automatically because there might be
other outstanding patches, etc.

Now, lots of time of our developers is being spent on removing those tags
when they don't apply which is tedious and with lots of tasks incorrectly
having the tag, the tag itself is useless. So I wrote a bot to clean those
tags.

In order to make sure I don't remove anything by mistake, the bot doesn't
touch the ticket if any of these conditions apply:
* If the tag is added by someone else than the gerrit bot
* If there's a link to github.com anywhere
* If there are still patches that are not merged (ta-duh)
* If gerritbot in any way acts out of ordinary (for example, comments twice
for adding one patch)

It's going to spam your inbox. Sorry:(  I'm working on it to find a less
spammy way and will definitely run it with slow pace.

[0]:https://phabricator.wikimedia.org/T155878#5190647


Hello,

I appreciate your initiative to cleanup Phabricator but in this case I 
do not see a point of removing #patch-for-review on tasks that are 
marked as resolved and are months, if not years old.


Can you please stop this bot because it is flooding my email inbox. Or 
at least exclude tasks marked as resolved!


Thank you!

--
Antoine "hashar" Musso


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] "Patch-For-Review" tag in phabricator

2019-05-21 Thread Amir Sarabadani
Hey,
You probably know about the tag, it has been added automatically to
phabricator tickets when someone makes a patch to gerrit and mentions the
pabricator ticket (For example [0]). The problem is when the patch gets
merged the tag doesn't get removed automatically because there might be
other outstanding patches, etc.

Now, lots of time of our developers is being spent on removing those tags
when they don't apply which is tedious and with lots of tasks incorrectly
having the tag, the tag itself is useless. So I wrote a bot to clean those
tags.

In order to make sure I don't remove anything by mistake, the bot doesn't
touch the ticket if any of these conditions apply:
* If the tag is added by someone else than the gerrit bot
* If there's a link to github.com anywhere
* If there are still patches that are not merged (ta-duh)
* If gerritbot in any way acts out of ordinary (for example, comments twice
for adding one patch)

It's going to spam your inbox. Sorry :( I'm working on it to find a less
spammy way and will definitely run it with slow pace.

[0]: https://phabricator.wikimedia.org/T155878#5190647

-- 
Amir (he/him)
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l