[Wikitech-l] [Train] 1.35.0-wmf.26 status update

[Dan Duvall]

The 1.35.0-wmf.26 version of MediaWiki is blocked.[1]

The new version is deployed to group0,[2] but can proceed no further until
these issues are resolved:

* High rate of timeouts on jsonTruncated channel -
https://phabricator.wikimedia.org/T249162

Once these issues are resolved, train can resume. If these issues are
resolved on a Friday, the train will resume on Monday.

Thank you for your help in resolving these issues!

-- Your humble train toiler

[1]: https://phabricator.wikimedia.org/T247773
[2]: 

-- 
Dan Duvall
Senior Software Engineer, Release Engineering
Wikimedia Foundation 
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Scrum of scrums/2020-04-01

[Željko Filipin]

Hi,

for HTML version see
https://www.mediawiki.org/wiki/Scrum_of_scrums/2020-04-01

Željko

--

= 2020-04-01 =

== Callouts ==
* Release Engineering
** [All] Review guidance at [[wikitech:Deployments/Covid-19]] and Code
Deployment Office Hour at 17:00UTC in #wikimedia-office

== Product ==

=== iOS native app ===
* Updates:
** 6.6 release out on public beta (mobile-html integration) -
[[phab:project/view/4273]]
*** bug fixing and working towards code freeze on that

=== Android native app ===
* Updates:
** Beta candidate with mobile-html and Suggested Edits V4 features is being
tested for a shortly coming release.
** Actively working on tech debt on Android and some analytics work for the
release candidatesCurrent board P: [[phab:project/view/4645/]]

=== Web ===
* Updates:
** Summary: Vue.js iterations planning and continuing desktop improvements
project (DIP).
** [[Reading/Web/Desktop_Improvements|Desktop Improvements Project (Vector
/ DIP)]]:
*** [[phab:T244481|Provide basic FeatureManagement in Vector
codebase]]
*** [[phab:T243281|Build opt-out link for logged-in users with new
vector on]]
*** [[phab:T248399|Document Skin API and their stability, if any
(including Vector)]]
*** [[phab:T246419|Build collapsible sidebar and sidebar button
]]
*** [[Vue.js|Vue.js]] iterations planning.
** Mobile website (MinervaNeue / MobileFrontend):
*** [[phab:T248415|Regression: MediaWiki:Minerva.css is being
loaded on mobile site]]
*** [[phab:T248500|Replace $wgMobileFrontendLogo with
$wgLogos]]
*** [[phab:T248141|Regression: MobileFrontend overrides
non-existent user page handling in desktop view]]
*** [[phab:T248360|Phan warning in
"includes/specials/SpecialMobileDiff.php" - working around by
disabling]]
*** [[phab:T237230|Long edit summary/titles/user breaking AMC
special pages]]
** Miscellaneous
*** [[phab:T248133|WebInstallerOutput should more elegantly load
Vector stylesheet rather than hardcoding a reference]]
*** [[phab:T212521|RFC: Reconsider how we run QUnit unit
tests]]

=== Product Infrastructure ===
* Updates:
** /page/summary endpoint: updating the list of api_urls endpoints.
Removing references to removed endpoints. Is anyone even using this?
[[[phab:T247991]]]
** upcoming OSM data re-import in codfw [[[phab:T243609]]]
** Wikimedia Push Notification Service RFC published: [[phab:T249065]]

=== Structured Data ===
* Updates:
** minor updates to MachineVision
** failed attempt to get wikibase constraints deployed to production
commons :/
** experimenting with Vue.js on frontend
** media search prototype

== Technology ==

=== Fundraising Tech ===
* Updates:
** Fixes to backup payment processor NL bank transfer integration
[[phab:T247885]], [[phab:T248712]]
** Code cleanup and PHP7 updates for payment library
** Looking for alternatives to 3rd party cookies for hiding CentralNotice
banners across projects
** Determining how to get 'drush' on debian buster - might have to bug
releng for repo reset
** Reviewing contractor work on CentralNotice
** Improving email CC, BCC handling in core CiviCRM
** CiviCRM contact deduplication fixes: [[phab:T247377]]
** Testing migrating recurring card donations from main processor's old API
to new API
** Starting work on matching gifts database sync: [[phab:T247878]]

=== Core Platform ===
* Blocking:
** Search Platform: MW Job consumers sometimes pause for several minutes
[[phab:T224425]]
* Updates:
** API gateway designs
** Finished Core REST API MVP epic [[phab:T229662]]
** New backwards-compatible hooks interface coming

=== Engineering Productivity ===

 Release Engineering 
* Updates:
** [All] Deployments/Covid-19 [[wikitech:Deployments/Covid-19]]
** Train Health
*** Last week: 1.35.0-wmf.25 - [[phab:T233873]]
*** This week: 1.35.0-wmf.26 - [[phab:T247773]]
*** Next week: 1.35.0-wmf.27 - [[phab:T247774]]

=== Search Platform ===
* Blocked by:
** Core: MW Job consumers sometimes pause for several minutes
[[phab:T224425]]
* Updates:
** Data for events from wdqs needs to be deleted after 90 days and/or
sanitized [[phab:T247034]]
* Stuff no one else cares about:

=== Site Reliability Engineering ===
* Updates:
** TLS 1.3 support being rolled out gradually to cache-upload.
** After some routing changes, traffic to codfw will be routed more
consistently and geographically correct.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Resource Loader messes up Leaflet CSS

[Derk-Jan Hartman]

This is because you have not initialized the imagePath of leaflet markers.
Because of that it falls back to detectIconPath(), which isn't smart enough to 
handle the myriad of forms of background image css that are possible with post 
processing systems these days.

This issue is also known in Leaflet: 
https://github.com/Leaflet/Leaflet/issues/4968 


DJ

> On 1 Apr 2020, at 01:08, Jeroen De Dauw  wrote:
> 
> Hey,
> 
> When using the Maps extension together with MediaWiki 1.34 or later the
> markers on Leaflet maps do not show correctly.
> 
> Example:
> https://user-images.githubusercontent.com/146040/78082503-7b1c1680-73b3-11ea-8c15-28552363a7f4.png
> 
> Issue tread: https://github.com/JeroenDeDauw/Maps/issues/607
> 
> They show fine on older versions of MediaWiki. Though only if Maps loads
> the leaflet.css file by stuffing an Html::linkedStyle() into the header on
> top of using the Resouce Loader. Without that hack the bug also shows up on
> older MediaWiki versions.
> 
> As you can deduce from that hack working, Resouce Loader is somehow
> involved. This can be confirmed by setting $wgResourceLoaderDebug to true,
> which causes the bug to disappear. I tracked this down a bit and found that
> this modification "fixes" the bug as well:
> https://github.com/JeroenDeDauw/MediaWiki/commit/1713ccde9de7d59634b1a134c58ee3c84ba01642
> 
> Without knowing how the Leaflet library is being broken or knowing Resource
> Loader internals, this is rather hard to track down further. Any help is
> much appreciated.
> 
> Some relevant code:
> 
> * Resource loader module definition:
> https://github.com/JeroenDeDauw/Maps/blob/master/extension.json#L111
> * leaflet.css:
> https://github.com/JeroenDeDauw/Maps/blob/master/resources/lib/leaflet/leaflet.css
> 
> Cheers
> 
> --
> Jeroen De Dauw | www.EntropyWins.wtf 
> Professional wiki hosting and services: www.Professional.Wiki
> 
> Entrepreneur | Software Crafter | Open Source | Wikimedia | Speaker
> ~=[,,_,,]:3
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] List related to repositories which haven't mediawiki/mediawiki-codesniffer

[Zoran Dori]

Hello,
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MediaWikiFarm/+/master
is listed on https://tools.wmflabs.org/phpcs/missing but it have phpcs.xml
file.

What is problem?

Best regards,
Zoran.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Resource Loader messes up Leaflet CSS

[Mateus Santos]

Hey Jeroen, thanks for raising it. Can you fill a phab task for that? I
think that's a better way to make it visible.

On Wed, Apr 1, 2020 at 1:09 AM Jeroen De Dauw 
wrote:

> Hey,
>
> When using the Maps extension together with MediaWiki 1.34 or later the
> markers on Leaflet maps do not show correctly.
>
> Example:
>
> https://user-images.githubusercontent.com/146040/78082503-7b1c1680-73b3-11ea-8c15-28552363a7f4.png
>
> Issue tread: https://github.com/JeroenDeDauw/Maps/issues/607
>
> They show fine on older versions of MediaWiki. Though only if Maps loads
> the leaflet.css file by stuffing an Html::linkedStyle() into the header on
> top of using the Resouce Loader. Without that hack the bug also shows up on
> older MediaWiki versions.
>
> As you can deduce from that hack working, Resouce Loader is somehow
> involved. This can be confirmed by setting $wgResourceLoaderDebug to true,
> which causes the bug to disappear. I tracked this down a bit and found that
> this modification "fixes" the bug as well:
>
> https://github.com/JeroenDeDauw/MediaWiki/commit/1713ccde9de7d59634b1a134c58ee3c84ba01642
>
> Without knowing how the Leaflet library is being broken or knowing Resource
> Loader internals, this is rather hard to track down further. Any help is
> much appreciated.
>
> Some relevant code:
>
> * Resource loader module definition:
> https://github.com/JeroenDeDauw/Maps/blob/master/extension.json#L111
> * leaflet.css:
>
> https://github.com/JeroenDeDauw/Maps/blob/master/resources/lib/leaflet/leaflet.css
>
> Cheers
>
> --
> Jeroen De Dauw | www.EntropyWins.wtf 
> Professional wiki hosting and services: www.Professional.Wiki
> 
> Entrepreneur | Software Crafter | Open Source | Wikimedia | Speaker
> ~=[,,_,,]:3
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Resource Loader messes up Leaflet CSS

[Thiemo Kreuz]

I tracked it down a bit, using the URLs
https://www.semantic-mediawiki.org/wiki/Help:Leaflet_format vs.
https://www.semantic-mediawiki.org/wiki/Help:Leaflet_format?debug=1

These weird "shadow" pointers are indeed shadows. The bug happens on
the "leaflet-shadow-pane" layer. The individual
"leaflet-marker-shadow"  elements on this layer are supposed to
show the image "marker-shadow.png", but for some reason show the image
"marker-icon.png" instead. This happens in the actual src="…" argument
of the  tag, not in CSS.

There is really something broken there:

src="…/marker-icon.png?2273e)marker-shadow.png"

I was not yet able to track it down further.

The code your demo
https://github.com/JeroenDeDauw/MediaWiki/commit/1713ccde9de7d59634b1a134c58ee3c84ba01642
happens to touch does not look like it should affect HTML, but only
CSS. I was not able to find any code in ResourceLoader that messes
with  tags or src="…" arguments.

Best
Thiemo

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l